UnitFramesImproved BossTargetFrame Problem

pas06 · 01-06-16, 09:30 AM

Hi,

i am currently using this addon but it seems to have an problem with the Boss(2-4)TargetFrame. The problems seems to exist for a long time but it never has been fixed. i don't know what the problem is in the code. Maybe here is some skilled person that can fix this? this bug is very annoying because it hides for example the bossframes of the archimonde adds.

here are the code snippets causing this problem (i think):

Code:

hooksecurefunc("BossTargetFrame_OnLoad", UnitFramesImproved_BossTargetFrame_Style);

UnitFramesImproved_BossTargetFrame_Style(Boss1TargetFrame);
	UnitFramesImproved_BossTargetFrame_Style(Boss2TargetFrame);
	UnitFramesImproved_BossTargetFrame_Style(Boss3TargetFrame);
	UnitFramesImproved_BossTargetFrame_Style(Boss4TargetFrame);

function UnitFramesImproved_BossTargetFrame_Style(self)
	self.borderTexture:SetTexture("Interface\\Addons\\UnitFramesImproved\\Textures\\UI-UnitFrame-Boss");

	UnitFramesImproved_Style_TargetFrame(self);
	if (not (characterSettings["FrameScale"] == nil)) then
		if not InCombatLockdown() then 
			self:SetScale(characterSettings["FrameScale"] * 0.9);
		end
	end
end

function UnitFramesImproved_Style_TargetFrame(self)
	--if not InCombatLockdown() then
		local classification = UnitClassification(self.unit);
		if (classification == "minus") then
			self.healthbar:SetHeight(12);
			self.healthbar:SetPoint("TOPLEFT",7,-41);
			self.healthbar.TextString:SetPoint("CENTER",-50,4);
			self.deadText:SetPoint("CENTER",-50,4);
			self.Background:SetPoint("TOPLEFT",7,-41);
		else
			self.healthbar:SetHeight(29);
			self.healthbar:SetPoint("TOPLEFT",7,-22);
			self.healthbar.TextString:SetPoint("CENTER",-50,6);
			self.deadText:SetPoint("CENTER",-50,6);
			self.nameBackground:Hide();
			self.Background:SetPoint("TOPLEFT",7,-22);
		end
		
		self.healthbar:SetWidth(119);
		self.healthbar.lockColor = true;
	--end
end

thanks in advance

Phanx · 01-12-16, 06:13 AM

I don't see anything obviously problematic in that code snippet. Can you be more specific about the problem?

What do you expect to see, and when/where do you expect to see it?
What do you actually see in that situation/place instead?
Have you double-checked your expectations against the default UI (eg. does the default UI show what you expect when/where you expect)?
Are there any error messages from the addon, either in that situation/place, or when you first log in?
Does the problem still occur when you disable all other addons?

pas06 · 01-12-16, 08:53 AM

Thanks for reply

What do you expect to see, and when/where do you expect to see it?
- the other Bossframes of for example doomfire or Death Brand are not shown. if i disable the addon they are shown.
What do you actually see in that situation/place instead?
- i see only the bossframe of the Boss itself
Are there any error messages from the addon, either in that situation/place, or when you first log in?
- no message at login only when the frist bossframe is shown:
The error message, that appears when the first Bossframe is shown:
7x [ADDON_ACTION_BLOCKED] AddOn 'UnitFramesImproved' tried to call the protected function 'Boss2TargetFrame:Hide()'
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Hide'
FrameXML\TargetFrame.lua:108: in function <FrameXML\TargetFrame.lua:104>
[C]: ?
[C]: in function `TargetFrame_Update'
FrameXML\TargetFrame.lua:174: in function `OnEvent'
FrameXML\UnitFrame.lua:676: in function <FrameXML\UnitFrame.lua:674>
Does the problem still occur when you disable all other addons?
- haven't tried it yet but the error is gone if i disable it and use the default ui instead all bossframes are shown

This is the addon i am talking about: http://www.curse.com/addons/wow/unitframesimproved
there are other posts that are about the same topic and a ticket on curseforge also exists about this problem. The author replied regarding this problem:
"Can't do much about this unfortunately. The hooks used don't jive well with the Blizz code at all times. Unless Blizz cleans up theri code to make it easier to hook into, there's not much I can do."

is this really the case? other unitframe addons don't have a problem with this.

Resike · 01-12-16, 10:27 AM

Originally Posted by pas06

Thanks for reply

What do you expect to see, and when/where do you expect to see it?
- the other Bossframes of for example doomfire or Death Brand are not shown. if i disable the addon they are shown.
What do you actually see in that situation/place instead?
- i see only the bossframe of the Boss itself
Are there any error messages from the addon, either in that situation/place, or when you first log in?
- no message at login only when the frist bossframe is shown:
The error message, that appears when the first Bossframe is shown:
7x [ADDON_ACTION_BLOCKED] AddOn 'UnitFramesImproved' tried to call the protected function 'Boss2TargetFrame:Hide()'
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Hide'
FrameXML\TargetFrame.lua:108: in function <FrameXML\TargetFrame.lua:104>
[C]: ?
[C]: in function `TargetFrame_Update'
FrameXML\TargetFrame.lua:174: in function `OnEvent'
FrameXML\UnitFrame.lua:676: in function <FrameXML\UnitFrame.lua:674>
Does the problem still occur when you disable all other addons?
- haven't tried it yet but the error is gone if i disable it and use the default ui instead all bossframes are shown

This is the addon i am talking about: http://www.curse.com/addons/wow/unitframesimproved
there are other posts that are about the same topic and a ticket on curseforge also exists about this problem. The author replied regarding this problem:
"Can't do much about this unfortunately. The hooks used don't jive well with the Blizz code at all times. Unless Blizz cleans up theri code to make it easier to hook into, there's not much I can do."

is this really the case? other unitframe addons don't have a problem with this.

Other unitframe usually builds their own frames instead of restyling the blizzard ones.

pas06 · 01-12-16, 11:10 AM

So its actually not possible to make it work in the way it is modifying the frame right now?
Or is there a way to fix this problem?

Resike · 01-12-16, 11:24 AM

Originally Posted by pas06

So its actually not possible to make it work in the way it is modifying the frame right now?
Or is there a way to fix this problem?

What happens if you remove the InCombatLockdown() comment?

Lua Code:

function UnitFramesImproved_Style_TargetFrame(self)
    if not InCombatLockdown() then
        local classification = UnitClassification(self.unit);
        if (classification == "minus") then
            self.healthbar:SetHeight(12);
            self.healthbar:SetPoint("TOPLEFT",7,-41);
            self.healthbar.TextString:SetPoint("CENTER",-50,4);
            self.deadText:SetPoint("CENTER",-50,4);
            self.Background:SetPoint("TOPLEFT",7,-41);
        else
            self.healthbar:SetHeight(29);
            self.healthbar:SetPoint("TOPLEFT",7,-22);
            self.healthbar.TextString:SetPoint("CENTER",-50,6);
            self.deadText:SetPoint("CENTER",-50,6);
            self.nameBackground:Hide();
            self.Background:SetPoint("TOPLEFT",7,-22);
        end
        
        self.healthbar:SetWidth(119);
        self.healthbar.lockColor = true;
    end
end

pas06 · 01-12-16, 12:21 PM

exactly the same

Resike · 01-12-16, 12:39 PM

Originally Posted by pas06

exactly the same

The taint should be somewhere else then, maybe not even in the addon.

pas06 · 01-12-16, 12:46 PM

how can i find this out? Just by disabling anything else than this addon?

pas06 · 01-12-16, 01:07 PM

with everything disabled and only !Buggrabber, Bugsack and UnitFramesImproved enabled and the change you posted above i got this(and the same problem still exists):
6x [ADDON_ACTION_BLOCKED] AddOn 'UnitFramesImproved' tried to call the protected function 'Boss2TargetFrame:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\TargetFrame.lua:110: in function <FrameXML\TargetFrame.lua:104>
[C]: ?
[C]: ?
[C]: in function `TargetFrame_Update'
FrameXML\TargetFrame.lua:174: in function `OnEvent'
FrameXML\UnitFrame.lua:676: in function <FrameXML\UnitFrame.lua:674>

Locals:

this means that the problem is in the addon right?

Resike · 01-12-16, 01:44 PM

Originally Posted by pas06

with everything disabled and only !Buggrabber, Bugsack and UnitFramesImproved enabled and the change you posted above i got this(and the same problem still exists):
6x [ADDON_ACTION_BLOCKED] AddOn 'UnitFramesImproved' tried to call the protected function 'Boss2TargetFrame:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\TargetFrame.lua:110: in function <FrameXML\TargetFrame.lua:104>
[C]: ?
[C]: ?
[C]: in function `TargetFrame_Update'
FrameXML\TargetFrame.lua:174: in function `OnEvent'
FrameXML\UnitFrame.lua:676: in function <FrameXML\UnitFrame.lua:674>

Locals:

this means that the problem is in the addon right?

How can you actually trigger the problem? I'll look into it.

pas06 · 01-12-16, 01:49 PM

installing the addon and encounter a boss where the bossframes get toggled

I really appreciate your help

Resike · 01-12-16, 02:05 PM

Originally Posted by pas06

installing the addon and encounter a boss where the bossframes get toggled

I really appreciate your help

Comment this line around line 83:

Lua Code:

--hooksecurefunc("TargetFrame_Update", UnitFramesImproved_TargetFrame_Update);

Then it should be fixed. The function itself is not even needed.
On the other side, the addon using a lot of global functions which could potentionally cause some other errors.

pas06 · 01-12-16, 02:13 PM

commenting out this line didn't fix it

Resike · 01-12-16, 03:27 PM

Originally Posted by pas06

commenting out this line didn't fix it

My bad, to be honest i was fixing some other stuff while i was parsing through the code, so it might be a combination with those fixes.

There is the fully modified addon, try this one:
https://github.com/Resike/UnitFrames...ive/master.zip

pas06 · 01-12-16, 03:55 PM

i tried it but it didn't make any difference still exactly the same. if i make an ui reload infight all bossframes are there, first with green healtbar and if i damage the unit it turns red.

Resike · 01-12-16, 04:19 PM

Originally Posted by pas06

i tried it but it didn't make any difference still exactly the same. if i make an ui reload infight all bossframes are there, first with green healtbar and if i damage the unit it turns red.

I donno i tested it on the first boss in Blackrock Caverns and the error is gone for me.

pas06 · 01-12-16, 04:38 PM

i tried this boss it works on this boss. i think thats because there are not more bossframes. The error only occurs if the encounter has more than one bossframe - try the second boss (the error still occurs for me there)

i am sorry i haven't noticed that this only occurs if there are more than one bossframe
Thanks in advance

Resike · 01-12-16, 06:49 PM

Originally Posted by pas06

i tried this boss it works on this boss. i think thats because there are not more bossframes. The error only occurs if the encounter has more than one bossframe - try the second boss (the error still occurs for me there)

i am sorry i haven't noticed that this only occurs if there are more than one bossframe
Thanks in advance

Hmm, i'll look into it. I'm pretty sure there is a solution for the other bosses too.

pas06 · 01-26-16, 11:33 AM

Have you tried it out yet?