Unitframe Name Background

[cokedrivers]

Is there better code way to do this besides the following?

local frame = CreateFrame("FRAME")
frame:RegisterEvent("GROUP_ROSTER_UPDATE")
frame:RegisterEvent("PLAYER_TARGET_CHANGED")
frame:RegisterEvent("PLAYER_FOCUS_CHANGED")
frame:RegisterEvent("UNIT_FACTION")
 
local function eventHandler(self, event, ...)
    if UnitIsPlayer("target") then
        c = { 0, 0, 0 }
        TargetFrameNameBackground:SetTexture([[Interface\DialogFrame\UI-DialogBox-Background]])
    end
    if UnitIsPlayer("focus") then
        c = { 0, 0, 0 }
        FocusFrameNameBackground:SetTexture([[Interface\DialogFrame\UI-DialogBox-Background]])
    end
end
 
frame:SetScript("OnEvent", eventHandler)

Thanks in advance.
Coke

[myrroddin]

A few questions.

• Is the variable 'c' a local variable, and not in the global namespace?
• 'c' is not descriptive. What does it do? Where do you use it? In a year, 'c' will not mean anything to you, nor anyone else. If it is colours, call it 'MyAddOnName_UnitColors' or something that tells you what use it serves.
• In your event handler function, you are not checking for if event == "EVENT_NAME" then...
• Since you are only checking for focus and target, why register the other events?

As for "is there a better way", if you could be more forthcoming about what you are trying to do overall, that would help. Right now, you haven't posted enough code to properly answer.

[Phanx]

1. Your "c" variable is currently global. Globals are bad, mmkay.

2. You're currently creating a new table every time your function runs. This is also bad. Create the table once, and reference it inside your function.

3. You're not even doing anything with that table, so just get rid of it.

4. There's nothing wrong with your event handler (I think Myrroddin misread what you're doing there, as you're not checking any event arguments, you're checking whether the specified unit tokens currently belong to player units) but you don't need to define it outside of the SetScript call unless you're going to be doing something else with it (such as using the same function on another frame). The way you're doing it won't hurt anything, it's just unnecessarily messy.

frame:SetScript("OnEvent", function(self, event, ...)
     -- Do your thing here.
end)

[Lombra]

Don't know about "better" way, but slightly prettier, perhaps.

local frame = CreateFrame("FRAME")
frame:RegisterEvent("GROUP_ROSTER_UPDATE")
frame:RegisterEvent("PLAYER_TARGET_CHANGED")
frame:RegisterEvent("PLAYER_FOCUS_CHANGED")
frame:RegisterEvent("UNIT_FACTION")

local unitRegions = {
	target = TargetFrameNameBackground,
	focus = FocusFrameNameBackground,
}

frame:SetScript("OnEvent", function(self, event, ...)
	for unit, region in pairs(unitRegions) do
		if UnitIsPlayer(unit) then
			c = { 0, 0, 0 } -- ??
			region:SetTexture([[Interface\DialogFrame\UI-DialogBox-Background]])
		end
	end
end)

[cokedrivers]

Originally Posted by Lombra Don't know about "better" way, but slightly prettier, perhaps. local frame = CreateFrame("FRAME") frame:RegisterEvent("GROUP_ROSTER_UPDATE") frame:RegisterEvent("PLAYER_TARGET_CHANGED") frame:RegisterEvent("PLAYER_FOCUS_CHANGED") frame:RegisterEvent("UNIT_FACTION") local unitRegions = { target = TargetFrameNameBackground, focus = FocusFrameNameBackground, } frame:SetScript("OnEvent", function(self, event, ...) for unit, region in pairs(unitRegions) do if UnitIsPlayer(unit) then c = { 0, 0, 0 } -- ?? region:SetTexture([[Interface\DialogFrame\UI-DialogBox-Background]]) end end end)

Thank You for this it works perfectly.

Coke

[cokedrivers]

Not sure why but the background does not change until I click on my own portrait.

Here is the current code:

local frame = CreateFrame("FRAME")
        frame:RegisterEvent("GROUP_ROSTER_UPDATE")
        frame:RegisterEvent("PLAYER_TARGET_CHANGED")
        frame:RegisterEvent("PLAYER_FOCUS_CHANGED")
        frame:RegisterEvent("UNIT_FACTION")
 
        local unitRegions = {
            target = TargetFrameNameBackground,
            focus = FocusFrameNameBackground,
            boss1 = Boss1TargetFrameNameBackground,
            boss2 = Boss2TargetFrameNameBackground,
            boss3 = Boss3TargetFrameNameBackground,
            boss4 = Boss4TargetFrameNameBackground, 
        }
 
        frame:SetScript("OnEvent", function(self, event, ...)
            for unit, region in pairs(unitRegions) do
                if UnitIsPlayer(unit) then
                    region:SetTexture('Interface\\DialogFrame\\UI-DialogBox-Background')
                end
            end
        end)

[Phanx]

Try adding PLAYER_ENTERING_WORLD to the list of registered events.

[cokedrivers]

Originally Posted by Phanx Try adding PLAYER_ENTERING_WORLD to the list of registered events.

Still don't work until I click my own unitframe then it works.

Not a huge problem just a pesky one.

Coke