Unable to see the problem with my function

[CrazyCactuaR]

function IAmStill()
	currentSpeed, runSpeed, flightSpeed, swimSpeed = GetUnitSpeed("Player")
	if currentSpeed == 0 then
		return true
	else
		return false
	end
end
iam = {
	still = IAmStill(),
}

Hi all, Hopefully someone can guide my blindness and show me the error of my ways. For some unknown reason i am unable to see why this is incorrectly displaying "true" even when its called when i am moving.

This is called by doing /script print(iam.still())

If i were to do print(IAmMoving()) this would show the correct result. (false when moving, true when still)

Thank you in advance to any whole can solve this annoying problem i have ran into.

[Clamsoda]

local function IAmStill()
    local currentSpeed = GetUnitSpeed("player")
 
    if (currentSpeed == 0) then
        return true
    else
        return false
    end
end
 
IAm = {
    still = IAmStill
}

1) "Player" isn't a valid UnitID, "player" is.
2) Make IAmStill local.
3) IAm.still needs to be a function reference, not the return of a function (denoted by ()).
4) I don't condone making IAm global, nor do I condone the way you are calling the function, but I am hoping that it is a crude test and that you intend to localize the table and call it in a better way.

/run print(IAm.still()) should work.

[Vrul]

function IAmStill()
	return GetUnitSpeed("player") == 0
end
iam = {
	still = IAmStill,
}

[Vlad]

Just for fun:

local IAm = {}

function IAm:Still()
  return GetUnitSpeed("player") == 0
end

If IAm:Still() then ... end

If you want to keep your functions in a table, then this might be the proper way to go!

[zork]

I always thought that the double-point notation could not be used on a table object. Nice.

[CrazyCactuaR]

Thank you all for your variations on the solution.

Your right it was a way of toying with a new method. I had hopes i could make life easier upon myself by having a list of table values such as my.Level, my.Race, ami.Moving, ami.Dead and so on.

What really confuses me was the use of (), if i were to put;

/script print(iam.still())

and the table calls it by still = IAmStill, then i see i am returned the correct value when i am moving/idle.

But having print(iam.still) and still = IAmStill(), i simply get a true return regardless of what im doing.

Confusing for myself but at least you helped me find a working solution. Again, thank you all for your help you provided.

[Phanx]

Originally Posted by zork I always thought that the double-point notation could not be used on a table object. Nice.

o_O

tbl:func() is nothing but syntatctic sugar for tbl.func(tbl) and you can use either calling style regardless of whether you defined your function using tbl.func(self) or tbl:func()

[Vlad]

Just to try and explain the difference between . and : when calling a table function:

local t = {
  a = 1,
}

function t:test(X)
  -- "self" is referring to the "t" object (automatically assigned)
  self.a = self.a + X -- increment t.a by X
end

function t.test(self, X)
  -- like before, "self" is referring to the "t" object
  -- notice how the argument "self" must be declared
  -- you could even change it to something entirely different,
  -- keep in mind that "self" would be nil if we didn't declare it like this
end

function t.test()
  -- "self" is nil
end

So the main issue would be, if you want to pass something down to a widget, for example:

local t = {}
function t.test(self, elapsed)
  -- "self" is actually "frame" and not "t" because of the way it is being called by the frame itself
end
frame:SetScript("OnUpdate", t.test)

-- note that you could manually call "t:test(5)" that way "self" would refer to "t" and elapsed would have the value 5

This can be confusing at first, but play a bit with it and you will figure out how it works. Note that you can't pass a function reference using "t:test" because : would indicate calling the function where "t" would be assigned to the "self" variable, while . is simply referencing it.

[Vrul]

Originally Posted by CrazyCactuaR What really confuses me was the use of (), if i were to put; /script print(iam.still()) and the table calls it by still = IAmStill, then i see i am returned the correct value when i am moving/idle. But having print(iam.still) and still = IAmStill(), i simply get a true return regardless of what im doing.

iam.still = IAmStill

Saves a reference to the function IAmStill into iam.still

print(iam.still())

Evaluates if you are moving or not based on current conditions since it is the same as calling IAmStill.

iam.still = IAmStill()

Saves whether you were moving or not when IAmStill was called into iam.still.

print(iam.still)

Retrieves the previously saved state from IAmStill, does not re-evaluate the current state.

[Vlad]

If you have a function named "still" then you do something like print(still) then you see "function 0x0492..." i.e. the reference of that function. But if you do print(still()) then you call that function and it returns what ever it returns, then that value is being printed.