Hooking my own functions

[Duugu]

Hey all

I'm trying to so find some performance leaks in my addons code. My first thought was to hook everything and to see how long it takes.

So I came up with this:

_, ProfilerTestAddon= ...
 
function ProfilerTestAddon:Test1()
    print("Test1")
end
function ProfilerTestAddon:Test2()
    print("Test2")
end
 
local function Profiler(self, fName, func)
    print("profiler:",fName, GetTime(), func)
end
 
for i, v in pairs(ProfilerTestAddon) do 
    if type(v) == "function" then
        hooksecurefunc(ProfilerTestAddon, i, function(self) Profiler(self, i, v) end)
    end
end

Works as expected.

But ... to see how much time function needs a post-hook via hooksecurefunc obv. isn't enough. So I tried this:

_, ProfilerTestAddon= ...
 
function ProfilerTestAddon:Test1()
    print("Test1")
end
function ProfilerTestAddon:Test2()
    print("Test2")
end
 
local function Profiler(self, fName, func)
    print("profiler IN:",fName, GetTime())
    func()
    print("profiler OUT:",fName, GetTime())
end
 
for i, v in pairs(ProfilerTestAddon) do 
    if type(v) == "function" then
        print("hooking", i)
        local tmp = v
        v = function(self) 
            Profiler(self, i, v) 
        end
        print(tmp == v)
    end
end

To my surprise that didn't worked.

It iterates the functions. The line print(tmp == v) returns false. I can call ProfilerTestAddon:Test1() and it does print "Test2". But that's it. Profiler() is not called.

What the hell could be wrong with it?


[e]
Even

for i, v in pairs(ProfilerTestAddon) do 
    if type(v) == "function" then
        print("hooking", i)
        local tmp = v
        v = nil
        print(tmp == v)
    end
end

doesn't break something. ProfilerTestAddon:Test1() does still work.

[Lombra]

Where do you suppose Profiler would be called? What I think you might be missing here is that reassigning the loop variables won't actually change the table, which I think is what you're looking to do. Reassigning v won't change the value of table[i] in the same way that this "doesn't work":

a = 1
b = a
b = 2
print(a) -- a is still 1

[Duugu]

Doh. Stupid me. *fp*
Thanks Lombra.

[Rilgamon]

While this is hopefully only for local testing ... never forget the underscore to be defined local

_, ProfilerTestAddon= ...

[Duugu]

While this is hopefully only for local testing

Sure it is.

Don't know if I'm the only one who never heard of it, but I just realized that there is something like GetFunctionCPUUsage().

[Phanx]

Even for local testing you should be vigilant in avoiding global leaks, especially generic ones like _, as you can easily taint vast swaths of the UI and inadvertently let other addons (and even the Blizzard UI code) mess with your code. It's just not that hard to type the "local" keyword in front of your variable declaration. Stop being so lazy; even I'm not that lazy. ಠ_ಠ