List of functions a function calls

[Miiru]

Is it possible to get a list of functions a function calls? Or to output them ingame?

I am looking at this function: http://wowprogramming.com/docs/api/UseToy

They seem to have changed something on ptr and it would probably be helpful for me to know which functions it calls. Didnt find anything related in blizzard_collections addons.

Thanks

[Phanx]

I'm not really sure what you're asking. "UseToy" is a game API function -- if it calls any other functions, they are on the C backend, out of sight of anything in Lua.

[Miiru]

I got the function ToySpellButton_UpdateButton(self) hooked to change the layout of the ToyBox-Frame which works without any problems on live realms.

Now on ptr it works (besides little changes to not cause taint) untill the point someone uses a toy. Then it reverts back any changes i did to the fontstrings.

As i cannot find any other functions which could be the cause of this error, i wanted to know what exactly UseToy does besides actually using the toy (you know setting cooldowns, greying out items whatever).

So you say that is impossible?

[Seerah]

It might not be anything that UseToy() does, but something after the UI calls that function.

The toy box UI might be doing something like this:

function ToyButton12:OnClick()
     UseToy()
     --do some other stuff to update the UI
end

/edit: or maybe some sort of callback or event that happens that tells the UI to refresh

[Miiru]

Originally Posted by Seerah function ToyButton12:OnClick()      UseToy()      --do some other stuff to update the UI end

This is the onclick:

function ToySpellButton_OnClick(self, button)
    if ( button ~= "LeftButton" ) then
        if (PlayerHasToy(self.itemID)) then
            ToyBox_ShowToyDropdown(self.itemID, self, 0, 0);
        end
    else
        UseToy(self.itemID);
    end
end

Doesn't look like it does something there.

/edit: or maybe some sort of callback or event that happens that tells the UI to refresh

But shouldnt it trigger the hooked function then? Why does it only change the font-string when the hook also changes borders etc :/

[Seerah]

I don't know. But if you show your code we'll have more to go on.

[Miiru]

This is the current ptr Toybox.lua file:

http://pastebin.com/08n4FSEe

This is my hook:

-- Captain Hook's Hooks
 
    
    local function miirgui_ToySpellButton_UpdateButton(self)
        local itemIndex = (ToyBox_GetCurrentPage() - 1) * 18 + self:GetID();
        local toyString = self.name;
        local itemID, toyName, icon = C_ToyBox.GetToyInfo(self.itemID);
        local slotFrameCollected = self.slotFrameCollected;
        local slotFrameUncollected = self.slotFrameUncollected;
        if (PlayerHasToy(self.itemID)) then
            toyString:SetTextColor(1,1,1,1);
            toyString:SetShadowColor(0, 0, 0, 1);
            toyString:SetFont(unpack(miirgui.small))
            slotFrameCollected:Show()
            slotFrameCollected:SetTexture("Interface\\Buttons\\UI-Quickslot")
            slotFrameCollected:SetHeight(74)
            slotFrameCollected:SetWidth(74)
        else
            toyString:SetTextColor(0.5, 0.5, 0.5, 1);
            toyString:SetFont(unpack(miirgui.small))
            toyString:SetShadowColor(0, 0, 0, 0);
            slotFrameUncollected:SetDesaturated(true)
            slotFrameUncollected:SetTexture("Interface\\Buttons\\UI-Quickslot")
            slotFrameUncollected:SetHeight(74)
            slotFrameUncollected:SetWidth(74)
            slotFrameUncollected:Show();
        end
            CollectionsSpellButton_UpdateCooldown(self);
    end
    
            hooksecurefunc("ToySpellButton_UpdateButton",miirgui_ToySpellButton_UpdateButton)

I had to change the code slightly to avoid taint.

The hook works fine and does what it should, the only weird thing is that the font color (it's only the color, not even the flags) is changed when a toy is used (regardless if clicked or with /usetoy xx).

[Phanx]

Well, I would imagine using a toy triggers an event, so the UI knows to update stuff like the cooldown spiral.

The ToyBox registers for the "TOYS_UPDATED" event:
http://www.townlong-yak.com/framexml..._ToyBox.lua#14

and when that event fires:
http://www.townlong-yak.com/framexml..._ToyBox.lua#17

one of the functions it calls is "ToyBox_UpdateButtons":
http://www.townlong-yak.com/framexml...ToyBox.lua#246

which loops over all the buttons and calls "ToySpellButton_UpdateButton" on each of them:
http://www.townlong-yak.com/framexml...ToyBox.lua#159

and that function does indeed set the color of some text:
http://www.townlong-yak.com/framexml...ToyBox.lua#213
http://www.townlong-yak.com/framexml...ToyBox.lua#230

and since you are post-hooking that function, your changes shouldn't be overridden.

The only thing I notice is that you're duplicating a lot of code unnecessarily. The original function already shows/hides the collected/uncollected textures as necessary and updates the cooldown, so you should not do those things again in your hook. Your code should only include the parts that are different.

[Miiru]

Thank you very much Phanx. I was also under the impression that the code should not be overwritten. I am gonna wait for a few patches and see if they are doing anything related to the toy box.

I am gonna work on that unnecessary code stuff

[Miiru]

It even gets weirder now. When i have the toy window open and i cast a cast, it will also revert the colors back.

I am gonna upload a seperate version of only the color changes for that window and see if it behaves like that for everybody :/

Here it is: http://boujong.net/toybox.zip

This only changes the font-string color of the toybox on ptr. When a spell is cast or a toy is 'used' it reverty the changes back. :S