casting bar: attempt to perform arithmetic

ObbleYeah · 08-10-14, 09:13 AM

Code:

\castbar.lua:77: attempt to perform arithmetic on local "endTime" (a nil value)

happens when i'm casting and my target is channeling simultaneously.

Lua Code:

--
 
-- latency ------------------------------------------------------------------------------
 
    local function findCastLatency(self)
        local latency = self.latency
        local width = self:GetWidth()
        local _, _, _, ms = GetNetStats()
 
        if (ms~=0) then
            local safeZonePercent = (width/self.max) * (ms/1e5)
            if(safeZonePercent > 1) then
                safeZonePercent = 1
            end
            latency:SetWidth(width*safeZonePercent)
            latency:Show()
        else
            latency:Hide()
        end
    end
 
    local function cbLatency(self, event, ...)   
        local name, _, text, texture, startTime, endTime, castid, interrupt         
        local unit, spellName, _, id, spellId = ...
        local cb = self.latency     
        
        -- we don't want to look at any castbars but our own
        if (self.unit~="player") then return end
    
        if (event=="UNIT_SPELLCAST_START") then 
            if (cb) then
                name, _, text, texture, startTime, endTime, _, castid, interrupt = UnitCastingInfo(self.unit)
                endTime = endTime / 1e3
                startTime = startTime / 1e3
                local max = endTime - startTime
                self.max = max 
                cb:ClearAllPoints()
                cb:SetPoint("TOP")
                cb:SetPoint("BOTTOM")
                cb:SetPoint("RIGHT")
            end            
            findCastLatency(self)
        elseif (event=="UNIT_SPELLCAST_CHANNEL_START") then
            if (cb) then
                name, _, text, texture, startTime, endTime, _, castid, interrupt = UnitChannelInfo(self.unit)
                endTime = endTime / 1e3
                startTime = startTime / 1e3
                local max = endTime - startTime
                self.max = max 
                self.casting = nil
                self.castid = nil
                cb:ClearAllPoints()
                cb:SetPoint("TOP")
                cb:SetPoint("BOTTOM")
                cb:SetPoint("LEFT")
            end            
            findCastLatency(self)
        elseif ((event=="UNIT_SPELLCAST_STOP") or (event=="UNIT_SPELLCAST_CHANNEL_STOP") or  (event=="UNIT_SPELLCAST_FAILED") or (event=="UNIT_SPELLCAST_INTERRUPTED")) then
            if (not self.casting and not self.channeling) then
                cb:Hide()
                self.queuezone:Hide()
            end
        end
    end
      
    hooksecurefunc("CastingBarFrame_OnEvent", cbLatency)

line 77 is the UnitChannelInfo endTime. What's causing this?

Phanx · 08-10-14, 09:53 AM

Try adding some debug prints to see what's going on:

Code:

if not endTime then
    print(event, unit, name, text, startTime, endTime)
end

ObbleYeah · 08-10-14, 10:42 AM

w/ that script at the start of the function:

w/ that script in the UNIT_SPELLCAST_START event:

& in the UNIT_SPELLCAST_CHANNEL_START:

+ the last one also spat out this error

Code:

1x FrameXML\UnitFrame.lua:173: script ran too long
FrameXML\UnitFrame.lua:173: in function "UnitFramePortrait_Update"
FrameXML\UnitFrame.lua:163: in function "UnitFrame_Update"
FrameXML\TargetFrame.lua:117: in function "TargetFrame_Update"
FrameXML\TargetFrame.lua:159: in function "OnEvent"
FrameXML\UnitFrame.lua:674: in function <FrameXML\UnitFrame.lua:672>
<in C code>
<string>:"CAMERAORSELECTORMOVE":4: in function <string>:"CAMERAORSELECTORMOVE":1

So I assume it's the channeling event that's being influenced somewhere beforehand?

Duugu · 08-10-14, 12:26 PM

wowwiki states "Received for party/raid members as well as the player" for UNIT_SPELLCAST_CHANNEL_START. Assuming this is still correct the return value of UNIT="target" seems to be strange.

Is this a castbar for party/raid units? Or for a target frame?

Did you test that with a party member as a target?

Maybe UNIT_SPELLCAST_CHANNEL_START triggers for target but just returns nothing if target isn't a party member? Can't test this.

Phanx · 08-10-14, 12:34 PM

You need to put the print statement somewhere after the variables you're printing in it are assigned values. Otherwise, of course they're all going to be nil.

ObbleYeah · 08-10-14, 12:40 PM

ObbleYeah · 08-10-14, 12:50 PM

Originally Posted by Duugu

Is this a castbar for party/raid units? Or for a target frame?

Neither, it's for the player castbar - just adding a latency safe zone to the end of the default one.

I hadn't even realised party and raid units might be further muddying the waters, though I'd say the error is clearly based upon some cross-pollution of the player and target. It's an easily replicable error; just cast when the target is channeling. I will see what happens when i target a party member channeling a spell though.

edit: same result when targeting a party member w/o any other variation. Also getting no print returns at all when I put them in the right place, so i guess they're passing correctly?

SDPhantom · 08-10-14, 12:53 PM

UNIT_SPELLCAST_START and UNIT_SPELLCAST_CHANNEL_START aren't returning the values that are nil. Those are from UnitCastingInfo(). The code doesn't check if the event firing is for the player while it only runs for the player castbar. So it's asking UnitCastingInfo() to check the player when the target starts casting.

I would suggest replacing this line to be a little more robust:

Code:

if (self.unit~="player") then return end

-with-

Code:

if not UnitIsUnit(self.unit,"player") or not UnitIsUnit(unit,"player") then return; end

This will also proc on other bars if the unit happens to be pointing to the player (like target if you're targeting yourself).

Alternate:

Code:

if self.unit~="player" or not UnitIsUnit(self.unit,unit) then return; end

This will still restrict to the player castbar, but still checks if the event is firing for it.

ObbleYeah · 08-10-14, 01:07 PM

Thanks. Both versions give off the same error.

Code:

castbar.lua:48: Usage: UnitIsUnit("unit", "otherUnit")

which seems to only happen upon logging in/reloading the ui.

seems to have fixed the other issue though!

jeruku · 08-10-14, 01:43 PM

What about checking to see if the casting unit is the castbars unit?

Lua Code:

if unit ~= self.unit or unit ~= 'player' then return end

SDPhantom · 08-10-14, 01:47 PM

Originally Posted by ObbleYeah

Thanks. Both versions give off the same error.

Code:

castbar.lua:48: Usage: UnitIsUnit("unit", "otherUnit")

which seems to only happen upon logging in/reloading the ui.

seems to have fixed the other issue though!

I'm guessing it's unit that's throwing nil, we're already checking self.unit. Try either one of these depending on which you were using.

Code:

if not unit or not UnitIsUnit(self.unit,"player") or not UnitIsUnit(unit,"player") then return; end

Code:

if not unit or self.unit~="player" or not UnitIsUnit(self.unit,unit) then return; end

Originally Posted by jeruku

What about checking to see if the casting unit is the castbars unit?

Lua Code:

if (unit ~= self.unit) then return end

I try to include target if you happen to be targeting yourself. Same with including focus if you have focus on yourself.
With varying extents, this is what UnitIsUnit() is checking for.

ObbleYeah · 08-10-14, 01:52 PM

Yep, just came to the same realisation and fix too. Thanks for your help!

SDPhantom · 08-10-14, 02:04 PM

Originally Posted by ObbleYeah

Code:

if (not self.casting and not self.channeling) then

I'm also seeing a problem with this line. Unlike the other events, you're not checking if your latency bar cb exists before attempting to hide it.

ObbleYeah · 08-10-14, 02:16 PM

whoops, not sure why that's not included there already.

Phanx · 08-11-14, 02:23 AM

Originally Posted by SDPhantom

I try to include target if you happen to be targeting yourself. Same with including focus if you have focus on yourself. With varying extents, this is what UnitIsUnit() is checking for.

There's no reason to check UnitIsUnit here. If you're targeting yourself and cast a spell, then you'll get two events for the same spellcast -- one for the "player" unit, and one for the "target" unit. In this case, though, you only want to run your function once per spellcast (since you're not modifying the target castbar too) so you should just ignore the event for the "target" unit.

Code:

if unit ~= "player" or unit ~= self.unit then return end

jeruku · 08-11-14, 10:57 AM

Originally Posted by Phanx

There's no reason to check UnitIsUnit here. If you're targeting yourself and cast a spell, then you'll get two events for the same spellcast -- one for the "player" unit, and one for the "target" unit. In this case, though, you only want to run your function once per spellcast (since you're not modifying the target castbar too) so you should just ignore the event for the "target" unit.

Code:

if unit ~= "player" or unit ~= self.unit then return end

Had a brain fart as I was in a hurry to leave, that is what I was trying to point out. And yes, in my haste I used AND instead of OR.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode