Removing realm name

LiNK2088 · 07-14-15, 08:01 AM

I've got this addon which shows when a player in the raid uses an important cooldown, but I can't seem to manage to remove the realm from the users name.
Heres a part of the code:

Code:

local function spellUsed(spell, sourceGUID, targetGUID, sourceName, targetName, duration)

	local duration = duration or spell.len
	local descriptor = spell.id .. sourceGUID;

	local label;
	local soundfile;

	raidN = GetNumGroupMembers()
	local i = 0
	local isingroup = 0
	
	if (raidN == 0) then 
		member = getgroupUnitInfo(1)
	
		if member == sourceName then isingroup = 1; end
	else
		for i = 0,raidN do
			member = getgroupUnitInfo(i)
			if member == sourceName then isingroup = 1; end
			i = i + 1
		end
	end

	if isingroup == 0 then return; end
	
	if(spell.mt) then 
		label = spell.name .. " (" .. sourceName .. ")"
	else
		label = spell.name .. " (" .. sourceName .. " -> " .. targetName .. ")"
	end
end

After some googling I tried adding this to the code

Code:

	--sourceName = sourceName:match("^([^-]+)")
	--targetName = targetName:match("^([^-]+)")

It does remove the realm from the name, but it seems to completely hide the event when the user is from my realm.

Banknorris · 07-14-15, 10:16 AM

just change the label code

Code:

if(spell.mt) then 
		label = spell.name .. " (" .. sourceName:match("[^-]+") .. ")"
	else
		label = spell.name .. " (" .. sourceName:match("[^-]+").. " -> " .. targetName:match("[^-]+") .. ")"
	end

LiNK2088 · 07-14-15, 12:29 PM

Originally Posted by Banknorris

just change the label code

Code:

if(spell.mt) then 
		label = spell.name .. " (" .. sourceName:match("[^-]+") .. ")"
	else
		label = spell.name .. " (" .. sourceName:match("[^-]+").. " -> " .. targetName:match("[^-]+") .. ")"
	end

Works, ty

SDPhantom · 07-14-15, 02:13 PM

You should check the GUID to see if it's a player before parsing the name. There are a few NPCs that have hyphenated names and I've seen addons glitch when these are encountered.

Code:

if(spell.mt) then 
	label = spell.name .. " (" .. (sourceGUID:find("^Player") and sourceName:match("[^-]+") or sourceName) .. ")"
else
	label = spell.name .. " (" .. (sourceGUID:find("^Player") and sourceName:match("[^-]+") or sourceName) .. " -> " .. (targetGUID:find("^Player") and targetName:match("[^-]+") or targetName) .. ")"
end

Gethe · 07-15-15, 01:46 PM

You could also use Ambiguate:

Code:

if (spell.mt) then 
	label = spell.name .. " (" .. Ambiguate(sourceName, "short") .. ")"
else
	label = spell.name .. " (" .. Ambiguate(sourceName, "short") .. " -> " .. Ambiguate(targetName, "short") .. ")"
end

Not sure how this would work with NPC names though.

Lombra · 07-15-15, 03:44 PM

Originally Posted by Gethe

You could also use Ambiguate:

Code:

if (spell.mt) then 
	label = spell.name .. " (" .. Ambiguate(sourceName, "short") .. ")"
else
	label = spell.name .. " (" .. Ambiguate(sourceName, "short") .. " -> " .. Ambiguate(targetName, "short") .. ")"
end

Not sure how this would work with NPC names though.

Ambiguate is pretty smart; it should not remove NPC names. Didn't know about "short" option. Is that new?

Gethe · 07-15-15, 04:38 PM

Originally Posted by Lombra

Didn't know about "short" option. Is that new?

They might have added it in 6.0. The only place in Blizz's code where "short" is used is in the LFGList, which was added as part of the new Premade Group Finder

SDPhantom · 07-15-15, 05:18 PM

Originally Posted by Lombra

Ambiguate is pretty smart; it should not remove NPC names.

From the table of effects, I don't see it being that smart with the decision on whether or not to remove the realm name. I highly doubt it would do a lookup to match a name to GUID and see if it's a player. What's likely for it to do is split the name into character and realm, then for the various output types, compare the realm to your current one and the character to your guild roster.

You can probably test it running the following command and see what it prints out.

Code:

/dump Ambiguate("abcd-efgh","short")

This shouldn't match any characters or realms. If it returns only "abcd", then I wouldn't use this function.

Lombra · 07-15-15, 06:52 PM

It's smart from my experience so far, I should say. Using the "guild" option for example, it removes the realm as long as no one else with the same name on a different realm is in the guild.

I just tried short though, and it does just remove stupidly.