[Addon/Script]party name to class name

[r3FLeX]

Hey, if any of you here know how can I do sth like that:

I would be grateful

any kind of help appreciated

EDIT:
If this should be in AddOn Search/Requests, then sorry and if a moderator could move this topic there

[Phanx]

There's a lot going on in that screenshot, but based on the thread title, I'm going to guess you're talking about the compact (grid-like) raid/party frmes, and that you want to replace the player names with class names, in which case this should work:

hooksecurefunc("CompactUnitFrame_UpdateName", function(frame)
	frame.name:SetText(UnitClass(frame.unit))
end)

If you need help turning the above code into an addon, copy and paste it into this page:
http://addon.bool.no/

[r3FLeX]

Originally Posted by Phanx There's a lot going on in that screenshot, but based on the thread title, I'm going to guess you're talking about the compact (grid-like) raid/party frmes, and that you want to replace the player names with class names, in which case this should work: hooksecurefunc("CompactUnitFrame_UpdateName", function(frame) frame.name:SetText(UnitClass(frame.unit)) end) If you need help turning the above code into an addon, copy and paste it into this page: http://addon.bool.no/

Awesome, that's what I was looking for! Thanks.
Just if you could help me with few more things.
I'm using this script to change my display name, it also changes it if I target myself or focus.

-- name  change script
    local frame = CreateFrame("FRAME", "NameChangeScripts")
    frame:RegisterEvent("PLAYER_ENTERING_WORLD")
    local function eventHandler(self, event, ...)
 
-- EDIT THIS LINE BELOW TO CHANGE YOUR NAME
    NewName = "谷歌"
    PN = GetUnitName("player")
 
-- Change Player UnitFrame Name
    PFNC = CreateFrame("Frame", "PlayerFrameNameChange")
    local function ChangePlayerName(self)
    PlayerFrame.name:SetText(NewName)
    end
    PFNC:SetScript("OnUpdate", ChangePlayerName)
 
-- Change Target UnitFrame Name
    TFNC = CreateFrame("Frame", "TargetFrameNameChange")
    local function ChangeTargetName(self)
    local TN = GetUnitName("target")
    if PN == TN then
    TargetFrame.name:SetText(NewName)
    end
    end
    TFNC:SetScript("OnUpdate", ChangeTargetName)
 
-- Change Target's Target UnitFrame Name
    TFTNC = CreateFrame("Frame", "TargetFrameTargetNameChange")
    local function ChangeTargetofTargetName(self)
    local TTN = GetUnitName("targettarget")
    if PN == TTN then
    TargetFrameToT.name:SetText(NewName)
    end
    end
    TFTNC:SetScript("OnUpdate", ChangeTargetofTargetName)
 
-- Change Focus UnitFrame Name
    FFNC = CreateFrame("Frame", "FocusFrameNameChange")
    local function ChangeFocusName(self)
    local FN = GetUnitName("focus")
    if PN == FN then
    FocusFrame.name:SetText(NewName)
    end
    end
    FFNC:SetScript("OnUpdate", ChangeFocusName)
 
-- Change Focus' Target UnitFrame Name
    FFTNC = CreateFrame("Frame", "FocusFrameTargetNameChange")
    local function ChangeFocusTargetName(self)
    local FTN = GetUnitName("focustarget")
    if PN == FTN then
    FocusFrameToT.name:SetText(NewName)
    end
    end
    FFTNC:SetScript("OnUpdate", ChangeFocusTargetName)
 
    end
    frame:SetScript("OnEvent", eventHandler)

Could you edit that code above, that it will change also name on RaidFrames (Instead of Mage)?

One more, that code you posted; can you display names uppercased? And can you change names in standard party frames (not Raid-styled)?

Thanks again and sorry if you had to guess what I meant.

[Phanx]

That code is extremely horrible, with tons of leaked globals, duplicate frames and functions created over and over, etc. I can only assume you got it from the ArenaJunkies forums. No code from there is ever good.

Here is a revised version that doesn't create any unnecessary frames, doesn't leak globals, and doesn't make me want to club a whole pile of baby seals. It will work for both raid frames and normal unit frames (including party frames) and shows the class name in all-caps. For units that are not players (eg. pets) the text "PET" is shown, since those don't have real classes.

local CUSTOM_PLAYER_TEXT = "谷歌"
local CUSTOM_PET_TEXT = "PET"

local function SetCustomName(unit, fontString)
	if UnitIsUnit(unit, "player") then
		fontString:SetText(CUSTOM_PLAYER_TEXT)
	elseif UnitIsPlayer(unit) then
		fontString:SetText(strupper(UnitClass(unit)))
	else
		fontString:SetText(CUSTOM_PET_TEXT)
	end
end

hooksecurefunc("UnitFrame_Update", function(frame, isParty)
	if frame.name then
		SetCustomName(frame.overrideName or frame.unit, frame.name)
	end
end)

hooksecurefunc("CompactUnitFrame_UpdateName", function(frame)
	SetCustomName(frame.unit, frame.name)
end)

[r3FLeX]

Originally Posted by Phanx That code is extremely horrible, with tons of leaked globals, duplicate frames and functions created over and over, etc. I can only assume you got it from the ArenaJunkies forums. No code from there is ever good.

Yea, you're right. I'll get some lua books soon and start to learn it myself, but for now I 'm dependent on you

Originally Posted by Phanx Here is a revised version that doesn't create any unnecessary frames, doesn't leak globals, and doesn't make me want to club a whole pile of baby seals. It will work for both raid frames and normal unit frames (including party frames) and shows the class name in all-caps. For units that are not players (eg. pets) the text "PET" is shown, since those don't have real classes. local CUSTOM_PLAYER_TEXT = "谷歌" local CUSTOM_PET_TEXT = "PET" local function SetCustomName(unit, fontString) if UnitIsUnit(unit, "player") then fontString:SetText(CUSTOM_PLAYER_TEXT) elseif UnitIsPlayer(unit) then fontString:SetText(strupper(UnitClass(unit))) else fontString:SetText(CUSTOM_PET_TEXT) end end hooksecurefunc("UnitFrame_Update", function(frame, isParty) if frame.name then SetCustomName(frame.overrideName or frame.unit, frame.name) end end) hooksecurefunc("CompactUnitFrame_UpdateName", function(frame) SetCustomName(frame.unit, frame.name) end)

All great just if you could add that Friendly/Enemy NPC keep their original name instead of PET and also enemy players keep their original name instead of class. Also changing pets names isn't so important, so if that will help to do things I mentioned above you can remove it.

Big thanks man, stay awesome

EDIT:
Getting this errors while new players joining raid http://pastebin.com/r4m5BYBJ

[Phanx]

Now ignores NPCs and enemy players/pets, and won't error on partially-loaded units (eg. players in the process of joining your group). Let me know if you're actually seeing "UNKNOWN" on frames and, if so, under what circumstances.

local CUSTOM_PLAYER_TEXT = "谷歌"
local CUSTOM_PET_TEXT = "PET"

local function SetCustomName(unit, fontString)
	if UnitIsUnit(unit, "player") then
		fontString:SetText(CUSTOM_PLAYER_TEXT)
	elseif UnitIsPlayer(unit) then
		fontString:SetText(strupper(UnitClass(unit) or UNKNOWN))
	else
		fontString:SetText(CUSTOM_PET_TEXT)
	end
end

hooksecurefunc("UnitFrame_Update", function(frame, isParty)
	if frame.name then
		local unit = frame.overrideName or frame.unit
		if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then
			SetCustomName(unit, frame.name)
		end
	end
end)

hooksecurefunc("CompactUnitFrame_UpdateName", function(frame)
	SetCustomName(frame.unit, frame.name)
end)

Added/changed parts highlighted in green.

[Clamsoda]

I apologize if I am mistaken, but I believe UNKNOWN needs to be "UNKNOWN", else you'll get an error.

[Phanx]

No. UNKNOWN is a Blizzard global string, containing the appropriately translated version of the word "Unknown" for the user's current locale.

[Clamsoda]

Oh, I see. Thank you for the information!

[r3FLeX]

Originally Posted by Phanx Now ignores NPCs and enemy players/pets, and won't error on partially-loaded units (eg. players in the process of joining your group). Let me know if you're actually seeing "UNKNOWN" on frames and, if so, under what circumstances. local CUSTOM_PLAYER_TEXT = "谷歌" local CUSTOM_PET_TEXT = "PET" local function SetCustomName(unit, fontString) if UnitIsUnit(unit, "player") then fontString:SetText(CUSTOM_PLAYER_TEXT) elseif UnitIsPlayer(unit) then fontString:SetText(strupper(UnitClass(unit) or UNKNOWN)) else fontString:SetText(CUSTOM_PET_TEXT) end end hooksecurefunc("UnitFrame_Update", function(frame, isParty) if frame.name then local unit = frame.overrideName or frame.unit if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then SetCustomName(unit, frame.name) end end end) hooksecurefunc("CompactUnitFrame_UpdateName", function(frame) SetCustomName(frame.unit, frame.name) end) Added/changed parts highlighted in green.

Almost all works as it should be, just it doesn't change Name -> CLASS on Classic Party Frames BUT it changes in arena (after leaving arena it change back to Name).

[Phanx]

Add this at the end:

hooksecurefunc("UnitFrame_OnEvent", function(frame, event, unit)
	if frame.name and event == "UNIT_NAME_UPDATE" and unit == frame.unit then
		if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then
			SetCustomName(unit, frame.name)
		end
	end
end)

[r3FLeX]

Originally Posted by Phanx Add this at the end: hooksecurefunc("UnitFrame_OnEvent", function(frame, event, unit) if frame.name and event == "UNIT_NAME_UPDATE" and unit == frame.unit then if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then SetCustomName(unit, frame.name) end end end)

After adding this last part:
- name change to class after joining party on classic party frames
- after join arena match name isn't changing (ONLY on Classic Party Frames, on raid frames it's fine)
- after leaving match, name properly change to class

[Phanx]

Originally Posted by r3FLeX - name change to class after joining party on classic party frames

Yes, that's what it's supposed to do... I thought you wanted class names on classic party frames?

Originally Posted by r3FLeX - after join arena match name isn't changing (ONLY on Classic Party Frames, on raid frames it's fine) - after leaving match, name properly change to class

I'm not really sure how that can happen... the two functions being hooked are literally the only two unit frame functions that set any text to any (non-raid) frame's name fontstring, and no party-specific functions touch the fontstring.

Add these debug prints and let me know what they report when joining an arena match. It'll be spammy, so I'd advise creating another chat tab for real messages you can switch to once you're actually in the match.

local CUSTOM_PLAYER_TEXT = "谷歌"
local CUSTOM_PET_TEXT = "PET"

local function SetCustomName(unit, fontString)
	local text
	if UnitIsUnit(unit, "player") then
		text = CUSTOM_PLAYER_TEXT
	elseif UnitIsPlayer(unit) then
		text = strupper(UnitClass(unit) or UNKNOWN)
	else
		text = CUSTOM_PET_TEXT
	end
	print("SetCustomName", unit, text)
	fontString:SetText(text)
end

hooksecurefunc("CompactUnitFrame_UpdateName", function(frame)
	print("CompactUnitFrame_UpdateName", frame.unit)
	SetCustomName(frame.unit, frame.name)
end)

hooksecurefunc("UnitFrame_Update", function(frame, isParty)
	if frame.name then
		local unit = frame.overrideName or frame.unit
		print("UnitFrame_Update", unit, UnitPlayerControlled(unit), UnitIsFriend(unit, "player"))
		if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then
			SetCustomName(unit, frame.name)
		end
	end
end)

hooksecurefunc("UnitFrame_OnEvent", function(frame, event, unit)
	if frame.name and event == "UNIT_NAME_UPDATE" and unit == frame.unit then
		print("UnitFrame_OnEvent", unit, UnitPlayerControlled(unit), UnitIsFriend(unit, "player"))
		if UnitPlayerControlled(unit) and UnitIsFriend(unit, "player") then
			SetCustomName(unit, frame.name)
		end
	end
end)

Additions highlighted in green. Changes to existing lines in blue.

[r3FLeX]

Originally Posted by Phanx Yes, that's what it's supposed to do... I thought you wanted class names on classic party frames?

Yes, I wanted it like this. I wrote that to let you know that before entering arena it worked.
It was like: invite member (WORKING) -> enter arena (NOT WORKING) -> leaving arena (WORKING)

Originally Posted by Phanx I'm not really sure how that can happen... the two functions being hooked are literally the only two unit frame functions that set any text to any (non-raid) frame's name fontstring, and no party-specific functions touch the fontstring. Add these debug prints and let me know what they report when joining an arena match. It'll be spammy, so I'd advise creating another chat tab for real messages you can switch to once you're actually in the match.

I'm now confused too because last code you gave me after joining arena change classic party frames to raid frames.

result of debug

[Phanx]

I need the debug messages from when you join an arena match, not a regular party. I am not currently able to test anything related to arenas, so I can't do anything further without your (or someone else's) help.

Originally Posted by r3FLeX I'm now confused too because last code you gave me after joining arena change classic party frames to raid frames.

There is nothing in the code I posted that would cause the raid-style frames to be displayed instead of the classic raid frames. The only thing the code does is set the text of a font string. If you're seeing the frame style change, that's caused by some other addon you're running.