PetFrame Texture

[philipe24]

Hello again!
I've been trying to change the texture of my PetFrame but because the whole frame reloads every time you call it its not done this simple:

PetFrameTexture:SetTexture("xxxxx");

So what I've tried is to take a look at the PetFrame.lua from blizzard and copied the following code into my addon:

function PetFrame_Update (self, override)
    if ( (not PlayerFrame.animating) or (override) ) then
        if ( UnitIsVisible(self.unit) and PetUsesPetFrame() and not PlayerFrame.vehicleHidesPet ) then
            if ( self:IsShown() ) then
                UnitFrame_Update(self);
            else
                self:Show();
            end
            --self.flashState = 1;
            --self.flashTimer = PET_FLASH_ON_TIME;
            if ( UnitPowerMax(self.unit) == 0 ) then
                PetFrameTexture:SetTexture("xxxxxx");
                PetFrameManaBarText:Hide();
            else
                PetFrameTexture:SetTexture("xxxxxx");
            end
            PetAttackModeTexture:Hide();
 
            RefreshDebuffs(self, self.unit, nil, nil, true);
        else
            self:Hide();
        end
    end
end

It works but I get the following error sometimes and the ToT Frame vanishs.

240x [ADDON_ACTION_BLOCKED] AddOn "GhettoFrames" tried to call the protected function "TargetFrameToT:Show()".!BugGrabber-r198-release\BugGrabber.lua:552: in function FrameXML\TargetFrame.lua:924: in function "TargetofTarget_Update"FrameXML\TargetFrame.lua:109: in function "TargetFrame_Update"FrameXML\TargetFrame.lua:154: in function "OnEvent"FrameXML\UnitFrame.lua:673: in function :"TARGETNEARESTFRIEND":1: in function :"TARGETNEARESTFRIEND":1Locals:nil

Anyone who got an idea to fix this? thanks alot!greetings

[Lombra]

Replacing default functions in any way related to unit frames is gonna break stuff, as you've witnessed, but you can use a secure hook.

hooksecurefunc("PetFrame_Update", function(self, override)
	PetFrameTexture:SetTexture("xxxxxx")
end)

[zork]

You can set the hook directly on the SetTexture call if you want. Thus it will only fire on a SetTexture call.

hooksecurefunc(PetFrameTexture, "SetTexture", function(self, texture)
  local mytexture = "xxx"
  if texture ~= mytexture then
    print("reseting texture: "..texture)
    self:SetTexture(mytexture)
  end
end)

[Seerah]

I'm pretty sure that would cause an infinite loop.

[semlar]

Originally Posted by Seerah I'm pretty sure that would cause an infinite loop.

It'll only run if SetTexture is called with a texture path other than the one defined because of the if statement.

I think you can avoid that by making a local reference to PetFrameTexture.SetTexture outside the function and calling that instead of self:SetTexture in the hook.

For example, this shouldn't call the hooked function..

local PetFrameSetTexture = PetFrameTexture.SetTexture
hooksecurefunc(PetFrameTexture, 'SetTexture', function(self, texture)
    PetFrameSetTexture(self, 'mytexture')
end)

[Seerah]

Whoops - missed that.

And yeah, what semlar put is what I usually do in these cases.