Minimap Button Tooltip

[Sweetsour]

Hey guys,

Having issues with getting my tooltip for my addon's minimap button to appear. Here's the code I have right now:

MMBtn.Tip = CreateFrame("GameToolTip");
 
MMBtn:SetScript("OnEnter",function(self)
    MMBtn.Tip:SetOwner(self,"ANCHOR_CURSOR");
 
    MMBtn.Tip.LeftText = MMBtn.Tip:CreateFontString(nil, nil,nil);
    MMBtn.Tip.LeftText:SetPoint("TOP",0,-12);
    MMBtn.Tip.LeftText:SetFont("Fonts\\FRIZQT__.TTF", 11);
    MMBtn.Tip.LeftText:SetTextColor(1,1,1,1);
    MMBtn.Tip.LeftText:SetJustifyH("LEFT");
    MMBtn.Tip.LeftText:SetText("<AddOn Name >");
 
    MMBtn.Tip.RightText = MMBtn.Tip:CreateFontString(nil, nil,nil);
    MMBtn.Tip.RightText:SetPoint("TOP",0,-12);
    MMBtn.Tip.RightText:SetFont("Fonts\\FRIZQT__.TTF", 11);
    MMBtn.Tip.RightText:SetTextColor(1,1,1,1);
    MMBtn.Tip.RightText:SetJustifyH("LEFT");
    MMBtn.Tip.RightText:SetText("<AddOn Summary >");
 
    MMBtn.Tip:AddFontStrings(MMBtn.Tip.LeftText,MMBtn.Tip.RightText);
 
    MMBtn.Tip:Show()
end);
 
MMBtn:SetScript("OnLeave",function(self)
    MMBtn.Tip:Hide();
end);

Nothing appears when I hover over the minimap button. Any thoughts?

[Phanx]

#1 - I'd strongly recommend not creating your own minimap button from scratch. Instead, create a "launcher" object with LibDataBroker-1.1:

MyAddonLauncher = LibStub("LibDataBroker-1.1"):NewDataObject("MyAddonName", {
     type = "launcher",
     icon = "Interface\\AddOns\\MyAddon\\Icon",
     OnTooltipShow = function(tooltip)
          tooltip:SetText("<Addon Name>")
          tooltip:AddLine("<Addon Summary>", 1, 1, 1)
          tooltip:Show()
     end,
     OnClick = function(_, button)
         -- your OnClick stuff here
     end
end })

... and then use LibDBIcon-1.0 to create the minimap button for it:

LibStub("LibDBIcon-1.0"):Register("MyAddon", MyAddonLauncher, MyAddonLauncherDB)

This way, you don't have to do any work yourself to make it work with all minimap shapes (eg. square minimaps) and users can easily turn it off in favor of showing the icon on their DataBroker bar (eg. Bazooka, ChocolateBar, etc.) and you don't have to manage the tooltip yourself either.

#2 - If you really want to do it yourself, make sure you include an option to hide it (personally I would simply not use an addon that forcibly created a minimap button, especially one that did not work with my square minmap).

#3 - As for your actual problem, you have several. First, you're creating new font strings every time the tooltip is displayed, instead of creating them once and reusing them. Second, you are not using the GameTooltip (note the "t" in "tip" is not capitalized) correctly -- you don't place the font strings yourself, you just register them with the tooltip. Third, unless you have some specific need to manage your own tooltip, just inherit from the "GameTooltip" template (yes, it has the same name as the "GameTooltip" object type, and yes, it's a different thing) so it will automatically add any font strings that are needed to display the text you set to it:

MMBtn.Tip = CreateFrame("GameTooltip", "MMBtnTooltip", nil, "GameTooltip")
MMBtn:SetScript("OnEnter",function(self)
    MMBtn.Tip:SetOwner(self,"ANCHOR_CURSOR")
    MMBtn.Tip:AddDoubleLine("<AddOn Name >", "<AddOn Summary >")
    MMBtn.Tip:Show()
end)

...or, as seems more likely, if you want those on two separate lines, instead of on the left and right at the same level:

MMBtn.Tip = CreateFrame("GameTooltip", "MMBtnTooltip", nil, "GameTooltip")
MMBtn:SetScript("OnEnter",function(self)
    MMBtn.Tip:SetOwner(self,"ANCHOR_CURSOR")
    MMBtn.Tip:AddLine("<AddOn Name >")
    MMBtn.Tip:AddLine("<AddOn Summary >")
    MMBtn.Tip:Show()
end)

[Sweetsour]

Interesting, I'll definitely give the #1 approach a shot, thanks! I'll post back with the results [or questions]

[Sweetsour]

Wow, what a difference! Worked and worked well, thanks again! I'm definitely going to have to read up on libraries and such.

That having been said, is there anyway I can modify the minimap button texture/icon? It's too small and doesn't fit in the minimap button border correctly.

[Choonstertwo]

Originally Posted by Sweetsour Wow, what a difference! Worked and worked well, thanks again! I'm definitely going to have to read up on libraries and such. That having been said, is there anyway I can modify the minimap button texture/icon? It's too small and doesn't fit in the minimap button border correctly.

You'll need to show us the code that's creating the button and setting the texture.

[Sweetsour]

Originally Posted by Choonstertwo You'll need to show us the code that's creating the button and setting the texture.

Oh right, lol

WBiLauncher = WBi.ldb:NewDataObject(addonName, {
    type = "launcher",
    icon = "Interface\\Buttons\\UI-GroupLoot-Coin-Up",
    OnTooltipShow = function(tooltip)
        tooltip:SetText("WoW Bets")
        tooltip:Show()
    end,
    OnClick = function(_, button)
        if(addon.MainFrame:IsShown()) then
            addon.MainFrame:Hide();
        else
            addon.MainFrame:Show();
        end
    end
})

So I'm just not sure how to access or change the texture/icon with this block of code.

[Lombra]

I don't understand why LibDBIcon exists. There should just be a Broker display addon that uses minimap buttons instead.

[Phanx]

The problem with that texture is simply that the filled-in region doesn't cover the whole texture:
https://github.com/Gethe/wow-ui-text...ot-Coin-Up.PNG

I'd recommend finding some other gold texture and using that. Fortunately there are lots to choose from:
https://github.com/Gethe/wow-ui-text...sc_Coin_01.PNG
https://github.com/Gethe/wow-ui-text...sc_Coin_02.PNG
https://github.com/Gethe/wow-ui-text...sc_Coin_17.PNG

Or you can go on Wowhead and find an item/spell/whatever with an icon you like, and click on the icon; the name you get in a little popup replaces the "INV_Misc_Coin_17" part in the URLs above, all of which can be used in-game with "Interface\\Icons\\Name_of_the_Icon".

[Sweetsour]

Originally Posted by Phanx The problem with that texture is simply that the filled-in region doesn't cover the whole texture: https://github.com/Gethe/wow-ui-text...ot-Coin-Up.PNG I'd recommend finding some other gold texture and using that. Fortunately there are lots to choose from: https://github.com/Gethe/wow-ui-text...sc_Coin_01.PNG https://github.com/Gethe/wow-ui-text...sc_Coin_02.PNG https://github.com/Gethe/wow-ui-text...sc_Coin_17.PNG Or you can go on Wowhead and find an item/spell/whatever with an icon you like, and click on the icon; the name you get in a little popup replaces the "INV_Misc_Coin_17" part in the URLs above, all of which can be used in-game with "Interface\\Icons\\Name_of_the_Icon".

Perfect, just what I was looking for; thanks again! All done

[Seerah]

Why create a new tooltip object for your minimap button instead of just using the regular GameTooltip?

MMBtn.Tip:SetScript("OnEnter", function(self)
     GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
     GameTooltip:AddDoubleLine("<AddOn Name >", "<AddOn Summary >")
     GameTooltip:Show()
end)
 
MMBtn.Tip:SetScript("OnLeave", function() GameTooltip:Hide() end)

[Sweetsour]

Originally Posted by Seerah Why create a new tooltip object for your minimap button instead of just using the regular GameTooltip? MMBtn.Tip:SetScript("OnEnter", function(self)      GameTooltip:SetOwner(self, "ANCHOR_CURSOR")      GameTooltip:AddDoubleLine("<AddOn Name >", "<AddOn Summary >")      GameTooltip:Show() end)   MMBtn.Tip:SetScript("OnLeave", function() GameTooltip:Hide() end)

Very good to know, thanks for the tip!

[Phanx]

Originally Posted by Lombra I don't understand why LibDBIcon exists. There should just be a Broker display addon that uses minimap buttons instead.

There is -- Barrel, which I now maintain because it's useful when testing on PTRs and such where I don't want my full UI -- but someone somewhere couldn't let go of the "this addon comes with a minimap button" mentality and created an embeddable library for it. I agree that most addons should not embed/use LibDBIcon, but for large standalone addons -- especially ones that had a minimap button before DataBroker came along -- it's often expected that they'll have a minimap button (a really surprising number of people do not use a Broker display or even know that such a system exists) so it's not a problem as long as they provide an option to disable it.

For example, Grid embeds LibDBIcon, but my Broker_* addons do not, since it's expected that if you're installing a Broker plugin you have a Broker display, and many of my other addons will create a Broker object if LDB is available, but don't even embed LDB, let alone LDBIcon.

[Phanx]

Originally Posted by Sweetsour Very good to know, thanks for the tip!

If you're using the OnTooltipShow method with LibDataBroker you don't need to worry about which tooltip is being used at all; you just take the tooltip passed to your function and add stuff to it. It's probably the standard GameTooltip (named object, not object type) but it might not be.

[Sweetsour]

Originally Posted by Phanx If you're using the OnTooltipShow method with LibDataBroker you don't need to worry about which tooltip is being used at all; you just take the tooltip passed to your function and add stuff to it. It's probably the standard GameTooltip (named object, not object type) but it might not be.

Fair enough

Also, I noticed I was getting the following error if my addon was the only addon enable:

Message: ...<AddOn Name>\Libs\LibDataBroker-1.1\LibDataBroker-1.1.lua:2: LibDataBroker-1.1 requires LibStub

Any ideas on why this is happening?

TOC

## Interface: 60000
## Title: <AddOn Name>
## Notes: Allows two players to whisper bids to each other
## Author: Sweetsour
## Version: b1.1.6
## SavedVariables: WBi_SavedVar
 
Libs\LibDataBroker-1.1\LibDataBroker-1.1.lua
Libs\LibDBIcon-1.0\LibDBIcon-1.0\LibDBIcon-1.0.lua
 
WBi_Core.lua
WBi_Frames_Main.lua

First part of WBi_Core.lua

local WBi = {};
 
WBi.ldb = LibStub:GetLibrary("LibDataBroker-1.1");
WBi.ldbIcon = LibStub:GetLibrary("LibDBIcon-1.0");
 
local function initAddon() -- Called from "ADDON_LOADED" event
    WBiLauncher = WBi.ldb:NewDataObject(name, {
        type = "launcher",
        icon = "Interface\\ICONS\\INV_Misc_Coin_01",
        OnTooltipShow = function(tooltip)
            tooltip:SetText("<Addon Name>")
            tooltip:Show()
        end,
        OnClick = function(_, button)
            if(addon.MainFrame:IsShown()) then
                addon.MainFrame:Hide();
            else
                addon.MainFrame:Show();
            end
        end
    })
 
    WBi.ldbIcon:Register(name, WBiLauncher, WBiLauncherDB)
end

[Seerah]

Originally Posted by Sweetsour LibDataBroker-1.1 requires LibStub ........ Libs\LibDataBroker-1.1\LibDataBroker-1.1.lua Libs\LibDBIcon-1.0\LibDBIcon-1.0\LibDBIcon-1.0.lua WBi_Core.lua WBi_Frames_Main.lua

Do you see LibStub listed in your TOC?

[sticklord]

You also need to add the library Libstub

[Sweetsour]

Originally Posted by Seerah Do you see LibStub listed in your TOC?

Heyyy, derp! Haha, thanks! :P

[Phanx]

Most libraries use LibStub to handle versioning -- this way, if the user has 10 addons installed that all include a copy of the same library, once the loading process finishes, there's only one copy of the newest version of the library loaded, and all 10 addons are using it.

LibDataBroker also uses the CallbackHandler-1.0 library, which is commonly used to handle "callbacks", which are bascially custom events. The game can fire a "UNIT_HEALTH" update to notify addons that someone's health changed, but addons can't fire real events, so they have to create their own notification system, and it's just easiest to use one that already exists instead of everyone reinventing the wheel for their own project.

[Sweetsour]

Makes sense!

[Sweetsour]

Hello again!

Referencing this code block of code again;

MyAddonLauncher = LibStub("LibDataBroker-1.1"):NewDataObject("MyAddonName", {
     type = "launcher",
     icon = "Interface\\AddOns\\MyAddon\\Icon",
     OnTooltipShow = function(tooltip)
          tooltip:SetText("<Addon Name>")
          tooltip:AddLine("<Addon Summary>", 1, 1, 1)
          tooltip:Show()
     end,
     OnClick = function(_, button)
         -- your OnClick stuff here
     end
end })

Is there a way I can access the element (the minimap button) to have the ability to set its point using :SetPoint() (outside of this code)?