WoWInterface - Not sure how to add code to this table. Help?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Not sure how to add code to this table. Help? (https://www.wowinterface.com/forums/showthread.php?t=52895)

Not sure how to add code to this table. Help?

Trying to add this

Lua Code:

PlayerName:SetTextColor(1,.92,0)
TargetFrameTextureFrameName:SetTextColor(1,.92,0)
FocusFrameTextureFrameName:SetTextColor(1,.92,0)
TargetFrameToTTextureFrameName:SetTextColor(1,.92,0)
FocusFrameToTTextureFrameName:SetTextColor(1,.92,0)
TargetFrameTextureFrameName:SetWidth(117)
FocusFrameTextureFrameName:SetWidth(117)
TargetFrameToTTextureFrameName:SetWidth(66)
FocusFrameToTTextureFrameName:SetWidth(66)

to this:

Lua Code:

local fontStrings = {
PlayerName,
TargetFrameTextureFrameName,
TargetFrameTextureFrameDeadText,
FocusFrameTextureFrameName,
FocusFrameTextureFrameDeadText
}
 
for _, v in pairs(fontStrings) do
    v:SetFont("Fonts\\FRIZQT__.TTF", 10, "OUTLINE")
    v:SetShadowOffset(0, 0)
end

And can't figure it out. Could anybody help?

Also, could someone tell me if these few lines are tainting my UI?

Lua Code:

PetActionBarFrame:ClearAllPoints()
PetActionBarFrame:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", 322, 112)
PetActionBarFrame:SetScale(.87)
 
LossOfControlFrame:SetScale(.93)
SpellActivationOverlayFrame:SetScale(.94)
 
PlayerHitIndicator:SetText(nil)
PlayerHitIndicator.SetText = function() end
 
PetHitIndicator:SetText(nil)
PetHitIndicator.SetText = function() end
 
hooksecurefunc(PlayerFrameGroupIndicator,"Show",function(self) self:Hide() end)
 
PetName:Hide()

1) I'm guessing you're looking for something like this:

Lua Code:

local fontStrings = {
    PlayerName,
 
    TargetFrameTextureFrameName,
    TargetFrameTextureFrameDeadText,
    TargetFrameToTTextureFrameName,
 
    FocusFrameTextureFrameName,
    FocusFrameTextureFrameDeadText,
    FocusFrameToTTextureFrameName
}
 
for _, v in pairs(fontStrings) do
    v:SetFont("Fonts\\FRIZQT__.TTF", 10, "OUTLINE")
    v:SetShadowOffset(0, 0)
    v:SetTextColor(1,.92,0)
end
 
TargetFrameTextureFrameName:SetWidth(117)
TargetFrameToTTextureFrameName:SetWidth(66)
 
FocusFrameTextureFrameName:SetWidth(117)
FocusFrameToTTextureFrameName:SetWidth(66)

2) Lines 9 and 12 are the only points where you are tainting functions. However, many calls exist in the code that are protected from being used in combat if the affected frames are protected frames.

Lines 9 and 12 shouldn't actually cause a problem since they're overriding methods on font strings, which are not and cannot be secure objects.

You probably don't need to use a secure hook on PlayerFrameGroupIndicator either -- just do this:

Code:

PlayerFrameGroupIndicator.Show = PlayerFrameGroupIndicator.Hide

However, the best way to determine if you're breaking something through taint is just to try it and see what happens. If you don't get any errors about actions being blocked, you're probably fine.

Quote:

Originally Posted by Phanx (Post 311918)

Lines 9 and 12 shouldn't actually cause a problem since they're overriding methods on font strings...

If secure code were to call the method, it would still taint the execution path. To directly answer the OP's question, yes, it does cause taint. If the question was if this specific taint would interfere with specific secure code calling a protected function under certain conditions, I don't know.

Quote:

Originally Posted by Phanx (Post 311918)

...which are not and cannot be secure objects.

My comment on protected frames where more focused on moving and setting the scale of PetActionBarFrame.