WoWInterface - What is wrong with this code?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - What is wrong with this code? (https://www.wowinterface.com/forums/showthread.php?t=50604)

What is wrong with this code?

I'm keeping this as simple as I can. This code is just a little counter that uses a right mouse button click to open a window that has a counter in it. The code works it just doesn't save the count. So my question is what is wrong with this code?

Lua Code:

-- First I will start with my saved variable table.
 
local ZCountSave = {
    ["Count"] = {
        ["ClickedCount"] = 0,
    }
}
 
-- Next I will create my button to pull up the counter.
 
ZCountButton = CreateFrame("Button","ZCountButton",UIParent,"UIPanelButtonTemplate")
    ZCountButton:SetPoint("CENTER",0,0)
    ZCountButton:SetWidth(30)
    ZCountButton:SetHeight(30)
    ZCountButton:SetText("ZC")
    ZCountButton:SetMovable(true)
    ZCountButton:RegisterForDrag("LeftButton")
    ZCountButton:SetScript("OnDragStart",ZCountButton.StartMoving)
    ZCountButton:SetScript("OnDragStop",ZCountButton.StopMovingOrSizing)
 
-- Now I'm going to create my frame that will have my counter inside of it.
 
ZCountBoxFrame = CreateFrame("Frame")
    ZCountBoxFrame:SetPoint("CENTER", 0, 0)
    ZCountBoxFrame:SetBackdrop(StaticPopup1:GetBackdrop())
    ZCountBoxFrame:SetHeight(300)
    ZCountBoxFrame:SetWidth(300)
    ZCountBoxFrame:Hide(true)
    ZCountBoxFrame:SetMovable(true)
    ZCountBoxFrame:EnableMouse(true)
    ZCountBoxFrame:RegisterForDrag("LeftButton")
    ZCountBoxFrame:SetScript("OnDragStart",ZCountBoxFrame.StartMoving)
    ZCountBoxFrame:SetScript("OnDragStop",ZCountBoxFrame.StopMovingOrSizing)
 
 
-- Next we need to create a function that can open our ZCountBoxFrame.
 
ZCountButton:RegisterForClicks("AnyUp")
ZCountButton:SetScript("OnClick", function(self, button, ...)
    if (button == "RightButton") then
        if ZCountBoxFrame:IsShown() then
            ZCountBoxFrame:Hide()
        else
            ZCountBoxFrame:Show()
        end
    end
end)
 
-- Now let's make the counter which will be inside our ZCountBoxFrame
 
ZCounterButton = CreateFrame("Button","ZCounterButton",ZCountBoxFrame,"UIPanelButtonTemplate")
    ZCounterButton:SetPoint("CENTER",0,0)
    ZCounterButton:SetWidth(80)
    ZCounterButton:SetHeight(30)
    ZCounterButton:SetText("Count: ")
    
-- Now that we have our Counter Button we need to create a function that will count a number up, down, and back to zero.
    
ZCounterButton:RegisterForClicks("AnyUp")
ZCounterButton:SetScript("OnClick", function(self, button, ...)
    if (button == "LeftButton") then
        ZCountSave.Count.ClickedCount = ZCountSave.Count.ClickedCount + 1
        ZCounterButton:SetText("Count: "..ZCountSave.Count.ClickedCount)
    end
end)
 
-- Now to put in the Addon Loaded so it can save some things for us.
 
local ZLoFrame=CreateFrame("Frame")
ZLoFrame:RegisterEvent("ADDON_LOADED")
ZLoFrame:SetScript("OnEvent",function(self,event,...)
    if event=="ADDON_LOADED" and (...)==ZCount then
        
        if ZCountSave.Count.ClickedCount ~= 0 then
            ZCounterButton:SetText("Completed: "..ZCountSave.Count.ClickedCount)
        end
        
        self:UnregisterEvent("ADDON_LOADED")
    end
end)

The saved variable is a global. If you define a local with the same name, it won't access it.

Put the word local in front of lines 11 and 23, and remove the word local from line 3, if that is your saved variable.

Lua Code:

local ZCountSave = {
    ["Count"] = {
        ["ClickedCount"] = 0,
    }
}

Everytime your addon loads this table would be used if it were global and not local. And when your saved variable is loaded which is nil by default it would delete it.
When your main code runs your sv is not yet available. So you want to delay its use after an event that makes sure it is loaded. Typical is ADDON_LOADED (not sure if your implementation works ... as I dont see ZCount defined).

And in repsonse to the event you'd use a construct like

Lua Code:

local default = {
    ["Count"] = {
        ["ClickedCount"] = 0,
    }
ZCountSave = ZCountSave or default

This would make sure your sv is used when available.

Edit:

A quick read should bring more light to this topic
http://wowpedia.org/AddOn_loading_process
http://wowpedia.org/Saving_variables..._game_sessions

A good choice to make sure your data is stored
http://www.wowace.com/addons/ace3/pages/api/ace-db-3-0/

Quote:

Originally Posted by Rilgamon (Post 301300)

Lua Code:

local default = {
    ["Count"] = {
        ["ClickedCount"] = 0,
    }
ZCountSave = ZCountSave or default

In the last line, it's unnecessary to check ZCountSave and fall through to default. At that point in the Lua code, ZCountSave will always be nil.

Quote:

And in repsonse to the event you'd use a construct like

You missed the line before the code ;)

Wonder how I skipped over that. :rolleyes: