Addon to expedite finished missions
Hi,
I'm loving WoD and the whole Followers/Missions thingy but... Whenever I log in i've got at least x4 toons who all have about 6 or more completed missions that have to be finalised. At first I thought the whole animation of the followers going jumpy jumpy and punching the air was kinda cute but now it's just time consuming. Is there an addon that could once I open the mission table, with just one click, it will just complete everything without having to do it for each and every follower? I'm not even slightly interested if the missions failed or not cause I often send followers on missions with a low seccess rate just to earn the base XP. Thanx in advance. |
I've been trying to make this happen myself. The code I wrote kind of works, but not 100%. I've been running into situations where missions would ignore the request to be marked as turned in and would require multiple passes to complete.
|
Quote:
Same problems with follower list updates, C_Garrison.GetFollowers() isn't always up to date... |
There is an addon called Breeze to speed it up very much:
http://www.curse.com/addons/wow/breeze |
For now, I got the OnFinished handlers on the animations to trigger the next logical step. This makes it play more like a movie without the need for interaction. I might end up hiding the next button and seeing how it turns out visually.
|
Well Tonyleila, I have to say that the Breeze addon sure lives up to its name. It's made things a lot faster and far less boring.
In that strange Utopia that resides somewhere within my WoW psyche, I'll still dream of just one clicking the "View Completed Missions" button and having them all auto-complete but until then, this will do nicely. I never acquired the skill to write addons so I appreciate the work and effort everyone puts into the addon community. Now, I gotta run. I'm on a mission(s)! |
Quote:
Also couldn't find a way to tell if a mission failed or was successful, so I don't output rewards. http://youtu.be/FdMo8hdc4rY Too much issues for a release ;) |
I ended up going with a two way approach. When GARRISON_MISSION_NPC_OPENED fires, I run a scanner that reruns itself every half second until there are no completed quests. I also have GARRISON_MISSION_FINISHED directly call C_Garrison.MarkMissionComplete() using the passed mission id and trigger a delayed scan to make sure everything was caught. I handle looting with GARRISON_MISSION_COMPLETE_RESPONSE checking C_Garrison.CanOpenMissionChest() and running C_Garrison.MissionBonusRoll() if true.
Note: GARRISON_MISSION_COMPLETE_RESPONSE should fire in response to C_Garrison.MarkMissionComplete() with info on whether the mission succeeded or not. It isn't reliable right now as it only seems to fire on successful missions. |
Here's what I use, seems to work fine for me atleast:
Lua Code:
|
Strange, that's the approach I tried the first time, but it didn't work out for me. I get the feeling this mechanic has more events firing that they aren't exposing to Lua side. Anyway, this is the code I have. It's really robust in which I like to have anything I can think of covered.
This also allows any addon wanting to poll GarrisonMissionFrame.MissionComplete.completeMissions get updated info. Note: nop() is a global dummy function in UIParent.lua Lua Code:
|
I'm using this:
Code:
local frame = CreateFrame('Frame') |
Quote:
Also, unregistering GARRISON_MISSION_FINISHED from GarrisonMissionFrame isn't enough to stop the complete mission dialog from showing. It also triggers the check function from the OnShow handler. I handled this by overriding GarrisonMissionFrame_CheckCompleteMissions with a dummy no-op function. |
Quote:
Quote:
|
Quote:
(Also, personally, when I use the same method, I put the :Hide() line right before the :SetScript line to avoid that particular confusion.) |
I wasn't able to follow that the OnUpdate handler was being controlled in that way. It's not an approach I would've expected.
|
1 Attachment(s)
Quote:
this is currently what i am now using and ty vrul for the materials... i made an addon using the most basic things (as this is not really my gig and am horrible making addons) but there is only one problem i feel with your lua. while i wanted the animations of both the followers completing and the chest to stop having a wait time, that is as far as i want the addon to go. i didnt want it to stop telling what i received from completing or the bonuses of currency/xp/etc. is there something you can tell me (perhaps reposting an edited code) that would have this effect? i really want it for its functions before i click the chest. all else i want it to do is behave normally so that i can see the bonuses being awarded and whatnot. thanks ahead of time. P.S. if you do this and package it as a zip a LOT of ppl are going to want this instead of many of the other addons that have so many bugs. this one hasnt screwed in any bugs yet. will post if that changes or if the edited post has bugs) KEEP THIS IDEA ALIVE PLZ! |
Quote:
|
Not sure if you guys have seen Master Plan. It has a single screen that shows the results of all missions and then their rewards.
http://www.curse.com/addons/wow/master-plan |
Quote:
that said there are reasons for the suggestions i made. 1. yes there are bugs in many addons concerning the garrison because garrison stuff is still relatively new. 2. oddly enough i dont get any bugs from this particular creation of awesome that vrul has made. 3. i honestly dont want to "change" the way garrison looks or behaves except for the speed of which things are finalized. thus i dont even want the addons you suggested even if not for the bugs 4. the only change i suggested was to make it so i didnt have to watch that lame "everybody-jump-in-the-air-like-you-just-dont-care-that-you-are-wasting-my-play-time" animation. also the chest makes me wait too. and neither of these things did i want to wait on. his script allows it to go faster. thats a plus! but i would much prefer to still see the bonus rewards on the garrison ui and THEN i can click the next button as i see fit. i really dont see the problem with this request and also do not know what your deal was/is... i felt salt from your response. edit to 2. oddly enough i dont get any bugs from this particular creation of awesome that vrul has made. --apparently if you receive any lag spike you could have it needing to run more than once by closing the garrison mission, then at the table reopen them to start fresh. there is an unrelated addon called postal and its meant for opening mail no matter how much you have with a single click. taking a note from that, i am thinking that if you add a hardware action (button) to refresh it this would be remedied. simply put, i think blizz is just not letting it fire off that fast without some form of hardware function. otherwise still extremely useful and once again thank you |
Quote:
As for "suggestions" keep in mind that most authors write addons primarily for themselves to use, and while most are generally open to ideas, no sane addon author (or author of any kind of software) will implement every single feature that's "suggested" by users. If I did that, I'd currently have 50 addons that all did the same 10000000 things, instead of 50 addons that all do distinctly different things. |
All times are GMT -6. The time now is 11:34 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI