| Updated: | 06-15-08 04:11 PM |
| Created: | unknown |
| Downloads: | 1,523 |
| Favorites: | 11 |
| MD5: |
![]() |
Comment Options |
|
|
|
|
A Kobold Labourer
Forum posts: 0
File comments: 2
Uploads: 0
|
Will this be updated for WotLK as there are now up to eight charges on the ES?
|
|
|
|
|
|
|
A Kobold Labourer
Forum posts: 1
File comments: 7
Uploads: 0
|
This is a perfect example for a perfect addon.
|
|
|
|
|
|
|
A Murloc Raider
Forum posts: 5
File comments: 143
Uploads: 0
|
Saved Variables
Thanks for the reply
I still think Saved Variables would be nice to have, otherwise you have to muck around with changing settings again every time you update. |
|
|
|
|
||
|
Re: Re: Re: Saved Variables
I currently have no need for adding options for those things cause i am happy with the things i setup in the lua.
Though I understand that people would like to have that. The thing with the dragging isnt that easy because in the same moment where you are able to drag you need also saved vars for reminding the position. So overhead for me... Thanks for your comments and maybe sometime there will be options ![]()
|
||
|
|
|
|
|||
It's much cleaner and faster to simply add an additional local variable to store the timestamp that's already passed as the first argument to the COMBAT_LOG_EVENT_UNFILTERED event. As the timestamps are only compared when you see the specific "aura removed" message you're already looking for, there's very little CPU overhead. ![]() |
|||
|
|
|
|
||
|
A Defias Bandit
Forum posts: 1
File comments: 47
Uploads: 1
|
Re: Re: Re: Saved Variables
![]() |
|
|
|
|
|
||
|
A Murloc Raider
Forum posts: 5
File comments: 143
Uploads: 0
|
Re: Re: Saved Variables
I am happy with the addon as is. Though I would like to be able to drag the frame rather than having to edit lua, reload, edit lua, reload...I don't think making the frame draggable would cause unnecessary bloat. Really, a draggable frame and saving settings to SV is all I would like to see added right now. I'm just happy to have found a much simpler addon than ShamanFriend (did way more than I needed) that tracks both shields. |
|
|
|
|
|
||
|
A Defias Bandit
Forum posts: 1
File comments: 47
Uploads: 1
|
Re: Saved Variables
changing font is easy enoughl by simply editing core.lua and same goes for moving the text. |
|
|
|
|
|
|
|
A Murloc Raider
Forum posts: 5
File comments: 143
Uploads: 0
|
Saved Variables
Great addon Infineon! Something I would like to see, but can live without, is writing the settings to a saved variables file. Would help keep settings from getting overwritten every time I update via an updater.
And I know you are trying to keep this addon simple, but if you ever do make a small gui for it, hooking into SharedMedia would work really well for fonts, sounds, etc. Also, why not make the frame draggable by ctrl-left dragging or something similar? Thanks again!
Last edited by joshwill80 : 05-23-08 at 12:37 PM.
|
|
|
|
|
|
|
So unit_died is working and added in version 0006...
Thanks for telling me that its working since 2.4.2 i forgot it ![]() |
|
|
|
|
|
|
|
So i will also check the Unit_Died thing and if its working i will add the resest of the counters.
The current problem with the not wanted reset of the counter is not that problematic on watershield cause this really costs 0 mana. I don't care recasting it. The problem gets interesting on earthshield cause it is costing mana and a recast is not the thing i want to fix my timer. Your solution of setting a timeout would be a fix, but also isn't that nice. There are 2 ways in my mind that could solve things: 1. Recode counting Currently counting of es and ws is working with the listening to the SPELL_ENERGIZE and SPELL_HEAL events. If i would recode this to again work with the old "UNIT_AURA" event so that the Buff is checked while active on the target i would always have an accurate counter and the reset problems should be blown away. Problem here would be that this only works on: player,target,focus,party,raid 2. Try to fix with current combatlog mechanic Phanx i would like to work with your ideas and improve this addon to work better. |
|
|
|
|
|
||
|
A Defias Bandit
Forum posts: 1
File comments: 47
Uploads: 1
|
|
|
|
|
|
|
|
|
Well, I've modified my local copy to fix the extremely annoying bug where the addon thinks Water Shield is cancelled when I recast it before it expires. I tend to refresh my Water Shield before entering combat, regardless of how much time or how many charges are left, and the combat log likes to screw up the message order.
The solution I'm using is to record the time on the "gained" message, and when the "lost" message is seen, I check the time; if it's been less than 0.25 seconds since I gained Water Shield, I assume that the combat log is wrong, and don't cancel the tracked Water Shield. PvPers who use Water Shield in arenas may occasionally see it dispelled off within 0.25 seconds of casting it, but for PvE this number is fine and gives a safety margin to account for latency or plain old combat log bugginess. You're welcome to adapt this solution for the official version. ![]() Edit: UNIT_DIED is (according to Slouken) fixed in 2.4.2. I'll try to verify this tonight.
Last edited by Phanx : 05-22-08 at 04:54 PM.
|
|
|
|
![]() |