Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(30 Kb)
Download
Updated: 10-20-14 02:27 AM
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Siege of Orgrimmar (5.4)
Escalation (5.3)
Thunder Isle (5.2)
Updated:10-20-14 02:27 AM
Created:04-22-13 06:29 PM
Downloads:1,299
Favorites:49
MD5:
6.0.2
GoFish  Updated less than 3 days ago!
Version: 6.0.2.46
by: Phanx [More]
GoFish lets you double-right-click to fish, and enhances sound effects while fishing.
Fishing mode is automatically enabled when you mouse over a fishing pool, while you have a fishing pole equipped, or can be toggled using a keybind or slash command. Fishing mode is disabled if you enter combat or unequip a fishing pole, or after 10 seconds of no fishing activity if it was enabled via mouseover.

While in fishing mode, double-right-clicking anywhere on the game world casts Fishing, auto-loot is enabled, auto-interact is disabled, the sound effect volume is raised, and other volumes are lowered. When exiting fishing mode, your normal settings are restored.

GoFish does not support lures or other skill-enhancing items, as these are not neccessary or especially useful in Mists of Pandaria.

To toggle fishing mode manually, type "/gofish" or bind a key. To change options, type "/gofish options" or browse to the GoFish panel in the standard Interface Options window.
Feedback
Post a comment. If you are reporting a bug, please include detailed instructions I can follow to reproduce the bug myself, whether or not it still happens when all other addons are disabled, and the exact text of the first related error message (if any) from Bugger.
Language Support
Compatible with all locales. Translated into English, Deutsch, Español, Français, Italiano, Português, Русский, 한국어, 简体中文, and 繁體中文. Languages in italic are missing some translations.

To add or update translations for any language, enter them on CurseForge and then post a comment or send me a PM on either site to let me know you made changes. If you do not comment or PM me, your translations will not be included in the addon until I happen to notice them on my own, which may take months or even years since CurseForge doesn't notify me, so please don't forget that part!
Credits
GoFish was inspired by Ammo's FishermansFriend. The click-casting code borrows heavily from Torhal's Archy. Fish school name translations were copied from Kagaro's GatherMate2.
Version 6.0.2.46
  • Fixed disabling auto-loot after fishing if it was off beforehand (why!?)

Version 6.0.2.45
  • Updated for WoW 6.0
  • Fixed reversed on/off messages in some languages

Version 5.4.8.31
  • Fishing mode will no longer activate on mouseover while channeling Far Sight, Eye of Kilrogg, or similar effects
  • Fixed an error for users whose game clients fail at retrieving and/or caching item info

Version 5.4.1.27
  • Fixed a possible error at startup if the mouse happened to be over a fish pool
  • Updated German translations from ckaotik on CurseForge
  • Updated for WoW 5.4

Version 5.3.0.22
  • Fixed deDE/zhTW localization conflict

Version 5.3.0.21
  • Updated for WoW 5.3
  • Fixed disabling option to enhance sounds
  • Added remaining "fish of the day" special pools
  • Added zhTW translations from BNSSNB

Version 5.2.0.18
  • Added Mysterious Whirlpool and Swarm of Panicked Paddlefish
  • Fishing mode will no longer be activated on mouseover while you are in a vehicle
  • The options for activating on mouseover/equip will now be correctly checked on the first viewing

Version 5.2.0.14
  • Added options for auto-activation and fishing sound levels
  • Added Mixed Ocean School and Brew Frenzied Emperor Salmon
  • Fishing mode will now be re-enabled automatically if your fishing pole is still equipped when you leave combat

Version 5.2.0.10-beta
  • Fixed auto-loot toggling
  • Added Crane Yolk Pool (seen during an Anglers daily quest)
  • Added fish pool translations for all languages (some are incomplete)
  • Reduced maximum double-click detection time from 0.4 seconds to 0.25 seconds

Version 5.2.0.6-beta
  • First public release
Archived Files (9)
File Name
Version
Size
Author
Date
6.0.2.45
30kB
Phanx
10-16-14 07:00 AM
5.4.8.31
30kB
Phanx
06-01-14 10:05 PM
5.4.1.27
30kB
Phanx
11-30-13 12:05 PM
5.3.0.22
29kB
Phanx
07-17-13 03:06 AM
5.3.0.21
29kB
Phanx
07-08-13 07:41 PM
5.2.0.18
29kB
Phanx
05-18-13 04:51 PM
5.2.0.14
29kB
Phanx
05-04-13 05:16 PM
5.2.0.10-beta
23kB
Phanx
04-25-13 10:08 PM
5.2.0.6-beta
9kB
Phanx
04-22-13 06:29 PM


Post A Reply Comment Options
Unread Yesterday, 02:32 AM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 6.0.2.46
  • Fixed disabling auto-loot after fishing if it was off beforehand (why!?)

I couldn't actually reproduce the problem, but it was storing and setting the value as a boolean (true/false) instead of a flag (1/0) so I fixed that just in case. If you're still seeing auto-loot turning off after fishing, and you're sure it was on before fishing, please try disabling all your other addons and reproducing the problem. You can quickly check the state of the auto-loot setting at any time using this command:

/dump GetCVar("autoLootDefault")

It'll write "1" in your chat frame if it's on, or "0" if it's off. Run it before activating fishing mode, while fishing mode is active, and after deactivating fishing mode. It should say the same thing before and after depending on your setting, and "1" during fishing.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread Yesterday, 09:12 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Oh is that what's doing that... interesting. I'll have to see why the game isn't accurately indicating whether auto-loot is enabled. It should check the state when you start fishing, and only turn it off afterwards if it was off to begin with.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 10-18-14, 11:33 AM  
uncomplimentary
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
auto loot

auto loot is being toggled off on deactivation, it appears
uncomplimentary is offline Report comment to moderator  
Reply With Quote
Unread 10-16-14, 07:02 AM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 6.0.2.45
  • Updated for WoW 6.0
  • Fixed reversed on/off messages in some languages
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 06-01-14, 10:05 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 5.4.8.31
  • Fishing mode will no longer activate on mouseover while channeling Far Sight, Eye of Kilrogg, or similar effects
  • Fixed an error for users whose game clients fail at retrieving and/or caching item info
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 03-07-14, 05:10 PM  
Ethan Centaurai
A Flamescale Wyrmkin
 
Ethan Centaurai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 138
File comments: 139
Uploads: 14
Originally Posted by Phanx
Why are you deleting your cache so much?
To be honest, I'm not the one doing the deleting.

I think it's either a file permissions issue or the Battle.net App clears it after I log out of WoW (or both, or one thing causes the other, I don't know). I'm pretty sure the cache gets deleted or modified as SilverDragon pops up "NPC found in cache" alerts even though I don't delete it.
__________________

Twitter | Blog
Ethan Centaurai is offline Report comment to moderator  
Reply With Quote
Unread 03-05-14, 05:11 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Well, I can factor out the IsEquippedItemType call to a function that first attempts to update the value of the FISHING_POLE constant if it's not set... that will prevent the error from occurring, but the "activate on equip" feature will still fail when your client fails to retreive the item data in a timely fashion.

Why are you deleting your cache so much?
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 03-03-14, 04:54 PM  
Ethan Centaurai
A Flamescale Wyrmkin
 
Ethan Centaurai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 138
File comments: 139
Uploads: 14
Using /dump GetItemInfo(6256) returns everything you'd want to know about the Fishing Pole. It hasn't yet returned "empty result" during my playtime sessions.

One thing I have noticed is that the error occurs on line 342 (currently at 30x this session) as well as 374 (111x), and that errors sometimes occur when looting or mousing-over things.

My Cache is deleted regularly and I have a feeling that might be what is causing it.

I play a 64-bit client on EU realms using Mac OS X 10.9.2.
__________________

Twitter | Blog
Last edited by Ethan Centaurai : 03-03-14 at 04:58 PM.
Ethan Centaurai is offline Report comment to moderator  
Reply With Quote
Unread 02-28-14, 07:45 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
That's very weird, and seems to indicate that Fishing Pole is not a valid item for your game client. What happens if you type this:

/dump GetItemInfo(6256)

If it prints "empty result" just run it again; this is normal, but also strange, since the addon intentionally calls it twice -- once when it loads and then again once all addons have loaded (at PLAYER_LOGIN) -- before it does anything, in case it's not already cached. However, what seems to be happening for you is that your game client is just never receiving the item info.

If you get "empty result" the second time too, then there is something wrong with your game client, and there's probably nothing I can do about it in the addon other than print a big warning and not try to do anything that requires identifying a fishing pole. Try exiting the game and deleting your entire Cache folder.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Last edited by Phanx : 02-28-14 at 07:45 PM.
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 02-28-14, 05:13 PM  
Ethan Centaurai
A Flamescale Wyrmkin
 
Ethan Centaurai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 138
File comments: 139
Uploads: 14
I get this error every time I log in:
Code:
21x GoFish\Addon.lua:374: Usage: IsEquippedItemType("type")
[C]: in function `IsEquippedItemType'
GoFish\Addon.lua:374: in function `?'
GoFish\Addon.lua:177: in function <GoFish\Addon.lua:177>

Locals:
self = GoFish {
 PLAYER_LOGOUT = <function> defined @GoFish\Addon.lua:309
 ToggleFishingMode = <function> defined @GoFish\Addon.lua:269
 PLAYER_LOGIN = <function> defined @GoFish\Addon.lua:279
 DisableFishingMode = <function> defined @GoFish\Addon.lua:254
 SetupClickHook = <function> defined @GoFish\Addon.lua:203
 UNIT_INVENTORY_CHANGED = <function> defined @GoFish\Addon.lua:373
 UNIT_SPELLCAST_CHANNEL_STOP = <function> defined @GoFish\Addon.lua:359
 PLAYER_REGEN_ENABLED = <function> defined @GoFish\Addon.lua:330
 UNIT_SPELLCAST_CHANNEL_START = <function> defined @GoFish\Addon.lua:349
 EnableFishingMode = <function> defined @GoFish\Addon.lua:232
 0 = <userdata>
 PLAYER_REGEN_DISABLED = <function> defined @GoFish\Addon.lua:316
}
unit = "player"
FISHING_POLE = nil
hasPole = nil
isFishing = nil
Help!
__________________

Twitter | Blog
Ethan Centaurai is offline Report comment to moderator  
Reply With Quote
Unread 12-17-13, 05:12 PM  
sezz
A Deviate Faerie Dragon

Forum posts: 13
File comments: 6
Uploads: 0
Awesome, finally a fishing addon for people who only want the double-right-click fishing.

Thanks Phanx!
sezz is offline Report comment to moderator  
Reply With Quote
Unread 11-30-13, 12:06 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 5.4.1.27
  • Fixed a possible error at startup if the mouse happened to be over a fish pool
  • Updated German translations from ckaotik on CurseForge
  • Updated for WoW 5.4
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 07-17-13, 03:06 AM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 5.3.0.22
  • Fixed deDE/zhTW localization conflict

Thanks for the report.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 07-12-13, 12:48 PM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 25
File comments: 167
Uploads: 5
Config UI Bug

Hi phanx,

the UI bugs on my deDE client. It doesn't show any texts as you can see in the tooltip. I'm using version 5.3.0.21 and at some point in the past it did work properly. Also, it seems most of the locale strings are now localized on Curse

Edit: Just figured out why! Locale-zhTW.lua checks for deDE (copy paste, anyone? )

__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 07-12-13 at 12:56 PM.
ckaotik is offline Report comment to moderator  
Reply With Quote
Unread 07-08-13, 07:41 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4384
File comments: 2031
Uploads: 40
Version 5.3.0.21
  • Updated for WoW 5.3
  • Fixed disabling option to enhance sounds
  • Added remaining "fish of the day" special pools
  • Added zhTW translations from BNSSNB
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: