Broker Garbage : WoWInterface Downloads : Data Broker

		WoWInterface Downloads » Stand-Alone Addons » Info/Plug-in Bars (sub-categories) » Data Broker
Broker_Garbage

Category: Data Broker

Addon Information

Works with 3.3

Author:	ckaotik [More]
Version:	3.3v19
Date:	03-14-2010 11:05 AM
Size:	183.82 Kb
Downloads:	2,015
Favorites:	73
MD5:

Pictures

Tooltip

Options Frame

List Management

Broker Garbage Updated less than 3 days ago!

Broker_Garbage is an LDB plugin wich shows your least valuable item(s) so you can easily delete it/them and make room in your bags.
It also offers a 'Loot Manager' that helps you decide which items to take, up to taking (almost) complete control of the loot process.

Ever been in a situation where you just can't turn in a quest because your inventory is full? Been trying to figure out an item that's cheap and won't make you loose much gold if you deleted it? Well, fear no more!

Features
* takes into account all three: Vendor price, auction price, disenchant price
* use various lists to manage special items - include/exclude/auto sell/vendor price
* set limits for items, e.g. 'Keep no more than 5 Soulshards'
* use LibPeriodicTable category strings to define sets
* option to automatically sell your junk to a vendor
* option to automatically repair your equipment (using guild bank funds, or not)

* supports Auctionator and Auctioneer (untested) auction house data
* set a quality drop treshold
* show (or don't) an icon to manually sell all grays
* shows money earned & lost in tooltip
* LDB display text customizable: have it show the item, the value, your bag space ... Or any/none of the above!
* Statistics!
* localized in German & English, but should work in any language [with the exception of auto delete and skinning]

If you would like to have Broker_Garbage localized in YOUR language, feel free to give me those translations. Or simply use Curse

Bug reports
I need your help, as I cannot test every possible addon combination

So, if you find a bug / something you doesn't feel right, leave me a note containing as much information as possible. If I can't recreate your problem, I probably can't solve it!
Sometimes you might encounter a questionmark icon. I included these as for some obscure reason, GetItemInfo() for certain seasonal and time-limited items does not work after some time (as the server could not have seen them since the last restart).

I don't personally use Auctioneer, so I'm not the least sure it does work flawlessly. If it doesn't I appreciate your help!
Same goes for any other auction value addons you might use and would like to have included here

Hints / Comments
If you don't want to sell/repair, just hold down SHIFT when adressing the merchant! If you never want to, just uncheck the options in the options frame.

If you don't want the Loot Manager to kick in, hold down SHIFT until you see the loot window or simply uncheck the option in the options frame.

If you want to quickly add an item to the "Force Vendor Price" list, simply ALT-click on it in the tooltip.
To add a category to your lists, right-click on the corresponding 'plus' icon and choose the one you want.

If you don't ever want to use the Loot Manager, you can disable it in the Broker_Garbage.toc file. Read the comments in there for more info!

Have a go and try /garbage (or /garb). You'll find a few (useful?) goodies in there

Change Log - Broker Garbage

3.3v19 Non-limited but included items will be handled properly once again. Same goes for Auto Sell List items.

3.3v18 Autodestroy fixed, fixed promoting limited items

3.3v17 Added the Loot Manager! It uses your Include (never loot) and Exclude List (always loot). to disable it, read the description or the readme.txt.
Added item limits! Want to keep no more than 5 Soulshards? Simply use your mousewheel on the corresponding icon on your include list. Items within that limit will not be shown on the tooltip.
Finally 'fixed' the Sell Icon - it will now properly show if there's something to sell - or not.
Also added some default list settings.
Fixed quite a hand full of bugs, too. Simplified code.

3.3v16 LDB display text option added to interface options panel. Statistics panel added. Fixed a bug where dragging items to the plus icons didn't work. Fixed a bug that caused too many items to appear in the tooltip. Finally found & fixed the bug that made you open positive lists before negative lists

3.3v15 /garbage commands added, LDB text made more customizable, 'pre' errors fixed. Birthday-to-be edition.

3.3v14 Added compatibility to Broker2FuBar. Category list menu reduced to interesting parts. Auto Sell Icon will now do its job.

3.3v13 Addid items to lists possible - once again. No more "LeftButton" added to any list. Fixed icons not updating if GetItemInfo was missing

3.3v12 Auto sell settings will now, once again, be properly saved. This fixed the checksound-error as well. Or is it the other way around? :P

3.3v11 Added LPT support - you can add categories to your lists by right clicking on the 'plus' icons. For more info, have a look at the readme.txt . There might still be bugs in there, but I didn't find any

Therefore tagging as beta (to keep the files consistent to curse.com's version).
Update: Told you, there would be bugs! Fixed desaturating icons. Fixed missing items crashing the addon (GetItemInfo on seasonal items sucks).

3.3v10 Bugfixes, once again. And no, an itemLink is NOT the same as an itemID ~.~ New lists should work properly now. Reset money earned/lost will now properly reset the local value, rather than the global one.

3.3v9 list management clarified, more lists added (have a look at the options or the readme file): Force Vendor Price & Auto-Sell. New: ALT-Click on an item in the tooltip and it will be added to your Vendor Price List.

3.3v8 no new features, just a bunch of bugfixes ... stupid stupid Macs ... hate them!

3.3v7 LDB plugin clicks should work for all displays, added "money earned" to tooltip info, shows "no items" instead of empty tooltip, show (or hide) icon to manually sell grays at a vendor

3.3v6 LDB plugin will now properly react to clicks. List Options should display properly

3.3v5 stupid me -.- left debug mode on ... should probably write a pre-release checklist or something. Indeed, I should. Missed something on the include list management.

3.3v4 Tooltip! Corrected auto-hide time, should(tm) work.
Interface! Added options menu to handle include/exclude lists. No more guessing what might be on there!

3.3v3 another try at fixing sticky tooltips (by having the LDB display having the work of hiding the tooltip, not the plugin)

3.3v2 deDE localisation fix, money chat message changed

3.3v1 first upload

Optional Files - Broker Garbage

Sorry, there are currently no optional files available.

Archived Versions - Broker Garbage

File Name	Version	Size	Author	Date
Broker_Garbage	3.3v17	184kB	ckaotik	03-13-2010 06:40 PM
Broker_Garbage	3.3v16	172kB	ckaotik	03-02-2010 11:49 AM
Broker_Garbage	3.3v15	168kB	ckaotik	02-21-2010 03:33 PM
Broker_Garbage	3.3v14	167kB	ckaotik	02-15-2010 11:48 AM
Broker_Garbage	3.3v14	167kB	ckaotik	02-15-2010 11:35 AM
Broker_Garbage	3.3v13	167kB	ckaotik	02-14-2010 07:38 AM
Broker_Garbage	3.3v12	167kB	ckaotik	02-12-2010 03:30 AM
Broker_Garbage	3.3v11	167kB	ckaotik	02-11-2010 01:14 AM
Broker_Garbage	3.3v11b	167kB	ckaotik	02-10-2010 04:28 PM
Broker_Garbage	3.3v10	36kB	ckaotik	01-24-2010 03:32 PM
Broker_Garbage	3.3v9	30kB	ckaotik	01-24-2010 12:52 PM
Broker_Garbage	3.3v8	26kB	ckaotik	01-11-2010 05:46 AM
Broker_Garbage	3.3v8	26kB	ckaotik	01-10-2010 03:25 PM
Broker_Garbage	3.3v7	30kB	ckaotik	01-09-2010 03:28 PM
Broker_Garbage	3.3v6	24kB	ckaotik	01-04-2010 08:34 AM
Broker_Garbage	3.3v5	24kB	ckaotik	01-03-2010 06:58 AM
Broker_Garbage	3.3v4	24kB	ckaotik	01-02-2010 06:35 PM
Broker_Garbage	3.3v4	24kB	ckaotik	01-02-2010 06:30 PM
Broker_Garbage	3.3v3	24kB	ckaotik	01-01-2010 05:03 PM
Broker_Garbage	3.3v2	37kB	ckaotik	12-31-2009 01:23 PM
Broker_Garbage	3.3v1	24kB	ckaotik	12-29-2009 11:31 AM

Comments - Broker Garbage

Comment Options

Page 1 of 3

Today, 06:20 AM

Zidomo

A Cyclonian

Forum posts: 44

File comments: 694

Uploads: 0

Quote:

Originally posted by ckaotik
No one forces you to use it I liked KarniCrap a lot, it just ... didn't quite fit for me so I decided to simply implement it myself.

Considering the fact that the loot manager is not even 500 lines of code (less than half of Broker_Garbage's default functionality), it provides quite a lot of extras.

Besides that: You don't even have to edit the .toc file. That's what the option menu is for in the first place.

Well, bloated mod is bloated

.

Doesn't matter how many hundreds of lines of additional code it is, its still unrelated feature creep (and at 26.8kb in combined file sizes, its a large amount of code). A function not in other auto-sell/garbage type mods. Sorry to see it a part of Broker Garbage now.

That new "loot manager" functionality really should be in a separate mod. If you really (really) want it a part of Broker Garbage, it should still be in a separate folder with LOD (load-on-demand) functionality instead of built-in. "Additional entries in the addon list" is never a problem, other than potential aesthetics. Feature creep is a problem

.

At least you give the TOC option to disable it (which, as Phanx said, is not viable for most users). But hope to see the implementation improved/removed in the future.

P.S. Logon error with 3.3v19 (with the "loot manager" commented out in the TOC) upgraded from 3.3v16:

Code:

 ["message"] = "Interface\\FrameXML\\InterfaceOptionsFrame.lua:614: attempt to index local 'frame' (a nil value):\nBroker_Garbage-3.3v19\\options.lua:1338: in main chunk\n\nLocals:|r\ninterestingPTSets = <table> {\n 1 = \"Consumable\"\n 2 = \"Misc\"\n 3 = \"Tradeskill\"\n}\nShowTooltip = <function> defined @Interface\\AddOns\\Broker_Garbage\\options.lua:92\nHideTooltip = <function> defined @Interface\\AddOns\\Broker_Garbage\\options.lua:101\nShowOptions = <function> defined @Interface\\AddOns\\Broker_Garbage\\options.lua:103\nShowListOptions = <function> defined @Interface\\AddOns\\Broker_Garbage\\options.lua:578\n\n  ---",
            ["type"] = "error",
            ["session"] = 1314,
            ["counter"] = 1,
        }, -- [449]
    },
    ["save"] = true,
    ["session"] = 1314,
}

Further edit: get the error right at logon on every character and happens at every relog. Back to 3.3v16.

Last edited by Zidomo : 03-15-2010 at 05:05 PM.

Yesterday, 04:03 PM

ckaotik

A Murloc Raider

Forum posts: 7

File comments: 57

Uploads: 3

Re: LDB display text doesn't change

Quote:

Originally posted by Jaim Sandar
When I change the text of the string in the Basic Options, there is no immediate change of the LDB display. Then when I relog or /reloadui, the Options Panel text string is back to the default.

Hrmm .. that sounds strangeas it works fine on my PC. The only thing I can assume is that there is a lua error produced by the string you use. The string you enter there is a lua format string and some special characters are 'reserved'. For example, if you wanted to print a '%' you would have to use '%%' in your string as the % is an escape character.
What are you trying to create?

__________________
It all starts to make a creepy kind of sense. Avatar

Yesterday, 02:34 PM
Jaim Sandar A Deviate Faerie Dragon Forum posts: 13 File comments: 300 Uploads: 1	LDB display text doesn't change When I change the text of the string in the Basic Options, there is no immediate change of the LDB display. Then when I relog or /reloadui, the Options Panel text string is back to the default. If I use the slash command, for example one from your readme.txt: /garbage format %1$s - (%4$d/%5$d) - %3$s ...nothing happens, neither on the LDB display nor to the string in the Basic Options panel. I am using 3.3v19. Thank you. Last edited by Jaim Sandar : 03-14-2010 at 02:34 PM.

Yesterday, 11:03 AM

ckaotik

A Murloc Raider

Forum posts: 7

File comments: 57

Uploads: 3

Quote:

Originally posted by SkunkWerks
the exclude lists don't seem to function properly- neither selling things designated for sale, nor adding items to the deletion tooltip.

Thank you for that notice! I got so tied up in the limited item thingy that I completely forgot that there might be non-limited included items

Both lists fixed in 3.3v19

__________________
It all starts to make a creepy kind of sense. Avatar

Yesterday, 10:39 AM
SkunkWerks A Deviate Faerie Dragon Forum posts: 12 File comments: 222 Uploads: 2	I like all these features just fine. However for whatever reason, in the latest update, the exclude lists don't seem to function properly- neither selling things designated for sale, nor adding items to the deletion tooltip.

Yesterday, 07:43 AM

ckaotik

A Murloc Raider

Forum posts: 7

File comments: 57

Uploads: 3

Quote:

Originally posted by Phanx
Are these really features that belong in a junk-managing addon?

No one forces you to use it

I liked KarniCrap a lot, it just ... didn't quite fit for me so I decided to simply implement it myself.

Quote:

Originally posted by Phanx
Editing the TOC isn't really a viable solution for most addon users. Wouldn't it be a better idea all around to put those features in a separate Broker_LootManager addon?

Considering the fact that the loot manager is not even 500 lines of code (less than half of Broker_Garbage's default functionality), it provides quite a lot of extras. And as Mirroar said, the Loot Manager relies heavily on BG's default functions. Also, personally I don't like having an addon of this rather small size load in fact three to four addons. Kind of spams the addon list ... (but that's just my opinion)

Besides that: You don't even have to edit the .toc file. That's what the option menu is for in the first place. I just structured the file this way so people (I was once among them) who absolutely cannot stand to have more files/memory usage/whatever than they really need can take this one step further by disabling the files.

__________________
It all starts to make a creepy kind of sense. Avatar

Last edited by ckaotik : 03-14-2010 at 07:51 AM.

Yesterday, 07:24 AM

Mirroar

A Kobold Labourer

Forum posts: 1

File comments: 4

Uploads: 1

Quote:

Originally posted by Phanx
Are these really features that belong in a junk-managing addon? Editing the TOC isn't really a viable solution for most addon users. Wouldn't it be a better idea all around to put those features in a separate Broker_LootManager addon?

Well, but even if you did put it as a seperate addon, BrokerGarbage would at least be a dependancy of that Addon. To my knowledge the lootmanager relies heavily on BrokerGarbage's item-priece calculations and some other things to make intelligent choices about what to loot and what not to loot.
Having it as a seperate Addon (even if included in BrokerGarbage's download) would at least allow you to easily disable it in the Addons list instead of editing the .toc

Yesterday, 12:49 AM

Phanx

A Frostmaul Preserver

Forum posts: 264

File comments: 831

Uploads: 17

Quote:

From the changelog:
3.3v17 Added the Loot Manager! It uses your Include (never loot) and Exclude List (always loot). to disable it, read the description or the readme.txt.
Added item limits! Want to keep no more than 5 Soulshards? Simply use your mousewheel on the corresponding icon on your include list. Items within that limit will not be shown on the tooltip.

Are these really features that belong in a junk-managing addon? Editing the TOC isn't really a viable solution for most addon users. Wouldn't it be a better idea all around to put those features in a separate Broker_LootManager addon?

Last edited by Phanx : 03-14-2010 at 12:51 AM.

03-07-2010, 10:21 AM

ckaotik

A Murloc Raider

Forum posts: 7

File comments: 57

Uploads: 3

Quote:

Originally posted by Zidomo
So still looking forward to improvements there .

Done! That and much more

The latest (beta-state) version can always be found on GitHub!

__________________
It all starts to make a creepy kind of sense. Avatar

Last edited by ckaotik : 03-13-2010 at 07:06 PM.

03-04-2010, 12:42 PM

Zidomo

A Cyclonian

Forum posts: 44

File comments: 694

Uploads: 0

Quote:

Originally posted by ckaotik
Well, I just added any sign of "Well, you did click on me" notification a short while ago. I know it's not as comfortable as it could be but to achieve that I would have to rewrite the whole auto selling process, which I can of course do - just not at this time. So it will eventually come. Just have a little patience

Will do

. That chat text notification is OK...but it doesn't show up until after you click the vendor icon.

You still are wasting time & effort clicking the icon when you don't have to if there is nothing to sell. As you can't tell from it if you have things to sell or not, unlike the other two "garbage" mods (among others) mentioned.

It minimizes the point of having that icon in the first place. Why bother wasting time clicking something that you can't tell needs to be clicked or not when you could auto-sell instead?

So still looking forward to improvements there

02-24-2010, 08:05 AM

ckaotik

A Murloc Raider

Forum posts: 7

File comments: 57

Uploads: 3

Quote:

Originally posted by Zidomo
Every time you visit a vendor, the icon in the vendor frame is "lit up", whether or not you have any garbage to sell.

Well, I just added any sign of "Well, you did click on me" notification a short while ago. I know it's not as comfortable as it could be but to achieve that I would have to rewrite the whole auto selling process, which I can of course do - just not at this time. So it will eventually come. Just have a little patience

Quote:

Originally posted by Zidomo
GL in your exams!

Thanks

__________________
It all starts to make a creepy kind of sense. Avatar

02-24-2010, 04:03 AM
Zidomo A Cyclonian Forum posts: 44 File comments: 694 Uploads: 0	Nice. As efficient as DropTheCheapestThing (no CPU used) and adds an items-sold/dropped-value log like FuBar_GarbageFu had. One issue with v3.3v15, though. I have Broker Garbage set not to auto sell and only sell when I click the icon in the vendor frame. Every time you visit a vendor, the icon in the vendor frame is "lit up", whether or not you have any garbage to sell. This is unlike DropTheCheapestThing (or FuBar_GarbageFu), which only have their vendor icons highlighted (and clickable) when you actually have garbage to sell. The problem causes you to waste time clicking when you might not have to. So would be nice to have Broker Garbage's icon greyed out (or similar) when there is nothing to sell. GL in your exams!

02-21-2010, 11:39 PM
Jaim Sandar A Deviate Faerie Dragon Forum posts: 13 File comments: 300 Uploads: 1	Oh, wow! Thank you for the fixes, and for the customizable display.

02-21-2010, 03:35 PM
ckaotik A Murloc Raider Forum posts: 7 File comments: 57 Uploads: 3	Soooooo ... New version, new bugs to find! Have a look at the change log for "detailed" information and don't forget to try playing around with /garbage. You want to have the number of free bag slots shown? Well, now you can. Have a look at the readme (section 7) for further information. Update: No ... more ... updates. At least this week Two exams in 4 days, yeeha. __________________ It all starts to make a creepy kind of sense. Avatar Last edited by ckaotik : 02-21-2010 at 03:38 PM.

02-21-2010, 10:42 AM

Jaim Sandar

A Deviate Faerie Dragon

Forum posts: 13

File comments: 300

Uploads: 1

Quote:

Originally posted by ckaotik
For a quick-fix on your side (until I upload the correct version) rewrite line 29 in options.lua to this:

Code:

if not pre[ partials[i] ] or type(pre[ partials[i] ]) == "string" then

What line is that in options.lua? Line 29 of options.lua in my installation of version 3.3v14 is

Code:

end

That can't be the the line to change, can it?

Quote:

Originally posted by ckaotik
I feel that's more a bag addon type of feature (whereas I myself see Broker_Garbage more like a "utility" addon).

I understand that not everyone does things the same as everyone else, and what is important to me might not be to you and some others.
For me, knowing how many bag slots are free (or not) is useful in deciding what to do with garbage. That is why I valued the optional bag slots display in the other AddOns. In my opinion, it is directly related to and needed for a garbage mod.

It is your project; I respect your decision to do it the way you want it to be done.

Thank you.

Page 1 of 3

Report this File

Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.

[Disable these notices]