Quantcast
Download
(809 Kb)
Download
Updated: 11-16-17 09:45 PM
Pictures
File Info
Compatibility:
Shadows of Argus (7.3.0)
Tomb of Sargeras (7.2.0)
Return to Karazhan (7.1.5)
Legion (7.0.3)
Updated:11-16-17 09:45 PM
Created:unknown
Downloads:134,097
Favorites:823
MD5:
7.3.0

TipTop  Popular! (More than 5000 hits)

Version: 2.19.2
by: Seerah [More]

In my quest to find the perfect tooltip mod, I decided to create my own and have a learning experience. Thus, TipTop was born. TipTop seeks to modify the default tip instead of replace it.


Known Issue: the disappearing/flickering tooltip issue is on Blizzard's end. People have been reporting the issue with various tooltip addons as well as with only the default UI. There are several posts about it on the Technical Support forums, but no blue response that I know of so far.

Update: the Blizzard bug may have something to do with quickly mousing over minimap tracking icons at the edge of your minimap. Try mousing over another tracking icon to try to bring back the tooltip.




Apparently, my comments are a magnet for bug reports and feature requests, despite the buttons for them to the right to put them on my portal, the FAQ saying to put them on my portal (with links even!), and repeated requests in the comments section to put them at my portal. So I'll put it here in big, colorful, bold letters.

FEATURE REQUESTS AND BUG REPORTS NEED TO BE PUT ON MY PORTAL. IF YOU PUT THEM IN MY COMMENTS, THEY WILL MOST LIKELY BE FORGOTTEN AND/OR IGNORED.
I appreciate the time that you take to report bugs and request things, but please appreciate the time/effort that it takes me to go through them and remember them, and please just put them in the correct location.



Features:
  • optional class-colored border for units (optional support for !ClassColors)
  • optional difficulty-colored border for units
  • option to display class icon before unit's name in tooltip (off by default)
  • various class icon textures to choose from (thanks, gossipgirlxo and Flat Player Icons!)
  • option to display guild rank (off by default)
  • added target text line
  • "faded" tip if unit is tapped, dead, or offline
  • custom border, background, and status bar textures
  • custom font selection, plus option of Outline, etc.
  • custom background color/alpha
  • custom health bar color, including class-colored
  • ability to move the tooltip or attach to cursor
  • can show health on statusbar in five different formats
  • health bar may be above or below the tooltip, or be contained inside the tooltip
  • item-quality colored border for items
  • raid icon display
  • added talent text line
  • displays (Rare), (AFK), and (DND) when possible, next to the unit's name
  • option to display elite/rare elite graphic for those units
  • adjust tip background alpha
  • SharedMedia support
  • each character has a choice of using either a global or character specific profile



FAQ:

Where are the options?
The options panel is located on the addons page of the Interface Options panel. Hit escape, go to Interface, click the AddOns tab, and you'll see TipTop listed there. You can also use the slash commands /tiptop or /tip

How do I move the tooltip?
In the TipTop config window, scroll down until you see the anchor settings. You may either anchor the mouse to the cursor, or to a side/corner of the screen. Note that x,y offsets only work when the tip is *not* anchored to the cursor. This is a limitation set by the game's API, and I will not code in the hacks that other tooltip addons use to get around this. I suggest using the alpha setting instead so the tip doesn't block your view so much.

I want the tooltip offset from the cursor - will you add it or is it bugged?
See above.

Where can I find more fonts/borders/bar textures?
For further font choices, I suggest the SharedMedia addon. Have a font you want to use that's not in there? Read the "Instructions for MyMedia.txt" file in the SharedMedia folder.

How can I give feedback?
Feel free to leave your comments/questions here, but all bug reports and feature requests need to go to my portal if you want me to remember to do them.

Can I use your code/textures?
All use of my code and custom textures separate from TipTop must be for your own personal use and they may not be redistributed separate from the addon. You may use snippets of my code in addons you intend to distribute only after receiving permission, and credit must be given.

Can I redistribute this addon?
My addons may only be redistributed in UI compilations, and any mention of the addon must point to its download page or my portal, both on wowinterface.

Do you accept cookies?
I love cookies! Unfortunately, they may turn to crumbs in the mail. Instead, you may donate to my cookie fund via PayPal.

2.19.2
- fixed another boss mouseover bug with large health numbers

2.19.1
- updated TOC number for 7.3
- modified usage of :SetBackdrop to keep the Aurora addon from complaining

2.19
- tweaked raid marker code, in case the client ever returns a number without an icon assigned to it
- added the ability to set the font of the health bar text independently

2.18.1
- fix for guild ranks not displaying for characters from other servers

2.18
- added option to disable class-colored border for NPCs
- added option to disable class icon for NPCs
- reorganized options

2.17
- added font size option for tooltip text
- added font size option for health bar text

2.16.3
- fix (hopefully) for integer overflow error on NPCs with extremely large amounts of health, when curhp/maxhap is displayed on healthbar

2.16.2
- update TOC for 7.1
- tweaked specialization line code
- tweaked tooltip anchor code (should play nice with the updates to LibItemUpgradeInfo using by Auctionator, etc)

2.16.1
- possible fix for repeated specialization lines
- "specialization" is now localized

2.16
- added new class icon textures
- removed old class icon texture files (used straight from default UI now)
- updated LibSharedMedia-3.0

2.15
- added new health format, 1.2k / 1.2k (100%), as requested

2.14.4
- fix for anchor not showing

2.14.3
- update for Legion
- fixed for new API to check if unit is tapped

2.14.2
- fixed nil error if you don't have the elitetexture setting enabled

2.14.1
- fixed elite texture bug (where it wouldn't hide after mousing over an elite unit)
- fixed typo that's been there for years and no one's ever noticed - rare elite texture (silver dragon) should now display
- fixed oversight that I haven't updated the manual level number for units with a level of -1 (skull texture) for a couple of xpacs... >.>

2.14
- updated for WoD
- added :ClearAllPoints() call when reanchoring GameTooltip
- Removed references to ShoppingTooltip3 and ItemRefShoppingTooltip3 which were removed from the UI.

2.13.3
- added missing logic check to fix error on line 296

2.13.2
- logic check to fix error in 5.4
- updated Ace3 libs
- updated TOC for 5.4

2.13.1
- fix for nil error reported by Ookami.kun

2.13
- updated TOC for 5.2
- updated libraries
- added new feature: ability to display guild rank (off by default)

2.12
- updated TOC to 5.1
- put in fix for white borders on clickable tooltips when border is hidden or not set to color by item quality
- skin Blizz's new compare tips for clickable tooltips
- fixed level logic for difficulty coloring

2.11.1
- put in check to only set percent health text if <= 100%
- this fixes errors where the client would wrongly report a maxhp of 1

2.11
- updated TOC for MoP
- updated libs
- added Monk class icon
- fixed talents - they now only show Specialization, no talent points
- added option to truncate health text
- cleaned up code a tad
- localized new globals in the upvalues list
- added optional faction icon to tooltip (settings located in "Extra Stuff" section)
- removed "MONOCHROME" font flag because it currently crashes the client
- changed "THICK OUTLINE" font flag to "MONOCHROME OUTLINE" (this won't crash you)
- changed two included statusbar textures - converted to .blp properly this time

2.9.4
- updated TOC for 4.3
- updated libs

2.9.3
- fixed a bug with the short talents option when mousing over someone with no talent spec

2.9.2
- that was quick! today's mini-patch fixed heirloom item colors (removed override code from TipTop)

2.9.1
- attempt to fix Blizz bug where Heirloom items are colored white (this only fixes the tooltip borders, I filed a bug report to fix on the servers)

2.9
- added option to only show main spec name (hiding the talent points)

2.8.3
- updated libs
- tweaked options layout for larger window

2.8.2
- bumped TOC number for 4.2
- all seems to be working as expected!

2.8.1
- updated libs
- fixed: health bars now stay your custom color!

2.8
- the health bar on the tooltip may now be colored by class

2.7
- FIXED: nil error when trying to get talents from players who haven't chosen their spec yet
- NEW: draggable frame for quick repositioning of the tooltip. X,Y coordinates are still available for fine tuning. Don't want to use the mover frame? It's not created or anything until you click the config button for it.

2.6
- optimizations to talent gathering code

2.5
- updated for Cataclysm
- changed "INSPECT_TALENT_READY" to "INSPECT_READY"
- use GUID returned by new event to only grab talents for the unit I requested
- fix for changes to GetTalentTabInfo()
- updated all libraries

2.4
- fiddled with padding between statusbar and frame border when the health bar is inside
- can now color the border by level difficulty (if class and difficulty are *both* selected, friendly units will be colored by class, and others will be by difficulty)
- changed hp display for units with no maxhp (ex. walls in WG) so that maxhp is 1 - this displays their current health, at least, instead of forcing the text to be blank
- fix for random/rare error with talents

2.3.2
- refix for talent spam

2.3.1
- hopefully fixed: nil error and repeating icon bug
- fixed: minimum width for tooltip (code is for aesthetics and to fit in health display)
- updated: libs and TOC number

2.3
- Fixed: talent text spamming the tooltip for some raid frames
- Fixed: Elite graphic not obeying its checkbox in options
- Added: option to display class icon next to name in tooltip (off by default)

2.2
- you can now set the font flags for the tooltips' text (Outline, etc)
- if you have the elite graphic enabled, it will now show for bosses too

2.1.1
- added support for WorldMapTooltip
- fixed health percent display for "units" with no health (gates in Wintergrasp, for example)

2.1
- added a couple additional checks to silence a couple errors
- added some additional options for profiles (copy from default profile and reset profile)

2.0.1
- fixed error for custom created frames/tooltips that try to look like the game tooltip - let me know if something's still awry
- fixed an oopsie - target text works again (had accidentally deleted the line that called its function >.< )

2.0
- semi-rewrite of 1.x
- the ability to have the health bar inside the tip is back
- rearranged options
- new health bar color option
- added an elite/rare elite graphic option for hubby
- changed directory structure and pushed media into a media subdirectory
Optional Files (0)


Archived Files (61)
File Name
Version
Size
Author
Date
2.19.1
809kB
Seerah
09-27-17 08:05 PM
2.19
809kB
Seerah
08-05-17 12:13 PM
2.18.1
808kB
Seerah
07-22-17 01:48 PM
2.18
808kB
Seerah
02-22-17 09:34 PM
2.17
808kB
Seerah
02-07-17 09:37 PM
2.16.3
808kB
Seerah
01-28-17 04:01 PM
2.16.2
808kB
Seerah
11-05-16 03:23 PM
2.16.1
808kB
Seerah
09-15-16 09:17 PM
2.16
808kB
Seerah
08-19-16 12:48 PM
2.15
165kB
Seerah
07-30-16 01:45 PM
2.14.4
165kB
Seerah
07-27-16 09:13 PM
2.14.3
165kB
Seerah
07-19-16 12:58 PM
2.14.2
164kB
Seerah
12-22-14 01:11 PM
2.14.1
164kB
Seerah
12-20-14 10:38 PM
2.14
164kB
Seerah
10-22-14 09:12 PM
2.13.3
164kB
Seerah
02-13-14 05:18 PM
2.13.2
164kB
Seerah
09-14-13 10:20 PM
2.13.1
163kB
Seerah
03-20-13 07:55 PM
2.13
163kB
Seerah
03-13-13 03:58 PM
2.12
163kB
Seerah
01-29-13 10:17 PM
2.11.1
163kB
Seerah
08-29-12 09:14 PM
2.11
163kB
Seerah
08-26-12 09:56 PM
2.9.4
162kB
Seerah
11-29-11 10:41 PM
2.9.3
162kB
Seerah
08-11-11 11:34 AM
2.9.2
162kB
Seerah
08-08-11 04:36 PM
2.9.1
162kB
Seerah
08-03-11 02:50 PM
2.9
162kB
Seerah
07-28-11 10:33 PM
2.8.3
162kB
Seerah
07-08-11 01:13 PM
2.8.2
161kB
Seerah
06-28-11 10:22 PM
2.8.1
161kB
Seerah
02-15-11 08:57 PM
2.8
160kB
Seerah
12-03-10 03:32 PM
2.7
160kB
Seerah
11-05-10 10:25 PM
2.6
160kB
Seerah
10-18-10 09:40 PM
2.5
160kB
Seerah
10-11-10 10:38 PM
2.4
189kB
Seerah
05-30-10 05:10 PM
2.3.2
188kB
Seerah
12-12-09 09:34 PM
2.3.1
188kB
Seerah
12-10-09 11:07 PM
2.3
184kB
Seerah
10-18-09 08:35 PM
2.2
155kB
Seerah
10-05-09 03:42 PM
2.1.1
154kB
Seerah
09-23-09 09:50 PM
2.1
154kB
Seerah
09-17-09 02:28 PM
2.0.1
154kB
Seerah
09-15-09 01:14 PM
2.0 release
154kB
Seerah
09-14-09 12:07 PM
1.9.1
127kB
Seerah
08-20-09 02:51 PM
1.9
127kB
Seerah
08-20-09 02:22 PM
1.8.9
133kB
Seerah
08-16-09 11:03 PM
1.8.8
117kB
Seerah
06-03-09 09:38 PM
1.8.7
117kB
Seerah
05-18-09 09:52 PM
1.8.6
117kB
Seerah
04-13-09 01:30 PM
1.8.5
117kB
Seerah
02-21-09 10:40 PM
1.8.4
117kB
Seerah
02-14-09 10:33 PM
1.8.3
117kB
Seerah
02-13-09 11:15 PM
1.8.2
117kB
Seerah
02-03-09 09:55 PM
1.8.1
117kB
Seerah
01-22-09 11:51 AM
1.8
113kB
Seerah
01-17-09 11:37 PM
1.7
125kB
Seerah
01-02-09 01:58 PM
1.6.1
125kB
Seerah
11-30-08 10:39 PM
1.6
125kB
Seerah
11-30-08 12:18 AM
1.5.3
125kB
Seerah
11-26-08 10:13 PM
1.5.2
125kB
Seerah
11-14-08 11:28 PM
1.5.1
125kB
Seerah
11-14-08 12:54 AM


Post A Reply Comment Options
Unread 11-07-17, 02:49 AM  
BuGsY
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Originally Posted by Seerah
Originally Posted by dary1125
Message: integer overflow attempting to store 2287844080
Time: 10/17/17 17:07:52
Count: 1
Stack: integer overflow attempting to store 2287844080
[C]: ?
[C]: in function `SetFormattedText'
Interface\AddOns\TipTop\tiptop.lua:401
: in function <Interface\AddOns\TipTop\tiptop.lua:355>
[C]: ?

Locals:


Are you sure you are running the latest version of TipTop? And have you tried disabling all other addons besides TipTop to see if the error persists?

When did this error happen? How often does it happen?
I came here because of this error, even in the 7.3. It happens on every boss in Heroic ToS. I think it has to do with health. I didn't start happening until Nighthold and only on Helya in ToV.

Code:
Date: 2017-11-07 02:39:44
ID: 9
Error occured in: Global
Count: 1
Message: integer overflow attempting to store 4047265280
Debug:
   [C]: SetFormattedText()
   TipTop\tiptop.lua:355:
      TipTop\tiptop.lua:345
   [C]: ?
Locals:
(*temporary) = ttHealth {
 0 = <userdata>
}
(*temporary) = "%d / %d"
(*temporary) = 4047265280
(*temporary) = 4047265293

AddOns:
  Swatter, v7.0.5664 (TasmanianThylacine)
  Bartender4, v4.7.10
  BattlegroundTargets, v70000-1
  BigWigs, vv75.1
  BigWigsCore, v
  BigWigsPlugins, v
  BigWigsTombOfSargeras, v
  CensusPlus, v7.0.
  Chinchilla, vv2.8.5
  TidyPlates, v6.18.11
  TidyPlatesQuatre, v
  TidyPlatesHub, v
  TidyPlatesWidgets, v
  TipTop, v2.18.1
  BlizRuntimeLib_enUS v7.3.2.70300 <none>
  (ck=59e)
Report comment to moderator  
Reply With Quote
Unread 10-18-17, 07:43 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Originally Posted by dary1125
Message: integer overflow attempting to store 2287844080
Time: 10/17/17 17:07:52
Count: 1
Stack: integer overflow attempting to store 2287844080
[C]: ?
[C]: in function `SetFormattedText'
Interface\AddOns\TipTop\tiptop.lua:401
: in function <Interface\AddOns\TipTop\tiptop.lua:355>
[C]: ?

Locals:


Are you sure you are running the latest version of TipTop? And have you tried disabling all other addons besides TipTop to see if the error persists?

When did this error happen? How often does it happen?
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Report comment to moderator  
Reply With Quote
Unread 10-17-17, 03:51 AM  
dary1125
A Kobold Labourer

Forum posts: 0
File comments: 24
Uploads: 0
Message: integer overflow attempting to store 2287844080
Time: 10/17/17 17:07:52
Count: 1
Stack: integer overflow attempting to store 2287844080
[C]: ?
[C]: in function `SetFormattedText'
Interface\AddOns\TipTop\tiptop.lua:401
: in function <Interface\AddOns\TipTop\tiptop.lua:355>
[C]: ?

Locals:
Report comment to moderator  
Reply With Quote
Unread 09-28-17, 02:16 AM  
veoj
A Defias Bandit
 
veoj's Avatar

Forum posts: 2
File comments: 40
Uploads: 0
Re: Re: Re: Re: Problems in 7.3?

Originally Posted by Seerah
Originally Posted by veoj
Basically the latest version of Aurora doesn't like you sending in {} to the SetBackdrop() function
Thanks for that. I don't use Aurora, and that line of code is at least 8 years old. I can change it to a blank texture instead of an empty table.
I've tested 2.19.1 and it works perfectly.

Many thanks for the fast response and fast fix

Regards

joev
__________________
Report comment to moderator  
Reply With Quote
Unread 09-27-17, 12:31 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Re: Re: Re: Problems in 7.3?

Originally Posted by veoj
Basically the latest version of Aurora doesn't like you sending in {} to the SetBackdrop() function
Thanks for that. I don't use Aurora, and that line of code is at least 8 years old. I can change it to a blank texture instead of an empty table.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Report comment to moderator  
Reply With Quote
Unread 09-26-17, 03:55 PM  
veoj
A Defias Bandit
 
veoj's Avatar

Forum posts: 2
File comments: 40
Uploads: 0
Re: Re: Problems in 7.3?

Originally Posted by Seerah
Originally Posted by veoj
Hi there,

Wondering if anyone else is suffering issues in 7.3 with this addon? For some reason it's totally immovable.
I haven't tried moving the tooltip (and don't keep it anchored to my mouse), but I'll take a look the next time I log in.

Are you getting any errors?
Yep. Turns out it's an incompatibility with the latest version of Aurora.
Code:
Line 74: 	tt:SetBackdrop({})
... causes an error in the Aurora API which means the PlayerLogin function doesn't complete (and hence doesn't reposition the tooltip at the mover offsets).

Simply commenting out the line works for me but I'm sure you'll want a more robust solution that will stand the test of time

Therefore: For what it's worth, here's the error grabbed from bugsack(/bugrabber) - Sorry would have looked at this myself if I'd realised there was an error but for some reason I can't quite remember I appear to have deleted bugrabber and bugsack at some stage so was oblivious to the Lua error

Code:
1x Aurora\Skin\api.lua:194: Usage: <unnamed>:SetSize(width, height)
[C]: in function `SetSize'
Aurora\Skin\api.lua:194: in function `SetBackdrop'
TipTop\tiptop-2.19.lua:74: in function `SetBackgrounds'
TipTop\tiptop-2.19.lua:525: in function <TipTop\tiptop.lua:519>

Locals:
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = nil
(*temporary) = nil
Basically the latest version of Aurora doesn't like you sending in {} to the SetBackdrop() function

Awesome addon btw. Love it. Love it. Love it.

Cheers

joev
__________________
Report comment to moderator  
Reply With Quote
Unread 09-26-17, 11:41 AM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Re: Problems in 7.3?

Originally Posted by veoj
Hi there,

Wondering if anyone else is suffering issues in 7.3 with this addon? For some reason it's totally immovable.
I haven't tried moving the tooltip (and don't keep it anchored to my mouse), but I'll take a look the next time I log in.

Are you getting any errors?
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Last edited by Seerah : 09-26-17 at 11:42 AM.
Report comment to moderator  
Reply With Quote
Unread 09-26-17, 12:59 AM  
veoj
A Defias Bandit
 
veoj's Avatar

Forum posts: 2
File comments: 40
Uploads: 0
Problems in 7.3?

Hi there,

Wondering if anyone else is suffering issues in 7.3 with this addon? For some reason it's totally immovable.

Setting to mouse-anchor has no effect. Using the draggable mover likewise has no effect (the mover moves and saves it's position but the tooltip doesn't move to the mover regardless what I do).

Looking at the code for the rest of my addons, can't see anything else hooking "GameTooltip_SetDefaultAnchor" so I'm at a loss to understand what's going on (otherwise I'd have fixed it and submitted a patch :>)

Anyone else having problems in 7.3 with this?

Regards4

joev
__________________
Report comment to moderator  
Reply With Quote
Unread 07-24-17, 12:08 AM  
ceylina
A Wyrmkin Dreamwalker

Forum posts: 50
File comments: 93
Uploads: 0
Thanks for taking the time to answer. Your solution is elegant and simple
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 07:39 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Originally Posted by ceylina
Personal curiosity, is wow's cobbled lua implementation faster in doing internal functions (math as in less than) than a built in wow function call (unitExists)? I guess it depends on the function? UnitExists is a boolean check while icon < 9 has to check against 18 possible index locations of GetRaidTargetIndex and both of those functions by blizzard essentially have to check against the unit moused over that GetRaidTargetIndex is going to do anyway.

I would be curious of the process cost of both. Neither here nor there, I like your solution better personally
As a reminder, and a note to those reading, this portion of code in TipTop now reads:
Lua Code:
  1. local function RaidIconUpdate()
  2.     local icon = GetRaidTargetIndex("mouseover")
  3.     if icon and icon < 9 then
  4.         SetRaidTargetIconTexture(raidIcon, icon)
  5.         raidIcon:Show()
  6.     else
  7.         raidIcon:Hide()
  8.     end
  9. end
If no icon is set for the unit, GetRaidTargetIndex returns nil.

Now to your questions.

UnitExists() is a global function. When calling it for the before-mentioned logic, the client:
1. looks up the UnitExists key in the global table (_G) to see what it is assigned to - in this case a function
2. calls the function (passing through the "mouseover" unit in this case, checking to see if that is a valid unitID, and checking to see if "mouseover" actually applies to a unit)
3. uses that boolean to progress into the if-block or not

If we use icon < 9 instead, the client does this:
1. looks up what the local variable icon is assigned to (let's say it's set to the value of 1, a number, for the first raid marker)
2. uses the comparative operator < to see if 1 < 9
3. uses that boolean to progress into the if-block or not

At first glance, this seems like the same amount of work - or steps, anyway. However, local variable lookups are faster than global variables. I happen to upvalue the UnitExists function at the top of the TipTop file, so it IS local, not global. Comparing step 1, in this case then, is moot. For step 2, function calls are one of the most expensive things in Lua. The UnitExists function is actually defined in C, so this function gets run on the C-side of the client. This makes it a little bit faster and more efficient, but not as much as simply comparing two numbers to each other.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Last edited by Seerah : 07-23-17 at 07:43 PM.
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 03:50 PM  
ceylina
A Wyrmkin Dreamwalker

Forum posts: 50
File comments: 93
Uploads: 0
Originally Posted by Seerah
Instead of an extra function call, I'll just add in a check to see if the icon index is in the range we want. (icon < 9) This will be a little faster.
Personal curiosity, is wow's cobbled lua implementation faster in doing internal functions (math as in less than) than a built in wow function call (unitExists)? I guess it depends on the function? UnitExists is a boolean check while icon < 9 has to check against 18 possible index locations of GetRaidTargetIndex and both of those functions by blizzard essentially have to check against the unit moused over that GetRaidTargetIndex is going to do anyway.

I would be curious of the process cost of both. Neither here nor there, I like your solution better personally
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 01:56 PM  
Devellien
A Kobold Labourer

Forum posts: 0
File comments: 20
Uploads: 0
Re: Re: flight map and world map

Originally Posted by Seerah
Are you talking about on the World Map, minimap, in the world? And did you try with only TipTop enabled?
i figured it out i just started using Elvui about a month ago and it was a tooltip option in it that i didn't disable so your addon works as it was suppose to

thank you again i appreciate it
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 12:16 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Re: flight map and world map

Originally Posted by Devellien
when i hover over the icon's around legion all of the tooltips are white making all the text unreadable

thank you for updating i prefer this addon over the rest
Are you talking about on the World Map, minimap, in the world? And did you try with only TipTop enabled?
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Last edited by Seerah : 07-23-17 at 12:17 PM.
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 12:15 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 10401
File comments: 677
Uploads: 25
Originally Posted by ceylina
Wanted to share something I had an error with trying another tooltip addon that showed raid markers.
Thanks. Wowprogramming doesn't have that note, and I'm sure that's where I found the function years ago when adding this feature. Instead of an extra function call, I'll just add in a check to see if the icon index is in the range we want. (icon < 9) This will be a little faster.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Report comment to moderator  
Reply With Quote
Unread 07-23-17, 10:22 AM  
ceylina
A Wyrmkin Dreamwalker

Forum posts: 50
File comments: 93
Uploads: 0
Wanted to share something I had an error with trying another tooltip addon that showed raid markers.

I was on break (I think) between a boss kill and got an error with the other addon at the point where the function GetRaidTargetIndex() was used. The error was because they were trying to concatenate together the marker name returned from the index of GetRaidTargetIndex and using the global ICON_LIST[index]. While you do not use the function like they do, you do call GetRaidTargetIndex() around line 203

I am bringing this up because of something that the wowpedia page for the function says caught my eye while trying to figure this out:

This function can return arbitrary values if the queried unit does not exist. Use UnitExists to check whether a unit is valid.

For example: "raid2target" when "raid2" is offline and not targetting anything at all misbehaves.
http://wow.gamepedia.com/API_GetRaidTargetIndex

I don't endorse wowpedia one way or the other but I think it interesting that it states UnitExists() should be used to validate GetRaidTargetIndex returning a proper index for a marker. Well it says invalid units can return arbitrary values but if someone disconnects or otherwise goes offline but visually shows online this may possibly could happen (that's my theory as to why the error kept happening 12 times)

I experienced the error this can cause and wanted to pass it along because this is my main tooltip addon and I was testing that one as it was well new and I am a sucker for new and shiny


What I am getting at is that in the super rare possible outcome, it may trip up"local icon = GetRaidTargetIndex("mouseover")" and the variable icon may give a valid return but not one that is one of the known raid markers (skull, moon, etc). icon can return some number 1-18 while only 1-8 correspond to known marker icons or at least the unit is a valid unit. I just know in some circumstances it can not return the index you want.

I have never had an error with your addon relating to this but maybe it tripped up but never threw an error. Like the unit had a marker but was offline?

What am I getting at? Well maybe adding in UnitExists("mouseover") as a validation step before, during, or after GetRaidTargetIndex() will make sure you only get a raid marker showing on the tooltip if it is one of the known raid markers.


This was long winded because 99% of the time I report anything anywhere the author thinks I am speaking in absolutes and "that can't happen / you don't know what you are talking about" is often the first reply and it now makes me never get just to the point anymore.



Point: GetRaidTargetIndex() needs to make sure unit is valid so using UnitExists() makes sure proper raid marker is shown. You may want to add that to have addon always work right showing raid markers.
Last edited by ceylina : 07-23-17 at 11:37 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.