Download
(885Kb)
Download
Updated: 07-21-18 10:57 AM
Pictures
File Info
Compatibility:
Battle for Azeroth (8.0.1)
Updated:07-21-18 10:57 AM
Created:unknown
Downloads:1,306,073
Favorites:2,694
MD5:

Outfitter  Popular! (More than 5000 hits)

Version: 5.20.3
by: mundocani [More]

About Outfitter

Outfitter is an equipment management addon which gives you fast access to multiple outfits to optimize your abilities in PvE and PvP, automated equip and unequip for convenience doing a variety of activities, or to enhance role-playing.

Outfitter includes an icon bar for fast access to your outfits, a minimap menu for fast compact access, support for LibDataBroker, scripting with a library of pre-made scripts for most common tasks, outfits optimized for a particular stat, item comparisons across outfits, quick access to items via the character sheet, and more.

Version 5.20.3 changes

* FIXED: Prevented more custom events from being registered with the system

Version 5.20.2 changes

* FIXED: Storing outfits on the server no longer gives an error

Version 5.20.1 changes

* FIXED: Outfitter's custom event types should longer give errors about being unknown

Version 5.20 changes

* FEATURE: Updated for patch 8.0
Post A Reply Comment Options
Unread 10-25-08, 05:31 PM  
Duncanmctung
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Spellsurge!

I see:

SPELL_ENERGIZE Spellsurge 27996 number

HAHAHA!

Typo alert!

Your original script seems to be fine, but we didn't catch an extra G in one of the tests. And, I thought I read it with my debugging eyes too...

Thanks for your effort!

I'll let you know how it works in combat soon.

-Duncan
Report comment to moderator  
Reply With Quote
Unread 10-25-08, 01:48 AM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
Re: Spellsurge

Try this version -- you'll get spammed in your chat window every time you do anything, but watch for the Spellsurge to show up and then let me know what the line it appears on says.

Code:
-- $EVENTS PLAYER_ENTERING_WORLD COMBAT_LOG_EVENT_UNFILTERED TIMER
-- $DESC Equips the outfit when the players own Spellsurge procs, then unequips it 50 seconds later

if event == "PLAYER_ENTERING_WORLD" then
    outfit.spellsurgeEnd = nil
 
elseif event == "COMBAT_LOG_EVENT_UNFILTERED" then
    if select(4, ...) == UnitName("player") then
        DEFAULT_CHAT_FRAME:AddMessage(tostring(select(2, ...)).." "..tostring(select(10, ...)).." "..tostring(select(9, ...)).." "..type(select(9, ...)))
    end
    
    if select(2, ...) ~= "SPELL_ENGERGIZE"
    or select(4, ...) ~= UnitName("player")
    or select(9, ...) ~= 27996
    or outfit.spellsurgeEnd then
        return
    end
    
    outfit.spellsurgeEnd = time + 50
    equip = true
 
elseif event == "TIMER" then
    if outfit.spellsurgeEnd 
    and time >= outfit.spellsurgeEnd then
        outfit.spellsurgeEnd = nil
        equip = false
    end
end
Originally posted by Duncanmctung
Thanks for the speedy response!

Unfortunately it isn't working. Is there something I can do to provide you with debug information?

I'm running 4.3b10, and I pasted in the code you posted.
Report comment to moderator  
Reply With Quote
Unread 10-24-08, 08:57 PM  
Duncanmctung
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Spellsurge

Thanks for the speedy response!

Unfortunately it isn't working. Is there something I can do to provide you with debug information?

I'm running 4.3b10, and I pasted in the code you posted.
Report comment to moderator  
Reply With Quote
Unread 10-24-08, 11:05 AM  
WitchKing
A Kobold Labourer
 
WitchKing's Avatar

Forum posts: 0
File comments: 9
Uploads: 0
I'm having trouble with the latest version and Druid form changes. For whatever reason, when I switch into Flight Form, it's equipping my Cat Form gear. Same thing happens when I switch into Aquatic Form. I've tried deleting all outfits and recreating, but it isn't working.

Any ideas?

*Edit: Scratch that. I deleted my saved variables for Outfitter and realized that the problem was most likely because I was creating complete outfits for each form instead of only picking the differences for each outfit from my normal outfit. That seems to have resolved the problem.
Last edited by WitchKing : 10-24-08 at 11:17 AM.
Report comment to moderator  
Reply With Quote
Unread 10-24-08, 02:03 AM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
Re: Re: Re: Spellsurge

Here is, I think, the correct version of the script for Spellsurge:
[code]
Code:
-- $EVENTS PLAYER_ENTERING_WORLD COMBAT_LOG_EVENT_UNFILTERED TIMER
-- $DESC Equips the outfit when the players own Spellsurge procs, then unequips it 50 seconds later

if event == "PLAYER_ENTERING_WORLD" then
    outfit.spellsurgeEnd = nil
 
elseif event == "COMBAT_LOG_EVENT_UNFILTERED" then
    if select(2, ...) ~= "SPELL_ENGERGIZE"
    or select(4, ...) ~= UnitName("player")
    or select(9, ...) ~= 27996
    or outfit.spellsurgeEnd then
        return
    end
    
    outfit.spellsurgeEnd = time + 50
    equip = true
 
elseif event == "TIMER" then
    if outfit.spellsurgeEnd 
    and time >= outfit.spellsurgeEnd then
        outfit.spellsurgeEnd = nil
        equip = false
    end
end
I haven't tested it (again, no Spellsurge here) so let me know how it goes.

Originally posted by Duncanmctung
10/24 02:42:57.127 SPELL_ENERGIZE,GUID,"Duncan",0x511,GUID,"Duncan",0x511,27996,"Spellsurge",0x40,100,0

I replaced the long GUID to make the line fit. =]
Last edited by mundocani : 10-24-08 at 02:04 AM.
Report comment to moderator  
Reply With Quote
Unread 10-24-08, 01:20 AM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
Re: Re: Re: Spellsurge

Excellent, thanks so much!

Originally posted by Duncanmctung
10/24 02:42:57.127 SPELL_ENERGIZE,GUID,"Duncan",0x511,GUID,"Duncan",0x511,27996,"Spellsurge",0x40,100,0

I replaced the long GUID to make the line fit. =]
Report comment to moderator  
Reply With Quote
Unread 10-24-08, 12:57 AM  
Duncanmctung
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Spellsurge

Originally posted by mundocani
... so if someone could give me the exact message that appears in the combat log from a Spellsurge proc ...
10/24 02:42:57.127 SPELL_ENERGIZE,GUID,"Duncan",0x511,GUID,"Duncan",0x511,27996,"Spellsurge",0x40,100,0

I replaced the long GUID to make the line fit. =]
Report comment to moderator  
Reply With Quote
Unread 10-23-08, 12:52 PM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
Re: Spellsurge

This is being caused by the combat log changes from patch 2.4. I don't have a Spellsurge-enchanted weapon to try this with, so if someone could give me the exact message that appears in the combat log from a Spellsurge proc I think I can figure out what events/parameters to have the script look for in order to detect the proc. Thanks!
Originally posted by Duncanmctung
Any chance of a Spellsurge script fix?

I haven't looked at the combat log file to see, but the spell's effect has clearly changed yet again. Now the proc seems to give a direct 100 mana in one shot rather than 10 hits of 10 mana each.

Thanks for all the hard work! This was the first addon I made sure was working once the patch went live. =D
Report comment to moderator  
Reply With Quote
Unread 10-23-08, 10:41 AM  
Duncanmctung
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Spellsurge

Any chance of a Spellsurge script fix?

I haven't looked at the combat log file to see, but the spell's effect has clearly changed yet again. Now the proc seems to give a direct 100 mana in one shot rather than 10 hits of 10 mana each.

Thanks for all the hard work! This was the first addon I made sure was working once the patch went live. =D
Report comment to moderator  
Reply With Quote
Unread 10-23-08, 06:56 AM  
redandgray
A Kobold Labourer

Forum posts: 0
File comments: 5
Uploads: 0
Originally posted by mundocani
Version 4.3b10 Changes

- BUGFIX/HACK: Spell hit optimization should work now (still separate from melee hit, even though they're identical)
- BUGFIX/HACK: Healing optimization recognizes spell power (still separate from spell damage, even though they're now identical)
I would say that spell-hit optimization is still not working, at least not very well. I have spell gear with to-hit, but Outfitter is choosing melee gear with (more) to-hit instead of the spell gear. If Outfitter finds any spell gear with to-hit, regardless of how low the to-hit is, it should take precedence over the melee gear.

Actually, it seems Outfitter is not even choosing spell gear when it's better than the melee gear.

This was tested using 4.3b10.
Report comment to moderator  
Reply With Quote
Unread 10-22-08, 07:33 PM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
I haven't had the problem myself, but I'll look through that part of the code and see if I can spot something. My first guess is that the mount detection might be using the PLAYER_AURAS_CHANGED event, which no longer exists in patch 3.0 so if that's the case then it'll be easy to fix. Not sure why it'd be working for me though.

Originally posted by JMGibson
I tried the newest version and it does work...sometimes...for some reason it will work when I use my land mount but not when I use the flyer, it also does not switch back my main hand when im on my rogue...
Report comment to moderator  
Reply With Quote
Unread 10-22-08, 07:32 PM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
I've heard that Warsong Gulch isn't working correctly, are any others also failing? Are there any in which it's known to work correctly? Also, since that whole thing depends heavily on localization, are you running English or some other language?

Originally posted by Cicero
I can confirm it doesn't work in battlegrounds anymore as of 3.0. The only way to get it to work, in my case since I'm on a PVE server, is by selecting the option to not equip the riding outfit when flagged for PVP.
Report comment to moderator  
Reply With Quote
Unread 10-22-08, 07:30 PM  
mundocani
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 434
Uploads: 6
I know, it's so seriously out of date. I should get an Achievement for "Old school attire" or something though

Originally posted by Tinuviel
Hey mundocani,

Update your screenshot! T1 is so outdated.
Report comment to moderator  
Reply With Quote
Unread 10-22-08, 05:30 PM  
JMGibson
A Deviate Faerie Dragon

Forum posts: 19
File comments: 11
Uploads: 0
I tried the newest version and it does work...sometimes...for some reason it will work when I use my land mount but not when I use the flyer, it also does not switch back my main hand when im on my rogue...
Report comment to moderator  
Reply With Quote
Unread 10-22-08, 05:23 PM  
Cicero
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
I can confirm it doesn't work in battlegrounds anymore as of 3.0. The only way to get it to work, in my case since I'm on a PVE server, is by selecting the option to not equip the riding outfit when flagged for PVP.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.