(2Kb)

Updated: 08-12-08 07:05 PM

Add Favorite

Install Help

Pictures

File Info

Updated:	08-12-08 07:05 PM
Created:	unknown
Downloads:	8,285
Favorites:	22
MD5:

DruidItemSwap

Version: 2.0.3

by: Freki [More]

DruidItemSwap 2.0

What it can do:

Swap to a high spirit weapon for innervate
Swap to your Charm of Swift Flight in Swift Flight Form

Setting it up:

The options can be accessed by typing /dis

As of patch 2.4.3, idol / healing swapping will cease to function. As such, this version of DruidItemSwap is to serve as an efficient Innervate/Swift Flight Form swapping mod. I rewrote the mod from the ground up with simplicity in mind. The options menu is no more, instead replaced by a not as fancy but more "simple" slash command option accessible by "/dis". The options should hopefully be self-explanatory. I addressed the major issues with previous versions, and from what I can tell it's completely bug-free.

Version 2.0.3
-------------
- Functional for WoTLK beta!
- Popup message instead of chat message when requesting user to select innervate item... just to make it more obvious hopefully.
- Added shapeshifting to one of the triggers to swap back to original item in the case that it fails to swap immediately after the buff is gone.
- Fix to prevent the mod from switching back to an earlier equipped item after a swap if you've equipped a different item.

Version 2.0.2
-------------
- Few minor tweaks. Official 2.4.3 release.

Version 2.0.1
------------
- Small fix to prevent an item from switching back if you are casting a spell.

Version 2.0
-----------
NOTE: DruidItemSwap 2.0 will overwrite your previous version, so if you still want to keep using your idol or healing swapping until patch 2.4.3, keep your current version.

As of patch 2.4.3, idol / healing swapping will cease to function. As such, this version of DruidItemSwap is to serve as an efficient Innervate/Swift Flight Form swapping mod. I rewrote the mod from the ground up with simplicity in mind. The options menu is no more, instead replaced by a not as fancy but more "simple" slash command option accessible by "/dis". The options should hopefully be self-explanatory. I addressed the major issues with previous versions, and from what I can tell it's completely bug-free.

Version 1.3.3
-------------
- A few minor changes and fixes; most notably for flight form when going through portals to swap back to your original trinket (finally got swift flight form so I can test these things :D). There is still an issue with swift flight form swapping that I haven't been able to solve; and that is that it sometimes randomly refuses to equip the trinket. A simple "/console reloadui" should solve this problem.
- The primary reason for this update is to inform users of a change in the upcoming patch 2.4.3. From the patch notes: "Equipping an item will now cancel any spell cast currently in progress." I have tested this and can confirm that the two primary features of DruidItemSwap -- healing swapping and idol swapping -- are indeed broken by the change. As such, I will eventually be releasing a feature-stripped version for those who would like a more efficient and less buggy alternative to larger "closet" mods such as ItemRack and ClosetGnome for innervate and swift flight form swapping. That being said, I will not be spending nearly as much time on the mod because this change pretty much destroys DruidItemSwap's primary purpose. So much for that little bit of help for feral/balance druids =/

Version 1.3.2
-------------
- Small fix to ensure weapons swap properly.

Version 1.3.1
-------------
- Added a small countermeasure to prevent your original items from being swapped on abilities that don't cause a global cooldown (e.g. trinkets, nature's swiftness, war stomp)

Version 1.3
-----------
- Added some advanced options. Let me know if you have any requests for other options you'd like to see. You can now:

Choose whether you swap your healing items on lifebloom / rejuvenation (see the new tips in the description below why this is optional)
Enable / disable swift flight form swapping
Choose whether you want your original items to swap back immediately after innervate ends or if you'd rather wait until the next cast (the latter would prevent a global cooldown).

- With regards to requests for form-specific item swapping, I did get this somewhat working, but chose not to include it by default because there would need to be other changes in order for it to be to everyone's satisfaction. If you still want to try it out, you can open DruidItemSwap.lua, and uncomment the lines following line 196 (use Ctrl-G).
- Other small changes such as making the texts more understandable (hopefully) to users not French, English, or German.

Version 1.2.6
----------------
- Fixed a stupid mistake that caused the mod to not recognize your Charm of Swift Flight in your bags. So Swift Flight Form swapping should now finally be operating properly. Sorry that it took so long to fix =/
- Removed feral abilities from idol swapping. It was found that because swapping items resets your swing timer, there was an overall drop in feral DPS.
- Your healing weapon will now swap in when you cast rejuvenation or lifebloom. This will still NOT benefit your first cast, but if you plan on casting more than one HoT in sequence it will benefit your second, third, etc.

Version 1.2.5
----------------
- Fixed swift flight form switching. Hopefully for good this time.
- Other minors changes that should make things work more consistently.

Version 1.2.4
----------------
- Hopefully fixed the problem that caused Charm of Swift Flight to not be equipped when Swift Flight Form was cast.

Version 1.2.3
------------
- No more sound when switching items!
- Put a few countermeasures to prevent the mod from ceasing to work at certain conditions.

Version 1.2.2
----------------
- Localization! Completely translated for French and German, but it should work for any language client as long as you understand some of the English texts.
- Continued in my crusade against bugs and errors. I'm hoping it works flawlessly now, but be sure to let me know of any problems that come up.
- Testing needs to be done to assure switching for shred actually works. If you are able to do this, please let me know your results.

Version 1.2.1
----------------
- Minor fix: hopefully fixed the problem with mangle idols not equipping properly.

Version 1.2
--------------
- Many, many code changes that should hopefully make switching back to your original weapon fail-proof. Of course, all those changes could possibly have created more bugs, so let me know if you run into any problems.
- Innervating another person will no longer equip your innervate weapon.
- You can now set a default idol to switch back to after you've switched idols (if you don't need this, it's fine and even suggested that you don't bother setting a default).
- Fixed the problem that required users to delete their savedvariables file upon updating.
- Can now set idols for your Mangle and Shred abilities! After testing, it was confirmed that Rejuvenation and Lifebloom switching will not work.
- Minor graphical changes to the options menu. Oh, and don't worry that you don't see the flight form swap setting, because DIS takes care of it automatically now (since there's only one trinket that increases flight form speed).

Version 1.1
-----------
Note for people updating from the previous version: You must delete your saved variables file for DruidItemSwap. This can be found at C:\Program Files\World of Warcraft\WTF\Account\[account name]\[realm name]\[character name]\SavedVariables\DruidItemSwap.lua . Also delete the backup, DruidItemSwap.lua.bak . You will have to set up your settings again. I am sorry for the inconvenience.

Updates:
- Flight form trinket swap supported

- Can now enable/disable the mod
- Fixed an issue with idol swapping for healing touch

Optional Files (0)

Comment Options

Page 3 of 5

05-19-08, 12:12 AM
EnSabahNur A Defias Bandit Forum posts: 3 File comments: 55 Uploads: 6	Support more Idols/Spells ? Please can you add support for more Spells and Idols like Lifebloom, Claw, and many more for which Idols exists?

05-15-08, 08:07 PM
reale A Kobold Labourer Forum posts: 1 File comments: 164 Uploads: 0	Thank you I appreciate your time, thank you again. I think the problem was that DIS would activate first and put the trinket on, then my other mod would report the trinket was missing because it couldn't find it in my bags (Baudmount). I also have Baudmount putting the trinket in the second slot to avoid trinket cooldowns in the first one.

05-14-08, 04:04 PM
Freki A Deviate Faerie Dragon Forum posts: 18 File comments: 94 Uploads: 6	@Kendac: I was worried haste might be a problem. Since I'm a PVP boomkin, I don't really need to worry about that. As for a solution, I'm not sure if that will happen anytime soon, as it would be very difficult to make a user-friendly setup just for the purpose of lowering the GCD on moonfire. I will think on it though, and perhaps I'll find a way to make it work. @Reale: Sorry that it breaks your other mod. I have had a request before to disable flight form swap, so I'll try to put it in the next version. To fix it for now, just open up DruidItemSwap.lua with notepad, do a search (ctrl-f) for "DIS.CheckCharm()" and remove it every time you find it (should be in there twice). I'm not quite sure why it would break your other mod though. I'm more willing to blame the other mod, personally

05-14-08, 04:07 AM
reale A Kobold Labourer Forum posts: 1 File comments: 164 Uploads: 0	Flight Form Swap Can you please make the trinket flight form swap an option? It breaks my mod that also handles ground mount trinket. Thank you

05-13-08, 12:41 AM

Kendac

A Kobold Labourer

Forum posts: 0

File comments: 1

Uploads: 0

First off, a huge thanks for all the work you have put into this mod.

I have a little suggestion though, that would make this mod perfect. Atleast in my eyes

My point is, smart people on elitistjerks.com have done a lot of theorycrafting on Moonkin dps and also confirmed an issue occuring to me that arises with idol swapping at high haste levels. It actually even happens on your regular Moonfire casts, given you only use one cast in your rotation and then switch back to casting SF.
The Global Cooldown switching an idol incurs is 1.5 s. The MF CD is the same so no problem there. With haste however you lose the gain you get from haste due to the GCD. This also adds to another latency related bug, which has been confirmed on the elitistjerks.com forum. Therefore I quote:

If you equip the unseen moon idol in a macro with the moonfire spell you get 1.5 sec PLUS YOUR LATENCY in cooldown. This is due to a bug introduced when the /stopcasting system was removed.

You lose more by the bugged duplicate cooldown than you gain by having the starfire idol equipped for the final cast. This is presuming 0 haste. The more haste you get the worse this problem gets.

source: http://elitistjerks.com/f31/t11582-d...readsheet/p56/

So the way to work around this is equiping your MF idol prior to casting MF in your last SF before the MF cast. After your MF you swap back to your SF idol. This way you don't actually lose DPS because of idol swapping.

The easiest way to work around this is probably using a macro of your desired spell rotation and your addon will do the work for you. In most cases the rotation would be 4 SF 1 MF. Threfore the rotation with the idols equiped would look like this (ideally) : SF (SF idol), SF (SF), SF (SF), SF (MF idol), MF (MF).
If you could add the option to add in your spell rotation so that the addon equips the MF idol on the fourth SF cast that would be fantastic.

Kendac, Rajaxx-DE-EU

05-06-08, 11:37 AM

ministoat

A Murloc Raider

Forum posts: 9

File comments: 19

Uploads: 2

Originally posted by Freki

@Ministoat:
Are you trying to use your healing weapon for rejuv/lifebloom? If you wanted to make this change, change line 243 (ctrl-g) to

<33 cheers dude

05-05-08, 03:17 PM
Nandini A Deviate Faerie Dragon Forum posts: 0 File comments: 11 Uploads: 0	I'm considering writing a post for the US Suggestions Forum about idol/totem/libram swapping in-combat. I'd appreciate any feedback readers here might provide. Current behavior: Swapping an item into a character's relic slot during combat resets that character's melee swing timer. Desired behavior: Swapping an item into a character's relic slot during combat does not reset that character's melee swing timer. Rationale: There are no known relics that impact weapon speed or melee haste. Swapping weapons in the main-hand slot (and off-hand slot for dual wielders) obviously must reset the melee swing timers. This case is not obvious for relics and logically should not apply. Relic swapping favors caster/healer talent specs over melee specs. While swapping relics in combat does instantiate a new global cooldown, it only does so if one is not already active. This allows players to begin casting a (non-instant) spell and equip a relic that improves that spell before the spell cast completes. This is most beneficial with spells whose cast times are considerably longer than the current global cooldown (as modified by spell haste). The net effect is typically an increase in damage per second or healing per second for these players. The opposite is true for melee dps talent specs. Although it is still possible to swap in a relic after an ability is used but before the attack is processed on the server, the player will "lose" on average half of a melee autoattack every time the swap is made. The net effect is typically a decrease in damage per second for these players. In fact, the more attack power and critical strike chance a player has, the more a player has to lose by delaying the next auttoattack. Potential confounding factors: The equipment slot used for relics on the druid, shaman, and paladin classes is used for ranged weapons on every other class. Those ranged weapons have their own separate attack speeds. Swapping in a different ranged weapon while in combat necessitates resetting the ranged attack timer. If swapping relics and ranged weapons is handled by the same code, developers might declare it too burdensome to create separate code for relic swapping which does not reset the melee swing timer.

05-05-08, 10:20 AM

Freki

A Deviate Faerie Dragon

Forum posts: 18

File comments: 94

Uploads: 6

@Nandini:
Thanks for the research you've done. I was skeptical about some of the feral swapping, but that was because I wasn't sure if it worked. I wasn't aware that it reset the swing timer. It's hard for me to test for myself when I am balance spec. I think in the future I will more than likely remove the feral abilities from DIS idol swapping due to this information. I appreciate the assistance.

@Ministoat:
Are you trying to use your healing weapon for rejuv/lifebloom? If you wanted to make this change, change line 243 (ctrl-g) to

if (spell == DIS_Local.Regrowth or spell == DIS_Local.HealingTouch or spell == DIS_Local.Tranquility or spell==DIS_Local.Lifebloom or spell==DIS_Local.Rejuvenation) then

05-05-08, 05:26 AM
ministoat A Murloc Raider Forum posts: 9 File comments: 19 Uploads: 2	@frecki..with the edit i made it swapped in the heal wep for a 2nd lifebloom cast, bumping up the whole effect...it does recalculate on the +heal you have with the latest refresh. I don't have the proper lb idol tho, and am too nooby to stop it from swapping back to my feral wep on the next cast also the general EJ consensus is that idol swapping is pretty bad for cat dps due to the swing timer reset..i personally think the feral idol swapping shouldn't be used, since it's of detriment to our dps.

05-05-08, 02:31 AM
Nandini A Deviate Faerie Dragon Forum posts: 0 File comments: 11 Uploads: 0	Lower feral dps when swapping enabled I very much appreciate what this addon is trying to do. However, I was skeptical of missing autoattack swings, so I did some testing. I tested for two periods of 30 minutes each. I exclusively killed the same mobs (level 65 and 66 Clefthoof Bulls in Nagrand). For the first test, I enabled DIS and set my default idol to Everbloom Idol, my mangle idol to Idol of Terror, and my shred idol to Everbloom Idol. For the second test, I disabled DIS and kept Everbloom Idol equipped at all times. I used the following attack sequence: Pounce Mangle Shred Shred again(if Omen of Clarity procced) Ferocious Bite (not needed if I had shredded twice, the mob was already dead) In the first 30 minute test with DIS enbaled, my average dps while in combat was 665.1 dps. The damage breakdown by skill was as follows: Shred: 31.2% Autoattack: 29.7% Mangle: 18.9% Ferocious Bite: 12.5% Pounce Bleed: 7.7% In the second 30 minute test with DIS disabled, my average dps while in combat was 756.2 dps. The damage breakdown by skill was as follows: Shred: 38.6% Autoattack: 32.8% Mangle: 18.1% Ferocious Bite: 6.5% Pounce Bleed: 4% During the first test, I was quite conscious of my shred ability never being ready to use a second time if omen of clarity had procced during my opener. During the second test, I was always able to get that second shred in. On the whole, swapping in Idol of Terror when mangling did give me the nice 120 agility buff almost every time. Overall, I had many more crits with DIS enabled and my average hits were for more damage. However, I appear to have missed many autoattack swings due to idol swapping. You can see that the mobs stayed alive longer, allowing the pounce bleed to do more damage. I more frequently required ferocious bite to finish off the mob due to not getting a second shred in when omen of clarity had procced. Unfortunately, I was able to gain 13.6% more dps just by disabling DIS and keeping my everbloom idol equipped permanently. These considerations might not be as important when doing feral dps on a raid boss. Even with the 2pc T4 set bonus, I usually have to wait for energy to use my next special attack. I can imagine equipping Idol of Terror for mangle, Everbloom Idol for shred, and Idol of Feral Shadows as default for when I finish with rip. However, the higher my AP and crit become, the more losing these autoattacks due to idol swapping could hurt my dps. I can't imagine any raid settings where I could perform a test under the exact same conditions twice, but I'll see what I can do this coming week. In the meantime, thanks for this great addon. It is indeed helpful when I am able to disregard the GCD and my next autoattack, such as when I am casting regrowth or healing touch. I can imagine it has many good uses for resto and balance druids, especially.

05-04-08, 09:53 PM

Freki

A Deviate Faerie Dragon

Forum posts: 18

File comments: 94

Uploads: 6

Originally posted by DesolatedMaggot
A cool thing about Lifebloom, each time you stack the spell it rechecks the +healing bonus. Remember that nerf? Works to our advantage here. Also something I've noticed about Lifebloom, seems it's not treated like your average spell. Perhaps the pvp idols effecting the final, 'bloom', will work with only one application?

Yah, I remember that change. I'm guessing what you're trying to say is that it won't give you the benefit on the first, but will on the second cast of lifebloom? I can see how that might be useful, but there's similar things that are kinda helpful, but I'm going to keep out of the mod for now just because they might confuse people (by making them think they're getting the benefit on any cast of lifebloom when really it's just the second and third). A similar change I've thought of putting in is switching to healing weapon when you cast lifebloom or rejuv, just cuz I know sometimes I'll sit and spam hots and never have my healing weapon equipping seems like a waste. But as I just mentioned, I don't want to give people the impression that it will work on a single cast.

As for your second comment in regards to the gladiator idol, I've wondered that myself. If I get the honor maybe I'll pick up the S1 relic; or maybe someone will be able to test this for us.

05-04-08, 06:03 PM

DesolatedMaggot

A Murloc Raider

Forum posts: 5

File comments: 23

Uploads: 0

Originally posted by Freki
You say you've had success with lifebloom/rejuv. Are you sure it's working as expected? I know it's switch successfully, but is the effect working? I have Harold's Rejuvenating Broach and Idol of the Emerald Queen, and neither effect is working on a switch. Rejuv ticks for 465 with and without a switch, and lifebloom ticks for 113 with and without a switch. [/b]

A cool thing about Lifebloom, each time you stack the spell it rechecks the +healing bonus. Remember that nerf? Works to our advantage here. Also something I've noticed about Lifebloom, seems it's not treated like your average spell. Perhaps the pvp idols effecting the final, 'bloom', will work with only one application?

Last edited by DesolatedMaggot : 05-04-08 at 06:03 PM.

05-04-08, 12:22 PM

Freki

A Deviate Faerie Dragon

Forum posts: 18

File comments: 94

Uploads: 6

Okay. I'm still alive. Working on a new version as we speak. Some replies:

@Dimakan:

1. Flight form trinket switches on/off only if you go from caster for to flying, and vice versa. However, one of the best druid abilities is to shif directly into bird from kitty, for example; or dive in, tunr cat and go stealth before even hitting ground. But in these direct cat/bear <-> flight form shapeshifts trinket doesnt work. It doesnt recognize form change.

I'm working on this bug now. I believe I've fixed it, so hopefully there shouldn't be any problems.

2. Now something weird. I successfully edited lua file to add Lifebloom and Rejuvenation - works like a charm! However, when I try to add any melee attacks - Maul, Swipe, Lacerate, Rip - when I log into WoW DIS empty (!) frame immediately pops up with no weapons or trinkets in it and it does not show that spell slot and anything else below it. Which is puzzling because it does work with Shred and mangle without a problem.

I'm guessing you're trying to use DIS_Local.Maul and such, which if you look in the localization don't exist. Instead, just use "Maul", "Swipe", etc in quotes.

You say you've had success with lifebloom/rejuv. Are you sure it's working as expected? I know it's switch successfully, but is the effect working? I have Harold's Rejuvenating Broach and Idol of the Emerald Queen, and neither effect is working on a switch. Rejuv ticks for 465 with and without a switch, and lifebloom ticks for 113 with and without a switch.

05-03-08, 06:20 PM

dimakan

A Kobold Labourer

Forum posts: 0

File comments: 7

Uploads: 0

Originally posted by ministoat
dimikan, i'd like to know where you edited lua for lb/rejuv..i added them to line 187 but on every 2nd cast i see the weapon swapping back to my normal feral one..kinda spoils the LB stack effect :/

I dont know what line # it is, but here is what the whole section in my file looks like:

DIS.OptionsFrame.AddCategory(DIS_Local.IdolSwap)
DIS.OptionsFrame.AddOption(DIS_Local.DefaultIdol, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Moonfire, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Starfire, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Mangle, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Shred, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Lifebloom, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.Rejuvenation, 3, "INVTYPE_RELIC")
DIS.OptionsFrame.AddOption(DIS_Local.HealingTouch, 3, "INVTYPE_RELIC")

Last edited by dimakan : 05-03-08 at 06:20 PM.

05-02-08, 03:26 PM

DesolatedMaggot

A Murloc Raider

Forum posts: 5

File comments: 23

Uploads: 0

Originally posted by Freki
Hi, thanks for the kind words If you wanted to test these abilities for me, you could add some options in DIS manually and see if idol swapping for them would make any difference. It's pretty easy to do this; just open up DruidItemSwap.lua, go to line 173 (use ctrl-g) and using the above lines as reference, you can create your own options. For example, this for Maul:

DIS.OptionsFrame.AddOption("Maul", 3, "INVTYPE_RELIC")

If you're having any trouble doing this, I can set it up for you and send you a custom version to test. I would test them myself but I have like one feral idol so it's quite impossible for me to do

Giving it a go. Have to re-collect most of these idols though. When the macro thing didn't work I DE'd them for more bag space. So far though adding Maul is a bad idea, since maul doesn't activate any GCD on it's own. Seems to work fine for Swipe however.

Page 3 of 5

Report this File

Category Jump: