MyBags 

Moonstart: Yeah, I had that problem with the last patch, too. It's not MyBags, if you disable all mods (including MyBags) but leave Ace enabled, you still get the error when trying to use a macro from the action bar. I tracked it down using TaintMap (very useful mod, BTW) and the problem is that Ace is stomping on one or more global variables, preventing the macro code from running. Unfortunately, I don't think anyone cares about Ace 1 anymore, so there isn't really anyone to fix it officially.

To fix it myself, I had to edit a few of the Ace files to not use global copies of those functions. Depending on what version of Ace you are currently using the edits might be a little different, but if you start from Ace r26541 from files.wowace.com, the changes are as follows:

Ace.lua line 284
"gfind" change to "string.gmatch"

Ace.lua lines 390 and 391
remove these lines

AceChatCmd.lua lines 47 and 48
"strrep" change to "string.rep"

That worked for me. Hope it helps.

Confirmed and under investigation.

Edit: found and fixed. Version 0.5.9-tg is up for download.

New version! zOMG! Now opens and closes while in combat. Works for me anyway. Please test and leave comments with yay or nay.

Oh, I know what the problem is, it's basically everything I've done since I picked up this project.

The problem is that you can't manually call UseContainerItem() anymore. Lots of things require that I do exactly that, the most important of which is obviously trying to use an item from your bags. The first way I tried to get around that, as was suggested by a blue/green post on the UI /Macros forum, was to make my bag buttons inherit from ContainerFrameItemButton. The plus side to that is it just works. The down side is that you can't then do a conditional click, i.e. "if I'm looking at my own bags then use bag X item Y, but if I'm looking at an alt's bags, don't do anything when I click." Everything looks fine but if you switch to viewing an alt's bags and end up clicking on a slot, you actually pick up or use something from your own bags, which has very bad implications.

The way I found around that was to switch to using secure templates. That let me basically turn off certain aspects of the bag buttons (moving/using items) when you view an alt's bags. It wasn't until later that I realized that you can't show or hide secure buttons once combat starts.

The short answer is that I need to find another way to disable bag buttons conditionally without locking the bags in combat. I'm still banging my head against that part but I think I'm making progress. Given the choice of an annoying but innocuous bug (bags stuck in combat) and an annoying as well as potentially harmful bug (moving/using items you don't want to), I chose the innocuous one.

Anyway, sorry for the 1,000 word essay. Working on it, get back to you.

Yeah, based on the description, that's what it should do. Based on the code, though, that's not what it does.

I played around with the layout code a bit and only managed to make it look worse, but I think I may be able to make it work the way you want if I keep at it. Unfortunately, I think the open/close during combat issue is a slightly higher priority, but I will work on adding a new layout setting that puts each bag on its own row.

It shouldn't cause any new problems. The gfind function was renamed in Lua 5.1.1, so anything that used that function needed to be changed to use its new name, gmatch. The changes are pretty much contained in that one file, though, so any other Ace addons you have shouldn't even notice the difference.