(33Kb)

Updated: 05-25-17 01:14 AM

Add Favorite

Install Help

Compatibility:	Tomb of Sargeras (7.2.0)
Updated:	05-25-17 01:14 AM
Created:	11-24-13 01:19 PM
Downloads:	10,245
Favorites:	15
MD5:

NoTaint UIDropDownMenu

Version: v7.2.0.24015-r3

by: another, arith

About
Standard UIDropDownMenu global functions using protected frames and causing taints when used by third-party addons. But it is possible to avoid taints by using same functionality with that library.
Library checked more than year inside of TinyExtraBars without any taints from menus.

What is it
Library is standard code from Blizzard's files EasyMenu.lua, UIDropDownMenu.lua and UIDropDownMenuTemplates.xml with frames, tables, variables and functions renamed to:

constants (typed with all CAPS): "LIB_" added at the start
functions: "Lib_" added at the start

How to use it (for addon developer)

Add UIDropDownMenu.xml to your toc.
If your addon doesn't embed LibStub, you will need it.
Like ordinal code for UIDropDownMenu with "Lib_" instead.

Constants

LIB_UIDROPDOWNMENU_MINBUTTONS
LIB_UIDROPDOWNMENU_MAXBUTTONS
LIB_UIDROPDOWNMENU_MAXLEVELS
LIB_UIDROPDOWNMENU_BUTTON_HEIGHT
LIB_UIDROPDOWNMENU_BORDER_HEIGHT
LIB_UIDROPDOWNMENU_OPEN_MENU
LIB_UIDROPDOWNMENU_INIT_MENU
LIB_UIDROPDOWNMENU_MENU_LEVEL
LIB_UIDROPDOWNMENU_MENU_VALUE
LIB_UIDROPDOWNMENU_SHOW_TIME
LIB_UIDROPDOWNMENU_DEFAULT_TEXT_HEIGHT
LIB_OPEN_DROPDOWNMENUS

Functions

Lib_EasyMenu
Lib_EasyMenu_Initialize

Lib_UIDropDownMenuDelegate_OnAttributeChanged
Lib_UIDropDownMenu_InitializeHelper
Lib_UIDropDownMenu_Initialize
Lib_UIDropDownMenu_SetInitializeFunction
Lib_UIDropDownMenu_RefreshDropDownSize
Lib_UIDropDownMenu_OnUpdate
Lib_UIDropDownMenu_StartCounting
Lib_UIDropDownMenu_StopCounting
Lib_UIDropDownMenu_CreateInfo
Lib_UIDropDownMenu_CreateFrames
Lib_UIDropDownMenu_AddSeparator
Lib_UIDropDownMenu_AddButton
Lib_UIDropDownMenu_AddSeparator
Lib_UIDropDownMenu_GetMaxButtonWidth
Lib_UIDropDownMenu_GetButtonWidth
Lib_UIDropDownMenu_Refresh
Lib_UIDropDownMenu_RefreshAll
Lib_UIDropDownMenu_SetIconImage
Lib_UIDropDownMenu_SetSelectedName
Lib_UIDropDownMenu_SetSelectedValue
Lib_UIDropDownMenu_SetSelectedID
Lib_UIDropDownMenu_GetSelectedName
Lib_UIDropDownMenu_GetSelectedID
Lib_UIDropDownMenu_GetSelectedValue
Lib_UIDropDownMenuButton_OnClick
Lib_HideDropDownMenu
Lib_ToggleDropDownMenu
Lib_CloseDropDownMenus
Lib_UIDropDownMenu_OnHide
Lib_UIDropDownMenu_SetWidth
Lib_UIDropDownMenu_SetButtonWidth
Lib_UIDropDownMenu_SetText
Lib_UIDropDownMenu_GetText
Lib_UIDropDownMenu_ClearAll
Lib_UIDropDownMenu_JustifyText
Lib_UIDropDownMenu_SetAnchor
Lib_UIDropDownMenu_GetCurrentDropDown
Lib_UIDropDownMenuButton_GetChecked
Lib_UIDropDownMenuButton_GetName
Lib_UIDropDownMenuButton_OpenColorPicker
Lib_UIDropDownMenu_DisableButton
Lib_UIDropDownMenu_EnableButton
Lib_UIDropDownMenu_SetButtonText
Lib_UIDropDownMenu_SetButtonNotClickable
Lib_UIDropDownMenu_SetButtonClickable
Lib_UIDropDownMenu_DisableDropDown
Lib_UIDropDownMenu_EnableDropDown
Lib_UIDropDownMenu_IsEnabled
Lib_UIDropDownMenu_GetValue

Source Repository

If you would like to access the source repository or would like to set external link to your addon project, please use below URL:

svn://svn.wowinterface.com/NoTaint_UIDropDownMenu_Update-1134/trunk

v7.2.0.24015-r3 (2017/05/25)
----------------------------
- Reverted LIB_UIDROPDOWNMENU_MAXBUTTONS back to 8
- Renamed ToC file name
- Added OptionalDeps: LibStub to ToC

v7.2.0.24015-r2 (2017/05/19)
----------------------------
- added version number to EasyMenu
- increased LIB_UIDROPDOWNMENU_MAXBUTTONS to 24
- renamed packaged folder name to !NoTaint_UIDropDownMenu
- No impact to addons which embedded this lib
- For users who installed this lib separately, please remove the old "NoTaint_UIDropDownMenu" folder

v7.2.0.24015 (2017/05/12)
-------------------------
- added UIDropDownMenu.xml;
- removed customized codes in creating buttons;
- removed customized codes in Lib_UIDropDownMenu_AddButton()
- added LibStub to set library's version

v7.2.0.23801-r3 (2017/04/27)
----------------------------
- fixed the loading order in ToC if this get installed separately.

v7.2.0.23801-r2 (2017/04/17)
----------------------------
- ToC update to support proper loading if user install this library separately; this is for WoW 7.2 release.

v7.2.0.23801 (2017/03/22)
--------------------------
- fixed the issue when dropdown menu has more than 1 level

v7.2.0.23789 (2017/03/22)
--------------------------
- lib update to sync with WoW 7.2.0.23789
- TOC update to support WoW 7.2.0

v7.1.0.22908.r7 (2016/12/26)
--------------------------
- fixes with listframe width

v7.1.0.22908.r6 (2016/12/26)
--------------------------
- some minor enhancement in logical operation:
Lib_UIDropDownMenu_AddButton - index's value; width and maxWidth's values

v7.1.0.22908 (2016/10/27)
--------------------------
- Toc update to support WoW 7.1.0
- Codes synch with 7.1.0.22908:
- Added function Lib_UIDropDownMenu_AddSeparator(info, level)

v1.2
----
Updated (thanks to Blazeflack). To use Lib_UIDropDownMenu_AddSeparator left text value empty like

Code:

local tabsSubmenu = {
	{ text = "Add new tab", func = AddNewTab, notCheckable = true, keepShownOnClick = false },
	{ notCheckable = true, notClickable = true },
	{ text = "Remove active tab", func = ConfirmRemoveTab, notCheckable = true, keepShownOnClick = false },
}

1.1
---
Fixed first two menu's strata.

Optional Files (1)

File Name	Version	Size	Author	Date	Type
NoTaint UIDropDownMenu Update	7.2.0.23801	13kB	arith	03-22-17 03:23 AM	Patch

Comment Options

Page 2 of 3

05-15-17, 12:26 AM

arith

A Cyclonian

Forum posts: 45

File comments: 75

Uploads: 35

Originally Posted by Ketho

Originally Posted by arith

Just commit revision 17 to add LibStub and introduce LibStub:NewLibrary to set version number.
Since LibStub has been used, this will need to be loaded after LibStub.
Please test it and let me know if any issue.

Arith, I posted a few errors here since I can't find where I can make tickets
http://www.wowinterface.com/forums/s...5387&page=2#23

I guess curseforge / wowace's .pkgmeta (or says the auto-packaging) doesn't support repository on WowInterface or not support "svn://" protocol.

As for the errors you encountered, please load only UIDropDownMenu.xml to your ToC.

Last edited by arith : 05-17-17 at 12:19 AM.

05-14-17, 11:54 PM

Ketho

A Pyroguard Emberseer

Forum posts: 1026

File comments: 213

Uploads: 52

Originally Posted by arith

Arith, I posted a few errors here since I can't find where I can make tickets
http://www.wowinterface.com/forums/s...5387&page=2#23

05-12-17, 05:13 AM
arith A Cyclonian Forum posts: 45 File comments: 75 Uploads: 35	Just commit revision 17 to add LibStub and introduce LibStub:NewLibrary to set version number. Since LibStub has been used, this will need to be loaded after LibStub. Please test it and let me know if any issue.

05-12-17, 04:32 AM

arith

A Cyclonian

Forum posts: 45

File comments: 75

Uploads: 35

Originally Posted by arith

Originally Posted by Resike

Any chance to add some versioning for the lib like this:

Lua Code:

local version = 3
 
if not Lib_UIDropDownMenu or Lib_UIDropDownMenu.version < version then
    Lib_UIDropDownMenu = { }
    Lib_UIDropDownMenu.version = version
else
    return
end

So an older lib version won't override the functions of the newer ones?

I will try to implement it.

Below codes should do the thing

Lua Code:

local MAJOR_VERSION = "NoTaint_UIDropDownMenu-7.2.0"
local MINOR_VERSION = 90000 + tonumber(("$Rev$"):match("%d+"))
 
local LibStub = _G.LibStub
if not LibStub then error(MAJOR_VERSION .. " requires LibStub.") end
local Lib = LibStub:NewLibrary(MAJOR_VERSION, MINOR_VERSION)
if not Lib then return end

Last edited by arith : 05-12-17 at 04:43 AM.

05-12-17, 04:00 AM

arith

A Cyclonian

Forum posts: 45

File comments: 75

Uploads: 35

Originally Posted by Resike

Any chance to add some versioning for the lib like this:

Lua Code:

local version = 3
 
if not Lib_UIDropDownMenu or Lib_UIDropDownMenu.version < version then
    Lib_UIDropDownMenu = { }
    Lib_UIDropDownMenu.version = version
else
    return
end

So an older lib version won't override the functions of the newer ones?

I will try to implement it.

05-11-17, 04:37 AM
Resike A Pyroguard Emberseer Forum posts: 1290 File comments: 246 Uploads: 12	Any chance to add some versioning for the lib like this: Lua Code: local version = 3 if not Lib_UIDropDownMenu or Lib_UIDropDownMenu.version < version then Lib_UIDropDownMenu = { } Lib_UIDropDownMenu.version = version else return end So an older lib version won't override the functions of the newer ones? Last edited by Resike : 05-11-17 at 04:37 AM.

01-15-17, 10:16 AM

another

A Deviate Faerie Dragon

Forum posts: 11

File comments: 187

Uploads: 12

Originally Posted by Blazeflack

I updated this library with code changes made to the default UIDropDownMenu code.

A commit with the changes can be seen here: http://git.tukui.org/Elv/elvui/commi...98534d31c3a9dc

Nice. There are actually several things like DropDownMenu changed to avoid taint due to shared frames. Glow, PanelTemplates and ChargeCooldown. You can find them as libs in TinyExtraBars

12-10-16, 09:02 PM
Blazeflack A Deviate Faerie Dragon Forum posts: 12 File comments: 18 Uploads: 0	I updated this library with code changes made to the default UIDropDownMenu code. A commit with the changes can be seen here: http://git.tukui.org/Elv/elvui/commi...98534d31c3a9dc

03-21-15, 01:41 PM
Resike A Pyroguard Emberseer Forum posts: 1290 File comments: 246 Uploads: 12	This will be very selfish and lazy, but any chance you could do the same thing with the UnitPopup.lua? :P Also an update would be good, since some stuff changed in the dropdown handlers too.

11-29-13, 02:20 PM

another

A Deviate Faerie Dragon

Forum posts: 11

File comments: 187

Uploads: 12

Originally Posted by Resike

Originally Posted by another

It is called for every new list, i.e. for LIB_UIDROPDOWNMENU_MAXLEVELS at first (on addon load) and if you have more for others on Lib_UIDropDownMenu_CreateFrames.

I'm not sure about that, i think that only gets triggered for multi level dropdowns when the new level should be on top of it's parent level:

What I see from sources it is called for LIB_UIDROPDOWNMENU_MAXLEVELS (2)

Code:

for i = 1, LIB_UIDROPDOWNMENU_MAXLEVELS do
	local listFrameName = "Lib_DropDownList"..i;	
	local f = CreateFrame("Button", listFrameName, nil, "Lib_UIDropDownListTemplate");

and

Code:

function Lib_UIDropDownMenu_CreateFrames(level, index)

	while ( level > LIB_UIDROPDOWNMENU_MAXLEVELS ) do
		LIB_UIDROPDOWNMENU_MAXLEVELS = LIB_UIDROPDOWNMENU_MAXLEVELS + 1;
		local newList = CreateFrame("Button", "Lib_DropDownList"..LIB_UIDROPDOWNMENU_MAXLEVELS, nil, "Lib_UIDropDownListTemplate");
		newList:SetFrameStrata("FULLSCREEN_DIALOG");

So it seems first 2 really created with lowered strata. Hmm. While new UIDropDownMenu.xml creates first 2 lists with frameStrata="FULLSCREEN_DIALOG". I think

Code:

	f:SetFrameStrata("FULLSCREEN_DIALOG");

somewhere at line 27 would fix it.

11-29-13, 07:41 AM

Resike

A Pyroguard Emberseer

Forum posts: 1290

File comments: 246

Uploads: 12

Originally Posted by another

It is called for every new list, i.e. for LIB_UIDROPDOWNMENU_MAXLEVELS at first (on addon load) and if you have more for others on Lib_UIDropDownMenu_CreateFrames.

I'm not sure about that, i think that only gets triggered for multi level dropdowns when the new level should be on top of it's parent level:

Last edited by Resike : 11-29-13 at 07:41 AM.

11-25-13, 05:56 PM

another

A Deviate Faerie Dragon

Forum posts: 11

File comments: 187

Uploads: 12

There is 3 known manuals on DropDownMenu:
WowAce from Xinhuan http://forums.wowace.com/showthread.php?t=15763
WowWiki http://www.wowwiki.com/Using_UIDropDownMenu
wowpedia http://wowpedia.org/Using_UIDropDownMenu

And thats newList:SetFrameStrata("FULLSCREEN_DIALOG") only gets triggered for multi level dropdowns or not?

It is called for every new list, i.e. for LIB_UIDROPDOWNMENU_MAXLEVELS at first (on addon load) and if you have more for others on Lib_UIDropDownMenu_CreateFrames.

Addig this line seems to be good for single level dropdowns, however any chance to dinamically set the strata based on the parent level + 1 strata sublevel or something? Aka the dropdown menu wont overlap higher strata level frames, like tooltips.

It is what Blizzard did. Tooltip strata higher than "FULLSCREEN_DIALOG" (see http://www.wowwiki.com/UITYPE_FrameStrata )

Last edited by another : 11-25-13 at 06:26 PM.

11-25-13, 03:09 PM

Resike

A Pyroguard Emberseer

Forum posts: 1290

File comments: 246

Uploads: 12

Originally Posted by another

Originally Posted by Resike

Using this solves the problem:

Lua Code:

<Button name="Lib_UIDropDownListTemplate" hidden="true" frameStrata="FULLSCREEN_DIALOG" enableMouse="true" virtual="true">

Original

Code:

<Button name="UIDropDownListTemplate" hidden="true" frameStrata="DIALOG" enableMouse="true" virtual="true">

Modified

Code:

<Button name="Lib_UIDropDownListTemplate" hidden="true" frameStrata="DIALOG" enableMouse="true" virtual="true">

Both have DIALOG strata. And when you make

Code:

function Lib_ToggleDropDownMenu(level, value, dropDownFrame, anchorName, xOffset, yOffset, menuList, button, autoHideDelay)
	if ( not level ) then
		level = 1;
	end
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes-level", level);
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes-index", 0);
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes", true);

that should call

Code:

function Lib_UIDropDownMenuDelegate_OnAttributeChanged (self, attribute, value)
	if ( attribute == "createframes" and value == true ) then
		Lib_UIDropDownMenu_CreateFrames(self:GetAttribute("createframes-level"), self:GetAttribute("createframes-index"));

and

Code:

function Lib_UIDropDownMenu_CreateFrames(level, index)

	while ( level > LIB_UIDROPDOWNMENU_MAXLEVELS ) do
		LIB_UIDROPDOWNMENU_MAXLEVELS = LIB_UIDROPDOWNMENU_MAXLEVELS + 1;
		local newList = CreateFrame("Button", "Lib_DropDownList"..LIB_UIDROPDOWNMENU_MAXLEVELS, nil, "Lib_UIDropDownListTemplate");
		newList:SetFrameStrata("FULLSCREEN_DIALOG");

so it should set FULLSCREEN_DIALOG strata. Am I miss something?

This is my dropdown script when i click on the menu button:

Lua Code:

if _G["Lib_DropDownList1"]:IsVisible() and LIB_UIDROPDOWNMENU_OPEN_MENU == self:GetParent() then
    Lib_CloseDropDownMenus()
else
    Lib_UIDropDownMenu_Initialize(self:GetParent(), PowaAurasOptions.DropDownMenu_Initialize)
    Lib_ToggleDropDownMenu(nil, nil, self:GetParent())
    PlaySound("igMainMenuOptionCheckBoxOn")
end

And thats newList:SetFrameStrata("FULLSCREEN_DIALOG") only gets triggered for multi level dropdowns or not?

Edit:

Lua Code:

local Lib_UIDropDownMenuDelegate = CreateFrame("Frame")
for i = 1, LIB_UIDROPDOWNMENU_MAXLEVELS do
    local listFrameName = "Lib_DropDownList"..i
    local f = CreateFrame("Button", listFrameName, nil, "Lib_UIDropDownListTemplate")
    f:SetFrameStrata("FULLSCREEN_DIALOG") -- THIS
    f:SetID(i)
    f:SetSize(180, 10)
    local fontName, fontHeight, fontFlags = _G["Lib_DropDownList1Button1NormalText"]:GetFont()
    LIB_UIDROPDOWNMENU_DEFAULT_TEXT_HEIGHT = fontHeight
    for j = 1, LIB_UIDROPDOWNMENU_MAXBUTTONS do
        local b = CreateFrame("Button", listFrameName.."Button"..j, f, "Lib_UIDropDownMenuButtonTemplate")
        b:SetID(j)
    end
end

Last edited by Resike : 11-25-13 at 03:27 PM.

11-25-13, 02:48 PM

another

A Deviate Faerie Dragon

Forum posts: 11

File comments: 187

Uploads: 12

Originally Posted by Resike

Using this solves the problem:

Lua Code:

<Button name="Lib_UIDropDownListTemplate" hidden="true" frameStrata="FULLSCREEN_DIALOG" enableMouse="true" virtual="true">

Original

Code:

<Button name="UIDropDownListTemplate" hidden="true" frameStrata="DIALOG" enableMouse="true" virtual="true">

Modified

Code:

<Button name="Lib_UIDropDownListTemplate" hidden="true" frameStrata="DIALOG" enableMouse="true" virtual="true">

Both have DIALOG strata. And when you make

Code:

function Lib_ToggleDropDownMenu(level, value, dropDownFrame, anchorName, xOffset, yOffset, menuList, button, autoHideDelay)
	if ( not level ) then
		level = 1;
	end
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes-level", level);
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes-index", 0);
	Lib_UIDropDownMenuDelegate:SetAttribute("createframes", true);

that should call

Code:

function Lib_UIDropDownMenuDelegate_OnAttributeChanged (self, attribute, value)
	if ( attribute == "createframes" and value == true ) then
		Lib_UIDropDownMenu_CreateFrames(self:GetAttribute("createframes-level"), self:GetAttribute("createframes-index"));

and

Code:

function Lib_UIDropDownMenu_CreateFrames(level, index)

	while ( level > LIB_UIDROPDOWNMENU_MAXLEVELS ) do
		LIB_UIDROPDOWNMENU_MAXLEVELS = LIB_UIDROPDOWNMENU_MAXLEVELS + 1;
		local newList = CreateFrame("Button", "Lib_DropDownList"..LIB_UIDROPDOWNMENU_MAXLEVELS, nil, "Lib_UIDropDownListTemplate");
		newList:SetFrameStrata("FULLSCREEN_DIALOG");

so it should set FULLSCREEN_DIALOG strata. Am I miss something?

11-25-13, 11:56 AM

Resike

A Pyroguard Emberseer

Forum posts: 1290

File comments: 246

Uploads: 12

Originally Posted by another

Originally Posted by Resike

I have an issues, for some reason my opened menus shows under my frames, makes them impossible to click.

I think if your addon less than DBM you can PM link to changed sources (to skip at least renaming part) and I'll look what is wrong. Are you using easymenu stuff or making menu yourself?

Eidt: Sounds like menu STRATA less than frame's strata. And if

Code:

function Lib_UIDropDownMenu_CreateFrames(level, index)

	while ( level > LIB_UIDROPDOWNMENU_MAXLEVELS ) do
		LIB_UIDROPDOWNMENU_MAXLEVELS = LIB_UIDROPDOWNMENU_MAXLEVELS + 1;
		local newList = CreateFrame("Button", "Lib_DropDownList"..LIB_UIDROPDOWNMENU_MAXLEVELS, nil, "Lib_UIDropDownListTemplate");
		newList:SetFrameStrata("FULLSCREEN_DIALOG");

called properly strata of your menu should be FULLSCREEN_DIALOG (highest)

Yeah i checked that first too.
No easymenus, i build it myself.

Lua Code:

<Frame name = "PowaBarConfigFrame" movable = "true" parent = "UIParent" frameStrata = "DIALOG" toplevel = "true" hidden = "true" enableMouse = "true" enableKeyboard = "true">

If i set frameStrata = "HIGH", then its visible, if higher then not.

Only wondering because its working fine with the default templates with above "HIGH" strata too.

This is how it's looks like:

Edit:

Using this solves the problem:

Lua Code:

<Button name="Lib_UIDropDownListTemplate" hidden="true" frameStrata="FULLSCREEN_DIALOG" enableMouse="true" virtual="true">

Last edited by Resike : 11-25-13 at 12:12 PM.

Page 2 of 3

Report this File

Category Jump: