Download
(15 Kb)
Download
Updated: 05-25-13 10:49 PM
Patch for:
FaceShooter.
Compatibility:
Escalation (5.3)
Updated:05-25-13 10:49 PM
Created:05-25-13 10:49 PM
Downloads:766
Favorites:0
MD5:
Faceshooter blink fix 5.3
Version: 5.3
by: dwil [More]
Fix that seem to work at removing blink from rotation without breaking everything else as far as I can see.

Put the 2 files in main Faceshooter folder replacing the 2 old files.
Post A Reply Comment Options
Unread 02-10-14, 08:57 AM  
Kramarz
A Kobold Labourer

Forum posts: 0
File comments: 193
Uploads: 0
nice!

damn, so nice to see there are more faceshooter lovers out there!

took me a while to find those fixes for blink strikes, thanks!
Kramarz is offline Report comment to moderator  
Reply With Quote
Unread 12-14-13, 09:18 AM  
Alkayder
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 6
Uploads: 1
Originally Posted by tiggys627
Originally Posted by Alkayder
Yeah, I've uploaded it with the fixes below last night.

You can find it here ==> http://www.wowinterface.com/download...atch5.4.1.html
Awesome Thank you so much. That was very simplified!
No worries, glad to be able to put back into the community that has given me so much.
Alkayder is offline Report comment to moderator  
Reply With Quote
Unread 12-12-13, 03:40 PM  
tiggys627
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by Alkayder
Yeah, I've uploaded it with the fixes below last night.

You can find it here ==> http://www.wowinterface.com/download...atch5.4.1.html
Awesome Thank you so much. That was very simplified!
tiggys627 is offline Report comment to moderator  
Reply With Quote
Unread 12-11-13, 12:02 AM  
Alkayder
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 6
Uploads: 1
Yeah, I've uploaded it with the fixes below last night.

You can find it here ==> http://www.wowinterface.com/download...atch5.4.1.html
Alkayder is offline Report comment to moderator  
Reply With Quote
Unread 12-10-13, 10:12 AM  
foomachi
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Re: Re: Glaive toss

Originally Posted by foomachi
Originally Posted by tiggys627
The version I have apparently has glaive toss not included. Can anyone tell me how to add it back in. I am quite a layman with Lua so i need it simplified.
The files put up with the fix for blink strike unofortunately also removed Glaive Toss, Power Shot, and Barrage. The easiest way to fix this would be to go back to the most recent posted version (which has the broken Blink Strike), and then remove just the Blink Strike code.

Once I have a chance to try it out, I can either post instructions (there aren't that many changes necessary), or see if I can upload files.
Oops, looks like Tygerlilly has already posted instructions for removing BS...
foomachi is offline Report comment to moderator  
Reply With Quote
Unread 12-10-13, 10:06 AM  
foomachi
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Re: Glaive toss

Originally Posted by tiggys627
The version I have apparently has glaive toss not included. Can anyone tell me how to add it back in. I am quite a layman with Lua so i need it simplified.
The files put up with the fix for blink strike unofortunately also removed Glaive Toss, Power Shot, and Barrage. The easiest way to fix this would be to go back to the most recent posted version (which has the broken Blink Strike), and then remove just the Blink Strike code.

Once I have a chance to try it out, I can either post instructions (there aren't that many changes necessary), or see if I can upload files.
foomachi is offline Report comment to moderator  
Reply With Quote
Unread 12-04-13, 01:44 AM  
tiggys627
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Glaive toss

The version I have apparently has glaive toss not included. Can anyone tell me how to add it back in. I am quite a layman with Lua so i need it simplified.
tiggys627 is offline Report comment to moderator  
Reply With Quote
Unread 10-27-13, 03:43 PM  
Kharthus
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 230
Uploads: 6
More fixes for 5.4

The focus costs have also changed since 5.0 for Serpent Sting and Arcane shot. Here are the final two fixes:

Arcane Shot
Line 780: self.focus = self.focus - 15
Line 782: self.focus = self.focus - 30

Serpent Sting
Line 797: self.focus = self.focus - 8
Line 799: self.focus = self.focus - 15
Kharthus is offline Report comment to moderator  
Reply With Quote
Unread 06-13-13, 03:57 PM  
Tygerlilly
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
If you comment out references to BS (Blink Strike) using the latest version of Faceshooter_Functions.lua and Faceshooter_Events.lua everything will work correctly. I believe Dwil's modifications are to the version prior to the addition of Glaive Toss, which is why it does not show in the rotation.

Unfortunately I cannot copy and paste the entire file but these are the lines I commented out in Faceshooter_Functions.lua:

line 446 --start, duration = GetSpellCooldown(FS.spellID["BS"])
line 447 --if (start + duration) == gcd then self.cooldowns["BS"] = 0
line 448 --else self.cooldowns["BS"] = start + duration
line 449 --end

line 692 --elseif spell == GetSpellInfo(FS.spellID["BS"]) then
line 693 --self.cooldowns["BS"] = self.now + 20

line 1138 -- elseif FS.talents["BS"] and UnitExists("pet") and not UnitIsDead("pet") and self.cooldowns["BS"] <= self.now then
line 1139 -- spell = FS.spellID["BS"]

line 1186 -- elseif FS.talents["BS"] and UnitExists("pet") and not UnitIsDead("pet") and self.cooldowns["BS"] <= self.now then
line 1187 -- spell = FS.spellID["BS"]

line 1237 -- elseif FS.talents["BS"] and UnitExists("pet") and not UnitIsDead("pet") and self.cooldowns["BS"] <= self.now then
line 1238 -- spell = FS.spellID["BS"]

And here are the lines I commented out in Faceshooter_Events.lua:

line 113 --spell == GetSpellInfo(FS.spellID["BS"]) or

line 203 --spell == GetSpellInfo(FS.spellID["BS"]) or

Note: If you do not see any references to GT (Glaive Toss) in the either file, you have an older version.

For example, here is function FS:GetTalents() from the newest version:

function FS:GetTalents()
-- Find out which talents are available to the player
self.talents = {}
local _, _, _, _, curr = GetTalentInfo(11)
self.talents["DB"] = curr -- Dire Beast
local _, _, _, _, curr = GetTalentInfo(13)
self.talents["AMoC"] = curr -- A Murder of Crows
local _, _, _, _, curr = GetTalentInfo(14)
self.talents["BS"] = curr -- Blink Strike
local _, _, _, _, curr = GetTalentInfo(15)
self.talents["LR"] = curr -- Lynx Rush
local _, _, _, _, curr = GetTalentInfo(16)
self.talents["GT"] = curr -- Glaive Toss
local _, _, _, _, curr = GetTalentInfo(17)
self.talents["PS"] = curr -- Powershot
local _, _, _, _, curr = GetTalentInfo(18)
self.talents["BRG"] = curr -- Barrage

This is function FS:GetTalents() from the older file:

function FS:GetTalents()
-- Find out which talents are available to the player
self.talents = {}
local _, _, _, _, curr = GetTalentInfo(11)
self.talents["DB"] = curr -- Dire Beast
local _, _, _, _, curr = GetTalentInfo(13)
self.talents["AMoC"] = curr -- A Murder of Crows
local _, _, _, _, curr = GetTalentInfo(14)
self.talents["BS"] = curr -- Blink Strike
local _, _, _, _, curr = GetTalentInfo(15)
self.talents["LR"] = curr -- Lynx Rush

Hope this helps!
Tygerlilly is offline Report comment to moderator  
Reply With Quote
Unread 06-08-13, 12:01 AM  
Tygerlilly
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Re: Re: Glaive toss

Originally Posted by dwil
Originally Posted by tators
Hi and thank you for the patch.
only problem i am having now is that it does not show Glaive Toss in the rotation since applying it.
I cant remember seeing Glaive Toss before either (dont think it ever was in Faceshooter )

Removing stuff I could do, dont feel confident about adding stuff
Glaive Toss is included in version 1.1.2 of Faceshooter. Your fix for blink strike does remove blink strike from the rotation (thank you!), but for some reason the fix also prevents Glaive Toss from showing up in the rotation. I am no lua expert, but I may play around a bit with the code to see if anything jumps out.
Tygerlilly is offline Report comment to moderator  
Reply With Quote
Unread 06-06-13, 09:08 PM  
dwil
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 5
Uploads: 1
Re: Glaive toss

Originally Posted by tators
Hi and thank you for the patch.
only problem i am having now is that it does not show Glaive Toss in the rotation since applying it.
I cant remember seeing Glaive Toss before either (dont think it ever was in Faceshooter )

Removing stuff I could do, dont feel confident about adding stuff
dwil is offline Report comment to moderator  
Reply With Quote
Unread 05-29-13, 11:08 AM  
tators
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Glaive toss

Hi and thank you for the patch.
only problem i am having now is that it does not show Glaive Toss in the rotation since applying it.
tators is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: