Download
(21 Kb)
Download
Updated: 01-16-13 02:05 AM
Compatibility:
Landfall (5.1)
Updated:01-16-13 02:05 AM
Created:09-06-12 04:08 PM
Downloads:1,097
Favorites:6
MD5:
Categories:RolePlay, Music Mods, Mounts & Pets
Pet Battle Music
Version: 1.2
by: Choonstertwo [More]
1.2 is here!
Version 1.2 has finally been released. This version now includes optional separate music for different battle types (e.g. wild, NPC, PvP).

See music.lua for instructions on adding music and config.lua to configure the AddOn.


Description
This AddOn simply plays custom music (like Pokemon music) during pet battles. To add tracks, follow the instructions in music.lua.

For copyright reasons I can't distribute any Pokemon music with this AddOn, but if you know of some suitable music with a permissive licence (or in the public domain), just leave a comment on Curse or WoW Interface and I'll see if I can package it with future releases.

For the latest alpha versions, check CurseForge. API documentation for AddOn authors can be found here.

CAUTION: The included Populate_Music scripts will completely overwrite your existing music.lua file! Make sure you back up any manual changes you make.
tag 1.2
b72ed7fc595cded5c4b19dc8efcf6a863c383733
Choonster <Choonster.2010@gmail.com>
2013-01-12 22:09:01 +1100

Tagging as 1.2

--------------------

Choonster:
- Victory/defeat music will now stop playing when
... you enter a new battle.
- Updated music.lua with the new instructions.
- Removed libraries from TOC/.pkgmeta
-- We're using animation objects instead of AceTimer now
- Added support for Ogg files to the scripts.
- Replaced README.txt with README.md (for GitHub)
- Updated TOC Interface number.
- Added support for separate music tables
-- Most public API functions now take a music table name as their first
argument.
-- The script part files are now numbered to support easy construction
of music.lua using for loops.
- Moved settings from core.lua to a new config.lua file.
-- Added a :GetOptionValue() method to the API to get the value of
options set in config.lua
- More documentation changes
- Changed .docmeta format
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Author
Date
1.1
24kB
Choonstertwo
09-07-12 06:15 PM
1.0
19kB
Choonstertwo
09-06-12 04:08 PM


Post A Reply Comment Options
Unread 03-30-13, 10:07 AM  
Estelyen
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Re: Re: Unmute music

Originally Posted by Choonstertwo
That's quite odd. I'll have to see if I can narrow down the cause of that.
In the meantime I tried setting it the config.lua file to "Master" instead, now it's totally screwed up: Sometimes at the end of a pet battle, my victory music does not play and it doesn't show the sequence of my pets being healed a little and gaining EXP; the game jumps right out of the pet battle the second the last enemy pet dies (my pets DO get healed, gain EXP and level up, it just doesn't show the sequence). My custom pet battle music will keep on playing when that happens and the default background music is muted. I have to log off WoW and log back in to stop the music playing. I set the config.lua back to "SFX" thinking "Master" might just be even more broken, but since then, it keeps happening from time to time even on "SFX". I'm afraid to try out "Ambient" next because it might be screwed up even further

I'm not even sure if it isn't a bug with the pet battles themselves rather than with your addon, because it doesn't even show the usual "after-the-fight-sequence"; it just happened the first time when I set it to "Master".

Anyways, whatever causes these issues, it definitely happens at the end of a pet battle. I'm using BattlePetCount and PetLeash, maybe there's a conflict with one of these?

EDIT: Also, it appears that the problem I posted back in october is still there.
Originally Posted by Estelyen
If I get a dungeon invite while in the middle of a pet battle, the normal background music for the instance will play once and then the game changes back to the Pet Battle Music. Even if I leave the instance, the pet battle music will "butt in" again and again when a normal background music track ends.
Maybe the two are related? In one case the music doesn't stop playing despite the fact that the battle is over, in the other it keeps playing although the fight has been interrupted. I don't know anything about writing WoW Addons, but couldn't you just include a bit of code that checks every few seconds or so if the player is still in a Pet Battle and reverses the music back to normal if it returns false? As a workaround I mean, until you can nail down the true reason and fix it

EDIT 2: So, it's been a month now since I reported it... Any luck in finding the issue at all?
Last edited by Estelyen : 04-30-13 at 01:24 AM.
Estelyen is offline Report comment to moderator  
Reply With Quote
Unread 03-30-13, 08:40 AM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
Re: Unmute music

Originally Posted by Estelyen
Hi there! I've just picked up pet battling again after having ignored it since patch 5.1 (don't even know why I stopped :P). So I tried the new version of your addon, I really like being able to have different music for different events, good work!
The problem is that most of the time, the addon will leave the default WoW background music muted after a pet battle. I know I could get around that by changing the channel in the config.lua to "music", but I don't want that since it'll cut off my victory music before it's finished with the default background music starting up too early.
That's quite odd. I'll have to see if I can narrow down the cause of that.
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 03-26-13, 09:24 AM  
Estelyen
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Unmute music

Hi there! I've just picked up pet battling again after having ignored it since patch 5.1 (don't even know why I stopped :P). So I tried the new version of your addon, I really like being able to have different music for different events, good work!
The problem is that most of the time, the addon will leave the default WoW background music muted after a pet battle. I know I could get around that by changing the channel in the config.lua to "music", but I don't want that since it'll cut off my victory music before it's finished with the default background music starting up too early.
Estelyen is offline Report comment to moderator  
Reply With Quote
Unread 01-16-13, 02:12 AM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
1.2

I released version 1.2 to Curse a few days ago, but I forgot to upload it to WoWI until now (because I use Curse's repository/packager system).

Version 1.2 includes separate music for different battle types (e.g. wild, NPC, PvP) and compatibility for Windows 8 in the two Windows scripts.
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 12-18-12, 05:57 PM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
Re: Re: Re: Very nice Addon

Originally Posted by ZeroEdgeir
Given I think Blizzard even has it setup now to use certain tracks of their music for Tamer/Hard battles vs wild battles, and it has it's own victory music track (even if it is only about 2-3 seconds long), everything seems to exist.

Maybe make it so we can make the editable choice of 1 or more tracks for each situation.
I've already got an update with separate music for most different battle types in the works. It's mostly done, I just need to finish testing it.
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 12-18-12, 10:58 AM  
ZeroEdgeir
A Defias Bandit

Forum posts: 3
File comments: 14
Uploads: 0
Re: Re: Very nice Addon

Originally Posted by Choonstertwo
Originally Posted by Tonyleila
Is there any way to enable the music if its disable in ingame options? I only want pet battle music no wow music

Also Victory music and different music for battles against trainers or wild pets woud be nice!
I use this Pokemon sounds maybe this will help you
http://downloads.khinsider.com/game-...und-collection
Victory music should definitely possible, as should using a different sound channel to play the music on. Different music for wild/trainer battles may be possible.

Would you want randomised victory music or just a single track?
Given I think Blizzard even has it setup now to use certain tracks of their music for Tamer/Hard battles vs wild battles, and it has it's own victory music track (even if it is only about 2-3 seconds long), everything seems to exist.

Maybe make it so we can make the editable choice of 1 or more tracks for each situation.
ZeroEdgeir is offline Report comment to moderator  
Reply With Quote
Unread 10-25-12, 11:36 AM  
Estelyen
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Battle Music just goes on forever

If I get a dungeon invite while in the middle of a pet battle, the normal background music for the instance will play once and then the game changes back to the Pet Battle Music. Even if I leave the instance, the pet battle music will "butt in" again and again when a normal background music track ends.
Estelyen is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 12:00 PM  
Tonyleila
A Frostmaul Preserver
 
Tonyleila's Avatar
AddOn Author - Click to view AddOns

Forum posts: 287
File comments: 1243
Uploads: 31
Re: Re: Very nice Addon

Originally Posted by Choonstertwo
Originally Posted by Tonyleila
Is there any way to enable the music if its disable in ingame options? I only want pet battle music no wow music

Also Victory music and different music for battles against trainers or wild pets woud be nice!
I use this Pokemon sounds maybe this will help you
http://downloads.khinsider.com/game-...und-collection
Victory music should definitely possible, as should using a different sound channel to play the music on. Different music for wild/trainer battles may be possible.

Would you want randomised victory music or just a single track?
just a single track woud be great
__________________
Author of: LeilaUI and Aurora: Missing Textures
__________________
Tonyleila is offline Report comment to moderator  
Reply With Quote
Unread 10-05-12, 06:55 AM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
Re: Very nice Addon

Originally Posted by Tonyleila
Is there any way to enable the music if its disable in ingame options? I only want pet battle music no wow music

Also Victory music and different music for battles against trainers or wild pets woud be nice!
I use this Pokemon sounds maybe this will help you
http://downloads.khinsider.com/game-...und-collection
Victory music should definitely possible, as should using a different sound channel to play the music on. Different music for wild/trainer battles may be possible.

Would you want randomised victory music or just a single track?
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 09-30-12, 08:00 PM  
Tonyleila
A Frostmaul Preserver
 
Tonyleila's Avatar
AddOn Author - Click to view AddOns

Forum posts: 287
File comments: 1243
Uploads: 31
Very nice Addon

Is there any way to enable the music if its disable in ingame options? I only want pet battle music no wow music

Also Victory music and different music for battles against trainers or wild pets woud be nice!
I use this Pokemon sounds maybe this will help you
http://downloads.khinsider.com/game-...und-collection
__________________
Author of: LeilaUI and Aurora: Missing Textures
__________________
Last edited by Tonyleila : 09-30-12 at 08:06 PM.
Tonyleila is offline Report comment to moderator  
Reply With Quote
Unread 09-26-12, 05:32 AM  
Mittparadox
A Deviate Faerie Dragon
 
Mittparadox's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 18
Uploads: 5
Thanks. now i can have my epic Final Fantasy music when fighting with pets.

best song for this: http://ge.tt/4mhf3gP/v/1

should have victory music to, so i can add this: http://ge.tt/1bIRzOG/v/0

__________________
(`. "How do you prove that you exist... ? .)
(`._.[ Mabe we don't exist ... " ]._.)
Mittparadox is offline Report comment to moderator  
Reply With Quote
Unread 09-07-12, 06:24 PM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
1.1

I've just released version 1.1, which removes the debugging code and adds a new public API for AddOn developers.

See the changelog on Curse for more detail.
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 09-07-12, 11:26 AM  
Choonstertwo
A Theradrim Guardian
 
Choonstertwo's Avatar
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 61
Uploads: 28
Originally Posted by Nidra
I love this addon <3
However, you should have the prints in chat off if you start a fight.
--print(debugprofilestop(), "Event:", event)
--print(debugprofilestop(), "PBM: TimeDiff", diff)
--print(debugprofilestop(), "PBM: PlayMusic", trackInfo[1], trackInfo[2])
Yeah, I forgot to remove the debugging code before uploading it. I'm releasing a new version very soon with a few minor fixes, including the removal of the debugging code.
Choonstertwo is offline Report comment to moderator  
Reply With Quote
Unread 09-07-12, 01:50 AM  
Nidra
A Kobold Labourer

Forum posts: 0
File comments: 36
Uploads: 0
I love this addon <3
However, you should have the prints in chat off if you start a fight.
--print(debugprofilestop(), "Event:", event)
--print(debugprofilestop(), "PBM: TimeDiff", diff)
--print(debugprofilestop(), "PBM: PlayMusic", trackInfo[1], trackInfo[2])
Nidra is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: