(168Kb)

Updated: 12-28-10 03:41 PM

Patch for:
HandyNotes.

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	12-28-10 03:41 PM
Created:	12-14-10 08:13 AM
Downloads:	3,247
Favorites:	16
MD5:

HandyNotes (tempfix)

Version: 1.1.6c

by: Isharra [More]

The official HandyNotes release is out! It is version 1.2.0 so there should be no confusion when you upgrade. And please do go back to the official HandyNotes! I hope this addon helped you out.

All current work on the tempfix is halted.

This is a temporary patch for HandyNotes to work around the problems I was seeing with WoW patch 4.0.3a. The original HandyNotes 1.1.6 is available on Curse and WowInterface.

Cladhaire's changes to TomTom were incorporated so that Astrolabe 1.0 is used. This means that additional HandyNotes addons still need to be fixed separately if they call Astrolabe 0.4 themselves (see below.) If it works, Cladhaire deserves all the credit.

There is another attempt at a workaround HandyNotes (fanupdate) while it didn't solve my problem it should still work with the other HandyNotes addons as it was using Astrolabe-0.4 last I checked.

This is not intended as a fork in the codebase, just a workaround until the base addon is updated by the author.

Use /handynotes to access options.

You can add notes to the maps in 3 ways:

Alt-RightClick on the world map to add a note.
Use "/hnnew" without the quotes to add a note at your current location.
Use "/hnnew x,y" without the quotes to add a note at location x,y on your current zone's map.

The additional HandyNotes_* plugins won't work with this tempfix without being modified. Using these instructions with the official HandyNotes 1.1.6 won't work either. The FAQ changes should work with HandyNotes 1.2.0 when it's released as it will use Astrolabe-1.0.

See the FAQ for instructions on how to modify your HandyNotes_* plugins that aren't working.

Download the latest versions of SilverDragon, HandyNotes_Trainers, HandyNotes_Vendors and HandyNotes_Guild. They have been updated to work with HandyNotes 1.2.0.

Minimal testing with HandyNotes_SpecialNPCsEtc, HandyNotes_Charon and HandyNotes_Mailboxes since I don't use them normally but they load without error and seem to be adding the icons properly. HandyNotes_Mailboxes (tempfix) I've uploaded since I had to test the compat function changes required to support it.

rev 1.1.6c added "compat.IconsOnEdge = Astrolabe.IconsOnEdge" to hopefully fix icon on edge problem with the minimap.

rev 1.16b add functions to compat section to support HandyNotes_Mailboxes

rev 1.16a update Astrolabe-1.0 to r125

rev 1.16 initial release - Astrolabe-1.0 r123

Comment Options

Page 3 of 5

12-27-10, 07:10 AM
dch48 A Kobold Labourer Forum posts: 0 File comments: 5 Uploads: 0	I deleted everything pertaining to handynotes from all of my characters before I installed your fixed version. Maybe it's a difference caused by different Windows versions? I'm running 32 bit XP Professional on an AMD Turion64 single core based laptop wth 2 gigs of RAM. The only thing that doesn't work right is changing the notes and that's really no big deal as long as I'm able to create the notes now and have then stay where they're created.. I only use the addon to mark spawn points of rare beasts I want to tame. I've never used any of the other features or plugins. I do not use that Addon Control Panel though Last edited by dch48 : 12-27-10 at 07:12 AM.

12-26-10, 08:02 PM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Originally posted by Sariktor
I don't have this issue with the v1.16 tempfix. Isharra, if you would like a copy of my version, just PM me with where to send it or I could put it on my webserver for you to download.

I can't reproduce this problem with any of the copies I uploaded so I'm unsure what sending me a different version that also doesn't error would do. But thank you for the offer!

dch48, I downloaded what I think matches your addon set. See list below. I still can not reproduce your problem. [bangs head against wall]

Do me a favor. Exit the game and delete the copy of HandyNotes that's in your addons directory and reinstall it. Then move your WTF/Account/<accountname>/SavedVariables/HandyNotes.lua someplace safe and enter the game and see if the errors still occur for you. If it does please let me know and I'll try and make a debugging version for you.

If everything works with a clean setup then you can log out your character and then copy back your safe copy of the SavedVariables file. Check that it still works. (Sometimes the data file can become corrupted.)

This is what I used:

Addon Control Panel 3.3.12
Atlas 1.18.0
Atlas Loot Enhanced 6.01.02
AuctionLite 1.7.4
Critline 3.1.3
Deadly Boss Mods 4.70-r4833
Deadly Boss Mods - Vanilla and BC mods v4-r215
HandyNotes (tempfix) 1.16b
Omen3 3.1.0
Power Auras Classic 4.9
Recount 4.0.1d
Titan Panel 5.0.1.40000
Apologies for the Curse.com links but I had them bookmarked previously.

Originally posted by dch48
Edit:--On log in today, the icons are showing in Hyjal. Why they wouldn't when they were created last night is a mystery.

The Mt. Hyjal problem really throws me since that's where I tested this addon before uploading it.

[lots of edits because I realized it was unclear]

Last edited by Isharra : 12-27-10 at 01:34 AM.

12-26-10, 06:22 PM
dch48 A Kobold Labourer Forum posts: 0 File comments: 5 Uploads: 0	Along with the issue of deleted or moved notes retaining their positions on the minimap until you zone, I have now discovered that notes do not show at all on the minimap of Mount Hyjal. They show on the main map but not on the minimap. This seems to be the only zone with the problem. I use none of the handynotes addons, just the main program. My other addons are: Atlas Atlas Loot Auction Lite Recount Omen Deadly Boss Mods Critline PowerAuras Titan Panel They are all updated to the latest release versions. Edit:--On log in today, the icons are showing in Hyjal. Why they wouldn't when they were created last night is a mystery. Last edited by dch48 : 12-26-10 at 07:02 PM.

12-26-10, 02:26 PM

Sariktor

A Kobold Labourer

Forum posts: 0

File comments: 8

Uploads: 0

Originally posted by Isharra
Another problem that I don't see but I know others do. I thought I'd gotten it with one of the cleanup changes in 1.16b. Thanks for letting me know.

[edit] For clarity, the minimap icon appears immediately for me. The worldmap icon also appears immediately but is hidden underneath the current position icon until I move a bit. Removing an icon it's the same immediate change. Moving an icon updates it as soon as I release the icon (ctrl + shift + primary [left] mouse button drag).

Please PM me with a list of your addons so hopefully I can reproduce this and fix it for you. [/edit]

I don't have this issue with the v1.16 tempfix. Isharra, if you would like a copy of my version, just PM me with where to send it or I could put it on my webserver for you to download.

12-26-10, 02:23 PM

Sariktor

A Kobold Labourer

Forum posts: 0

File comments: 8

Uploads: 0

Re: Re: GetNodes() LUA Error

Originally posted by Isharra
My version of Mailbox has the updated compat section within it since some of the instructions to update addons had the code overwriting the base addon ( HandyNotes.compat = compat.) If you've modified your own copy, the second change is needed to have more than one mailbox appear in a map section (otherwise the addon will delete the earlier copies) but I don't believe it produced an error without the change.

I see what you mean. I added the following code into the work-around in the main HandyNotes Tempfix.

Code:

    function compat:ComputeDistance(c1,z1,x1,y1,c2,z2,x2,y2)
        local m1 = Astrolabe:GetMapID(c1, z1)
        local floors = Astrolabe:GetNumFloors(m1)
        local f1 = floors == 0 and 0 or 1
        local m2 = Astrolabe:GetMapID(c2, z2)
        floors = Astrolabe:GetNumFloors(m2)
        local f2 = floors == 0 and 0 or 1
        return Astrolabe:ComputeDistance(m1, f1, x1, y1, m2, f2, x2, y2)
    end

This enabled my mailboxes plugin (from your tempfix link) work as normal (allowing more than one icon). So HandyNotes and it's associated plugins are now working normally for me. Thanks for the work on the tempfixes. Hopefully, we'll see an official update from the original author soon.

12-26-10, 10:10 AM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Originally posted by Sariktor
Ahh, ok. I'm new to the whole addon scene especially when it comes to referencing external functions. But at least we are getting it to work like it should with the updated Astrolabe

Hey, I really appreciate your help here and the feedback on problems! And It's been a loooong time since I did any lua coding (or much typing at all.)

12-26-10, 10:03 AM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Originally posted by dch48
This fix is almost perfect for me. There is one issue however. When you change a note by either moving or deleting it, the icon remains in the original location on the minimap until you zone into a different map area and then zone back again.

Another problem that I don't see but I know others do. I thought I'd gotten it with one of the cleanup changes in 1.16b.

Thanks for letting me know.

[edit] For clarity, the minimap icon appears immediately for me. The worldmap icon also appears immediately but is hidden underneath the current position icon until I move a bit. Removing an icon it's the same immediate change. Moving an icon updates it as soon as I release the icon (ctrl + shift + primary [left] mouse button drag).

Please PM me with a list of your addons so hopefully I can reproduce this and fix it for you. [/edit]

Last edited by Isharra : 12-26-10 at 11:03 AM.

12-26-10, 10:00 AM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Re: GetNodes() LUA Error

Originally posted by Sariktor
I was able to get rid of the error by using the original tempfix (v1.16) with adding

Code:

local compat = {} compat = HandyNotes.compat

to each of the HandyNotes_* plugins. The Mailbox plugin didn't appear to have any issues for me.

Adding the compat reference to each of the addons is what should be done so that part is good. That should have been enough with the latest tempfix.

If you'd PM me with your addon list I'd appreciate it. It's hard to fix something you can't reproduce!

My version of Mailbox has the updated compat section within it since some of the instructions to update addons had the code overwriting the base addon ( HandyNotes.compat = compat.) If you've modified your own copy, the second change is needed to have more than one mailbox appear in a map section (otherwise the addon will delete the earlier copies) but I don't believe it produced an error without the change.

Originally posted by Sariktor
One thing I've noticed is that the mailbox icon will appear where your character is at the point that the mailbox interface is closed (for example if opened while still walking/running).

That should be unchanged behavior from the original Mailbox plugin. The add icon call was always on the onclose event.

Sorry for the edits, it's cooold here and my hands are very stiff. Lots of typos.

Last edited by Isharra : 12-26-10 at 10:52 AM.

12-25-10, 06:21 PM
dch48 A Kobold Labourer Forum posts: 0 File comments: 5 Uploads: 0	This fix is almost perfect for me. There is one issue however. When you change a note by either moving or deleting it, the icon remains in the original location on the minimap until you zone into a different map area and then zone back again.

12-25-10, 03:49 PM

Sariktor

A Kobold Labourer

Forum posts: 0

File comments: 8

Uploads: 0

GetNodes() LUA Error

After applying the new updated tempfix, I received this error:

Code:

Date: 2010-12-25 16:47:15
ID: 1
Error occured in: Global
Count: 2
Message: ..\AddOns\HandyNotes\HandyNotes.lua line 483:
   attempt to call method 'GetNodes' (a nil value)
Debug:
   (tail call): ?
   (tail call): ?
   HandyNotes\HandyNotes.lua:483:
      HandyNotes\HandyNotes.lua:464
   (tail call): ?
   [C]: ?
   [string "safecall Dispatcher[2]"]:9:
      [string "safecall Dispatcher[2]"]:5
   (tail call): ?
   HandyNotes\HandyNotes.lua:534: UpdateMinimap()
   HandyNotes\HandyNotes.lua:711:
      HandyNotes\HandyNotes.lua:702
   (tail call): ?
   [C]: ?
   [string "safecall Dispatcher[1]"]:9:
      [string "safecall Dispatcher[1]"]:5
   (tail call): ?
   ...AddOns\Bartender4\libs\AceAddon-3.0\AceAddon-3.0.lua:543: EnableAddon()
   ...AddOns\Bartender4\libs\AceAddon-3.0\AceAddon-3.0.lua:635:
      ...AddOns\Bartender4\libs\AceAddon-3.0\AceAddon-3.0.lua:621
   [C]: LoadAddOn()
   ..\FrameXML\UIParent.lua:242: UIParentLoadAddOn()
   ..\FrameXML\UIParent.lua:316: TimeManager_LoadUI()
   ..\FrameXML\UIParent.lua:517:
      ..\FrameXML\UIParent.lua:492
AddOns:
Removed for space.

I was able to get rid of the error by using the original tempfix (v1.16) with adding

Code:

local compat = {}
compat = HandyNotes.compat

to each of the HandyNotes_* plugins. The Mailbox plugin didn't appear to have any issues for me. One thing I've noticed is that the mailbox icon will appear where your character is at the point that the mailbox interface is closed (for example if opened while still walking/running).

Last edited by Sariktor : 12-26-10 at 04:31 AM.

12-25-10, 01:37 PM

Sariktor

A Kobold Labourer

Forum posts: 0

File comments: 8

Uploads: 0

Originally posted by Isharra
I'm thrilled it's working for you!

I really appreciate the input everyone especially since there were no comments the first couple of days. I was afraid it only worked for me.

Sariktor, thanks so much for the work pointing out the fixes in the additional HandyNotes addons (I don't use them myself so I couldn't test reliably.)

It shouldn't be necessary to add the whole compat section, just reference it in the other addons. change

Code:

local HandyNotes = LibStub("AceAddon-3.0"):GetAddon("HandyNotes") local Astrolabe = DongleStub("Astrolabe-0.4")

to

Code:

local HandyNotes = LibStub("AceAddon-3.0"):GetAddon("HandyNotes") local compat = {} compat = HandyNotes.compat

Obviously if the addon uses HN (or any other name) instead of "HandyNotes" as the variable name make the appropriate switch with compat. The advantage/disadvantage of this is that if compat changes in HandyNotes it's automatically updated in the other addons.

Then make the standard

Code:

Astrolabe:GetCurrentPlayerPosition()

to

Code:

compat:GetCurrentPlayerPosition()

Any other Astrolabe calls in the addons will also need to be updated.

handynotes_mailboxes has an additional call to Astrolabe:ComputeDistance, (which isn't added in the compat functions yet.) I'll try to work on this tonight or tomorrow once server maintenance is over.

And sorry for the delay in responding folks, I got Isharra to level 85, another to 83 and two more to level 82 since I posted this.

I need to kick my WoWInterface settings, I'm not receiving the email notifications I'm supposed to get when people leave a comment.

Ahh, ok. I'm new to the whole addon scene especially when it comes to referencing external functions. But at least we are getting it to work like it should with the updated Astrolabe

12-23-10, 12:45 AM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Originally posted by Toran
Sorry, my bad. Updating instructions now.

Hey, thanks for trying to help!

[edit] And it's not your fault! The problem went undetected because all the copies of compat matched but it broke once the main copy changed. [/edit]

The newer upload of HandyNotes_Mailboxes (tempfix) has compat defined locally so that an override from another HandyNotes_* doesn't break it any longer.

You shouldn't have to add the full compat section to each addon (see my earlier comment for adding a reference to the HandyNotes copy.)

However if you want a local copy add to the compat code block

Code:

    function compat:ComputeDistance(c1,z1,x1,y1,c2,z2,x2,y2)
        local m1 = Astrolabe:GetMapID(c1, z1)
        local floors = Astrolabe:GetNumFloors(m1)
        local f1 = floors == 0 and 0 or 1
        local m2 = Astrolabe:GetMapID(c2, z2)
        floors = Astrolabe:GetNumFloors(m2)
        local f2 = floors == 0 and 0 or 1
        return Astrolabe:ComputeDistance(m1, f1, x1, y1, m2, f2, x2, y2)
    end

Then in HandyNotes_Mailboxes, there are 2 functions which need to be updated. (You've documented the first change.)

in the same AddMailBox() function as the other modification change

Code:

            if Astrolabe:ComputeDistance(c,z,x,y,c,z,x2,y2) < 15 then

Code:

            local dist, xDelta, yDelta = compat:ComputeDistance(c,z,x,y,c,z,x2,y2)
            if  dist < 15 then

[edit] I made corrections for grammar and English usage. Though as tired as I am they may be worse than the original. [/edit]

Last edited by Isharra : 12-23-10 at 02:02 AM.

12-22-10, 09:18 PM

Toran

A Nerdscale Dorkin

Forum posts: 143

File comments: 433

Uploads: 0

Originally posted by Isharra
Ok, I've found the problem!

Toran's instructions have you redefining the base HandyNotes.compat with each addon loaded thus removing the added functions in the base addon.

Code:

local compat = {} HandyNotes.compat = compat

remove the "HandyNotes.compat = compat" line from each of those addons and they will still work and they won't muck with HandyNotes version.

That definition should only have been included in the base HandyNotes.

Sorry, my bad. Updating instructions now.

12-22-10, 08:50 PM
Isharra A Defias Bandit Forum posts: 2 File comments: 37 Uploads: 2	Ok, I've found the problem! Toran's instructions have you redefining the base HandyNotes.compat with each addon loaded thus removing the added functions in the base addon. Code: local compat = {} HandyNotes.compat = compat remove the "HandyNotes.compat = compat" line from each of those addons and they will still work and they won't muck with HandyNotes version. That definition should only have been included in the base HandyNotes. Last edited by Isharra : 12-22-10 at 08:55 PM.

12-22-10, 07:44 PM

Isharra

A Defias Bandit

Forum posts: 2

File comments: 37

Uploads: 2

Originally posted by mooch360
I'm also using CityGuide, Vendors, and Trainers, modified as per Toran's info. If no one else is having a problem maybe it was just me.

Thanks, I'll look into it. In the meantime I've uploaded a copy with the compat section added in. Hopefully it'll work for everyone now!

[edit] And never assume you're the only one having a problem. It's very common for folks to just not use it without saying anything. I really do appreciate the feedback. [/edit]

Last edited by Isharra : 12-22-10 at 07:47 PM.

Page 3 of 5

Report this File

Category Jump: