KethoCombatLog : Combat Mods : World of Warcraft AddOns

KethoCombatLog
v2.3.2 (2022-11-29)
Full Changelog Previous Releases

Update for 10.0.2

Optional Files (0)

Comment Options

Page 3 of 6

3

01-28-12, 11:14 AM
Ketho A Pyroguard Emberseer Forum posts: 1026 File comments: 213 Uploads: 52	Update: I'm leaving on the 10th of February so there's barely 2 weeks left kinda

01-27-12, 11:59 PM
linguini A Fallenroot Satyr Forum posts: 20 File comments: 80 Uploads: 0	Hi Ketho =D I actually tweaked the chat formatting myself in order to output it in a more visually pleasing way Although the coding is a bit sloppy, it does the job. Just wanted to also mention that the feasts announce wasn't working since you had it under SPELL_CAST_SUCCESS when it should be listed under SPELL_CAST_START. No that isn't me on the PTR. None of my toons are named Linguini. This is just some random name I chose for this forum The reason why I initially suggested the health indicator thing for determining who is a tank in the raid (for MDs and tricks of the trade) is that not all guilds do a regular "role check" in their raids. Although your method of filtering out tanks via the role check is a great idea, it really isn't ideal and using player health is a more secure and stable method of filtering out the tanks. As for my reformatting, I managed to change a little bit of the coding. I have zero experience in coding, however I managed to figure some parts out myself. Here are samples of what I came up with: textChat = ChatFilter("Dispel") and sourceUnitChat.." "..dispelString.." "..destUnitChat.."'s "..extraSpellLinkChat textChat = ChatFilter("Dispel") and sourceUnitChat.." "..ACTION_SPELL_STOLEN.." "..destUnitChat.."'s "..extraSpellLinkChat textChat = ChatFilter("Resurrection") and sourceUnitChat.."'s "..spellLinkChat.." "..ACTION_SPELL_RESURRECT.." "..destUnitChat textChat = ChatFilter("Interrupt") and sourceUnitChat.." "..ACTION_SPELL_INTERRUPT.." "..destUnitChat.."'s "..extraSpellLinkChat textChat = profile.SpellChat and sourceUnitChat.." casts "..spellLinkChat.." on "..destUnitChat

01-27-12, 01:55 PM

Ketho

A Pyroguard Emberseer

Forum posts: 1026

File comments: 213

Uploads: 52

Originally Posted by linguini

Hello.

Here's to hoping you're still around to code a bit more! i just have a few requests, hopefully none of these aren't major.

I'm noticing a lot of chat announces being in ugly formats. For example, things like Name[Dispel Magic] dispelled Enemyname[Power Word: Fortitude] which I've gone into the .lua directly and changing the code there to make it output into chat as "Name dispelled Enemyname's Power Word: Fortitude"

I know it's no big deal, but simple things like that could use some improvements. Another example would be for feasts. Feasts and cauldrons should be announcing (for chat outputs only) as "Name has prepared a Seafood Magnifique Feast" or "Name has prepared a Big Cauldron of Battle"

Here is a list of chat formattings that I think should be edited:

feasts: Ketho has prepared a Seafood Magnifique Feast.
cauldons: Ketho has prepared a Big Cauldron of Battle.
dispels: Ketho has dispelled Enemy's [Focus Magic].
spellsteal: Ketho has stolen Enemy's [Focus Magic].
interrupts: Ketho has interrupted Enemey's [Fireball].
deaths: Ketho has died to Deathwing's 190,203 Melee.
deaths: Ketho has died to environmental damage 40,291 Lava.
tricks: Ketho cast Tricks of the Trade on Maintank.
MDs: Ketho cast Misdirection on Offtank.
spells: Ketho has cast Time Warp.
toys: Ketho is [Using Direbrew's Remote].

Again, these are changes I think should only be implemented for chat output only.

Hi again Linguini! I resubscribed again on 2012.01.04 (3 months break if you don't count the 4.3.0 PTR)

I saw your thread on Event Display, and I honestly think the author that wrote it, is a really experienced programmer.
Again, Event Display (although out of date) imho really is a great addon, just like PowerAuras/WeakAuras.

(and I'm a noob, since I haven't done any programming/scripting courses/degrees at all)
I think I saw you on the 4.3 PTR ...
1. November 10th 2011
2. Female Undead Warlock
3. Anasterian (US)
amiright?
I'm still around and coding, but ... I'm currently working on a new addon, "ScrollingChatText" (SCR) (see bottom of my post)
Ketho CombatLog and ReadySetDing are (still and forever) on my To Do list for updating, however I will first have to complete ScrollingChatText, which will take me at least another 2-3 days, and then it will take me at least another 4-5 days to update KCL/RSD, while coping with Real Life ...
I think you are giving a good suggestion on the chat format. I will try to implement custom combat messages, so users can modify it themselves. I'm just not sure yet what the (custom) default chat formats should be like. (Blizzard/Verbose/Minimal/yours)

Anyway updating KCL might be a huge PITA.
1. Update stuff to 4.3 if anything got broken
2. Setup the addon on a Git repository
3. Divide the addon into files instead of 1 huge file (5000 lines)
4. Custom chat formats, or "less ugly" (as you suggested) + Look into Blizzard CombatLog's chat formats (which are localized)
5. Improve (wasted) Interrupts and CC Breaks checking. (Blizzard's interrupt/break events seem to fire only sometimes)
6. Add localization support
7. Fix the spell tooltips, half of them are broken for non-mana classes (tooltips don't show mana for e.g. warrior)
8. Use LibSharedMedia and CUSTOM_CLASS_COLORS
9. Custom "Events", but that might be impossible for me, even in a year's time unless I look how other addons, like RSA/PowerAuaras/WeakAuras/TellMeWhen/ThatJustHappened/Event Display/ do it
Biggest "Problem" is that I will be going to the US (I'm living in Europe) in about 2 to 2.5 weeks, and stay there for a month, to attend my brother's wedding. It's kinda also a waste of my gamecard

So that will be my deadline, since I got completely NO IDEA if I'll have access to a computer/laptop with WoW there + enough free time

Last edited by Ketho : 01-27-12 at 02:55 PM.

01-26-12, 10:48 PM
linguini A Fallenroot Satyr Forum posts: 20 File comments: 80 Uploads: 0	Hello. Here's to hoping you're still around to code a bit more! i just have a few requests, hopefully none of these aren't major. I'm noticing a lot of chat announces being in ugly formats. For example, things like Name[Dispel Magic] dispelled Enemyname[Power Word: Fortitude] which I've gone into the .lua directly and changing the code there to make it output into chat as "Name dispelled Enemyname's Power Word: Fortitude" I know it's no big deal, but simple things like that could use some improvements. Another example would be for feasts. Feasts and cauldrons should be announcing (for chat outputs only) as "Name has prepared a Seafood Magnifique Feast" or "Name has prepared a Big Cauldron of Battle" Here is a list of chat formattings that I think should be edited: feasts: Ketho has prepared a Seafood Magnifique Feast. cauldons: Ketho has prepared a Big Cauldron of Battle. dispels: Ketho has dispelled Enemy's [Focus Magic]. spellsteal: Ketho has stolen Enemy's [Focus Magic]. interrupts: Ketho has interrupted Enemey's [Fireball]. deaths: Ketho has died to Deathwing's 190,203 Melee. deaths: Ketho has died to environmental damage 40,291 Lava. tricks: Ketho cast Tricks of the Trade on Maintank. MDs: Ketho cast Misdirection on Offtank. spells: Ketho has cast Time Warp. toys: Ketho is [Using Direbrew's Remote]. Again, these are changes I think should only be implemented for chat output only.

01-15-12, 02:06 PM

Zanaken

A Deviate Faerie Dragon

Forum posts: 12

File comments: 17

Uploads: 0

Originally Posted by Ketho

I'm so sorry .. I released v1.04 after 2 weeks, but I could not work on Custom Messages, the Output Display, or Deaths Throttling ...

I will also be taking a WoW break starting today, so active development will be stopped for now

REALLY, REALLY good addon. VERY configurable, and if implemented right can have multiple awesome effects.

Everything from a Kick announcer to a full battle relay on a separate MSBT window.

Seriously great job man, excellent addon ^^

09-27-11, 09:07 AM
Theondry A Deviate Faerie Dragon Forum posts: 11 File comments: 110 Uploads: 1	If I can find time, I'll try to dig through it to see if I can understand how it works. I am not a good coder, but if I'm lucky I can cobble things together. I don't know if others are following this, but are there any suggestions for a decent LibSink display thingie? My searchfu has not been able to find one. (Scrolling text is not useful because it's gone and doesn't let me analyze it later). Right now I'm redirecting things to a chat window, but... I need more space! (or to delegate someone in the raid to watch that for me, I guess. Thanks for your efforts, and enjoy your break. __________________ Theondry of Perenolde

09-27-11, 01:17 AM
Ketho A Pyroguard Emberseer Forum posts: 1026 File comments: 213 Uploads: 52	I'm so sorry .. I released v1.04 after 2 weeks, but I could not work on Custom Messages, the Output Display, or Deaths Throttling ... I will also be taking a WoW break starting today, so active development will be stopped for now

09-13-11, 05:27 PM

Ketho

A Pyroguard Emberseer

Forum posts: 1026

File comments: 213

Uploads: 52

Originally posted by Theondry
I've noticed that output to a chat channel retains the links, it's the output to the chat frame that does not.

EDIT:
I figured it out. There are no Braces around the chat frame output. Very disconcerting.

Sorry, I was confused, in that I thought that you meant the Spell Links weren't clickable anymore (><)

v1.00: Added options for [Unit Braces], and [Trim Realm Names]

Oh yes, I actually changed that in v1.00 ... by default it now omits the braces from Unit and Spell Links in the ChatFrame/ChatWindow
The option for that is Advanced -> Advanced -> Show Braces (Local)

I'd like to second a request to be able to shape output. I've been using a modified version of Raksh's Interrupt addon (I've had to fix it a few times, and stopped checking to see if he's been updating it) and it has a very clean output for interrupts such that I've been using your addon for self-information and his to output to chat, but i'd like to cut down on how much stuff I have loaded.

I haven't looked at your code, but if you're using a generic format for output (as opposed to separate chat output for each type of notification), it seems like it should be fairly easy to have users edit the code if they want some customization.

I've been trying for a while to actually add this, but I'm still not sure what is the best way to implement it

I'm not experienced enough to code up something like that, but I will try to give it another go on adding custom messages formats ..

One last request (perhaps very much out of the scope of the addon)... a dedicated display panel. I'm having problems finding a decent place to keep the spam this generates during hectic fights visible.

Damnit, I *need* all that information!

I'm a complete noob on working with UI frames, so I'll have to start learning, to create a display panel(s). But if I'm lucky, there might already be a library for exactly that so I can cheat on that part, but otherwise this will be very low priority for now

LibSink has a "display panel", but it's not customizable and floating in the center of the screen
You can also use an individual ChatFrame/ChatWindow to act as a "display panel", but it's not exactly what you are wanting I suppose

-- Little announcement:

I lately don't have much free time to work on my addons, and only have 2 weeks left on my current subscription, so that's also kinda my deadline ...
Anyway I hope u wish me good luck

09-13-11, 11:17 AM
Theondry A Deviate Faerie Dragon Forum posts: 11 File comments: 110 Uploads: 1	I've noticed that output to a chat channel retains the links, it's the output to the chat frame that does not. EDIT: I figured it out. There are no Braces around the chat frame output. Very disconcerting. I'd like to second a request to be able to shape output. I've been using a modified version of Raksh's Interrupt addon (I've had to fix it a few times, and stopped checking to see if he's been updating it) and it has a very clean output for interrupts such that I've been using your addon for self-information and his to output to chat, but i'd like to cut down on how much stuff I have loaded. One last request (perhaps very much out of the scope of the addon)... a dedicated display panel. I'm having problems finding a decent place to keep the spam this generates during hectic fights visible. Damnit, I need all that information! I haven't looked at your code, but if you're using a generic format for output (as opposed to separate chat output for each type of notification), it seems like it should be fairly easy to have users edit the code if they want some customization. __________________ Theondry of Perenolde Last edited by Theondry : 09-13-11 at 03:15 PM.

09-13-11, 01:30 AM

Ketho

A Pyroguard Emberseer

Forum posts: 1026

File comments: 213

Uploads: 52

Originally posted by Theondry
Links seem totally disabled in the chat panes. (currently output to a different-than-default panel)

The only thing I can think of is that you enabled the "Spell Names instead of Spell Links" option
(but that option only affects the [Optional Spells])

Spell Links shouldn't be affected by what ChatWindow/ChatPane you set it to output to.

Unless you're (also/only) using LibSink to output to? But even LibSink should properly output the Spell Links ...

.. otherwise I really got no idea why the Spell Links (completely?) aren't working for you

Originally posted by linguini

add "Big Cauldron of Battle" to feasts/bots
add "Cauldron of Battle" to feasts/bots

Okay, I will add them

separate resurrections into two options:
battle res (rebirth, raise ally, shaman ankh) and regular out-of-combat res
when casting a spell on self, announce self's name as well. example:
instead of "Linguini Slow Fall" it should say "Linguini Slow Fall Linguini"
option to show/hide failed interrupts (immune)

I will try to add additional options for the first 2 suggestions
For the third suggestion: There already is an option for "failed interrupts" under the Advanced -> Extra -> Misses Tab

only announce tricks of the trade and misdirections to players over 170,000 health (tanks)

I will try to add an option for these 2 specific spells, when it's being cast on tanks
(there is an API for it, so there's no need to do a health check)

add a limit to amount of death announces
example: only announce the first 10 deaths in a 25 man raid

Woot, this will be a lot trickier to implement, and I'm not sure if I can find a clean way to implement this

I previously had something like that in v0.5 or so, but the coding was horrible (><)

Sorry for the late reply; I will add linguini's suggestions to my ToDo list, but it might take a week or even longer due to time restrictions =(

Last edited by Ketho : 09-13-11 at 01:56 AM.

09-12-11, 05:02 PM
Theondry A Deviate Faerie Dragon Forum posts: 11 File comments: 110 Uploads: 1	Links seem totally disabled in the chat panes. (currently output to a different-than-default panel) (edit: deleted the first part... confused an error with another addon.) __________________ Theondry of Perenolde Last edited by Theondry : 09-12-11 at 06:22 PM.

09-10-11, 10:19 PM
linguini A Fallenroot Satyr Forum posts: 20 File comments: 80 Uploads: 0	maybe just a few more requests! XD add "Big Cauldron of Battle" to feasts/bots add "Cauldron of Battle" to feasts/bots separate resurrections into two options: battle res (rebirth, raise ally, shaman ankh) and regular out-of-combat res only announce tricks of the trade and misdirections to players over 170,000 health (tanks) add a limit to amount of death announces example: only announce the first 10 deaths in a 25 man raid when casting a spell on self, announce self's name as well. example: instead of "Linguini Slow Fall" it should say "Linguini Slow Fall Linguini" option to show/hide failed interrupts (immune) Last edited by linguini : 09-12-11 at 04:49 PM.

09-09-11, 06:51 PM

linguini

A Fallenroot Satyr

Forum posts: 20

File comments: 80

Uploads: 0

v1.02 [2011.09.09]
Fixed Taunts still announcing if only Local taunts was enabled
Added option to show Spell Names instead of Spell Links for optional spells (requested by linguini)

you are simply the best

09-08-11, 03:56 PM

linguini

A Fallenroot Satyr

Forum posts: 20

File comments: 80

Uploads: 0

I can try to add an option for using Spell Names instead of Spell Links on all of the optional spells like Time Warp, if you can confirm that's what you wanted

that is exactly what im asking!

09-07-11, 06:25 PM

Ketho

A Pyroguard Emberseer

Forum posts: 1026

File comments: 213

Uploads: 52

Originally posted by linguini
would it be possible to make SOME spells clickable, some non-clickable? (GetSpellLink versus GetSpellInfo)

for example, when someone dispels or interrupts something, it will show a clickable link to something they dispelled or interrupted. example: Johnsmith dispelled [Click Me!].

when someone uses a spell, it will just show what they casted and not a linkable spell. example: Johnsmith Time Warp

Hi linguini! So you say you want an option to not show the Spell Link, but the Spell Name instead for all optional spells like Time Warp?

Note: There is a new option for Unit Braces in v1.00. For example:

[Linguini] -> Linguini
[Time Warp] -> Time Warp (still clickable)

This might get confusing, so here's a quick set out how the braces [] options currently work:

Unit Braces (Local): Removes braces from Local Unit Links and Local Spell Links (still clickable)
Unit Braces (Chat): Removes braces from Chat Unit Links but not Chat Spell Links (still clickable)

I can try to add an option for using Spell Names instead of Spell Links on all of the optional spells like Time Warp, if you can confirm that's what you wanted

Last edited by Ketho : 09-07-11 at 06:39 PM.

Page 3 of 6

3

https://github.com/sponsors/Ketho

Compatibility:	Dragonflight (10.0.2)
Updated:	11-28-22 09:10 PM
Created:	11-29-10 02:34 PM
Downloads:	14,152
Favorites:	67
MD5:
Categories:	Combat Mods, Buff, Debuff, Spell, Chat Mods, PvP, Arena, BattleGrounds