Download
(89 Kb)
Download
Updated: 12-02-11 03:04 PM
Patch for:
ItemRack.
Pictures
File Info
Updated:12-02-11 03:04 PM
Created:10-17-10 10:40 AM
Downloads:16,976
Favorites:124
MD5:
ItemRack - Cataclysm  Popular! (More than 5000 hits)
Version: 2.73
by: Kharthus, Yewbacca
This fixes ItemRack to work with Cataclysm and contains important bug fixes and improvements.

Original version is here: ItemRack

12/9/11: All future updates will be back on the main addon page.
__ New in 2.73 - By Kharthus __

* TOC update for WoW 4.3.0
* Fixed GetNumMacroIcons error in 4.3

__ New in 2.72 - By Kharthus __

* TOC update for WoW 4.2.0

__ New in 2.71 - By Kharthus __

* TOC update for WoW 4.1.0

__ New in 2.7 - By Yewbacca __

* Created new consolidated patterns for ItemLink/ItemString-to-ItemRackStyleID, ItemRackStyleID-to-BaseID, ItemLink/ItemString-to-BaseID
* Created new functions that use those patterns, and various other new helper functions, in order to consolidate all ItemString-handling in one place
* Replaced all old-style handling of itemIDs (string.gsub/find/match) and made everything use the new functions instead, for more robust handling as well as easy updates in the future
* Replaced GUI drawing code with references to new functions, to get icons and tooltips to work in the GUI
* Updated the GUI code so that it always draws item tooltips using the player's current level, which ensures that mousing over heirlooms in saved sets will actually show their stats for your CURRENT level (the old code set all levels to 0 which made it so the stats were shown incorrectly as level 1)
* Improved the two functions that actually LOCATE the stored equipment set items inside the player's inventory/equipment/bank (whether it's for equipping, or simply displaying a tooltip), by making sure those functions pass the INCOMING ID through the new level updater (UpdateIRString) to ensure all old Item IDs are up to date, thus fixing the bug where leveling up would cause ItemRack to fail strict item search on all saved sets and resort to any-item-with-the-same-baseID; this injection point was chosen because it fixes the problem completely throughout the board, since everything that locates items relies on the item finding functions
* Updated the functions for getting info for an item (GetInfoByID), posting an itemlink to the chatbox when shift clicking an item in ItemRack's GUI (ChatLinkID), and the function for showing an item in a tooltip, so that they all pass the incoming ID through the level updater (UpdateIRString) in order to work with up-to-date information, since it's important that stats are correct whether it's for posting chat links or looking at a tooltip's stats
* Commented and cleaned up terrible code here and there, as I untangled the messy code (minor changes)

__ New in 2.65 - By Kharthus __

* Reverted gear swap code to 2.243 version

__ New in 2.64 - By Kharthus __

* Fixed slash commands

__ New in 2.63 - By Kharthus __

* Replaced all getglobal calls with _G
* Fixed Titan's Grip and Shaman off-hand

__ New in 2.62 - By Kharthus __

* Fixed lua errors caused by chat links
* Fixed issues with clicking on Dockable Buttons
* Fixed event code
* Fixed icon updates on gear swaps

__ New in 2.61 - By Kiki __

* Fixed lua errors caused by tooltips

__ New in 2.60 - By Kiki __

* Fixed for WoW 4.0
Archived Files (7)
File Name
Version
Size
Author
Date
2.72
88kB
Kharthus
06-28-11 07:19 PM
2.71
89kB
Kharthus
04-26-11 09:51 PM
2.7
85kB
Kharthus
01-23-11 03:01 AM
2.65
84kB
Kharthus
10-22-10 09:19 AM
2.64
85kB
Kharthus
10-17-10 03:36 PM
2.63
85kB
Kharthus
10-17-10 11:46 AM
2.62
85kB
Kharthus
10-17-10 10:40 AM


Post A Reply Comment Options
Unread 12-09-11, 09:58 PM  
Kharthus
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 227
Uploads: 6
I got access to the main project finally, so all updates will now occur over there.
Kharthus is offline Report comment to moderator  
Reply With Quote
Unread 12-03-11, 01:50 AM  
Kharthus
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 227
Uploads: 6
You lost me. What exactly isn't working correctly?
Kharthus is offline Report comment to moderator  
Reply With Quote
Unread 12-02-11, 04:47 PM  
Kuzo
A Kobold Labourer

Forum posts: 0
File comments: 15
Uploads: 0
I think I've found a small bug in the app that's been there from the get go. I've noticed it for a long time, at least a couple of years. Depending on how you create them, outfits in ItemRack don't get recognized properly by other addons, like ArkInventory. IE, you'll create a set that works and is sorted properly, but when you add or remove gear from that set the new items aren't listed as part of an outfit.

Based on looking at the LUA files, it looks like this is because the ItemRack saved variables relies on setting your outfit in multiple places, but it doesn't synchronize those entries. I have a primary set called Tank which shows up in it's own entry, and then again in the OldSet value for my other set, War. Both are similar, but the items that aren't recognized by ArkInventory don't show up in one of the sets. And the kicker is, if I update one set, the other set switches back to the broken values.
Kuzo is offline Report comment to moderator  
Reply With Quote
Unread 12-02-11, 04:26 PM  
Kuzo
A Kobold Labourer

Forum posts: 0
File comments: 15
Uploads: 0
Karthus, thank you very much for keeping this addon maintained. I still prefer ItemRack to any other outfit manager and your efforts are much appreciated as a result.
Kuzo is offline Report comment to moderator  
Reply With Quote
Unread 12-02-11, 07:28 AM  
Goldenspike
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Ballistics: Thank you for the answering and it worked.

However it still shows that it is out of date and a lot of ICON's are missing (ones the player uses to designate between gear selection).

Kharthus: That would be great, When you took this over it made things so much easier for me on my Druid, constantly switching gear in dungeons.

Thanks again Guys
Spike
Goldenspike is offline Report comment to moderator  
Reply With Quote
Unread 12-02-11, 03:56 AM  
Outofluck
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Originally Posted by Kharthus
I'm still here. I'll try to get this fixed this weekend.
I love this addon, I can't live without it.
I love you, but in a Manly way that only 2 ppl who respect eachother alot and have No sexual intentions at all can do...

I can't stand dpsing in healing gear anymore!
Outofluck is offline Report comment to moderator  
Reply With Quote
Unread 12-01-11, 07:23 PM  
Kharthus
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 227
Uploads: 6
I'm still here. I'll try to get this fixed this weekend.
Kharthus is offline Report comment to moderator  
Reply With Quote
Unread 12-01-11, 08:46 AM  
Ballistics
A Kobold Labourer
 
Ballistics's Avatar

Forum posts: 0
File comments: 2
Uploads: 0
this is how I did it (maybe not 100% right way)

find ItemRackOptions.lua which should be in your Wow/interface/ItemRack Options folder

open with notepad and use Find to locate :-

function ItemRackOpt.PopulateInitialIcons()

Below it you will see other code, Highlight the following:-


function ItemRackOpt.PopulateInitialIcons()
ItemRackOpt.Icons = {}
for i=0,19 do
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Misc_QuestionMark")
end
ItemRackOpt.PopulateInvIcons()
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_02")
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_03")
for i=1,GetNumMacroIcons() do
table.insert(ItemRackOpt.Icons,GetMacroIconInfo(i))
end
end



highlight this and replace it with:-

function ItemRackOpt.PopulateInitialIcons()
if ( IsAddOnLoaded("Blizzard_MacroUI") ) then
self:ADDON_LOADED(nil, "Blizzard_MacroUI");
else
UIParentLoadAddOn("Blizzard_MacroUI");
end
local MACRO_ICON_FILENAMES = {}
ItemRackOpt.Icons = {}
for i=0,19 do
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Misc_QuestionMark")
end
ItemRackOpt.PopulateInvIcons()
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_02")
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_03")
RefreshPlayerSpellIconInfo() --or GetMacroIcons( MACRO_ICON_FILENAMES );
for i=1,#MACRO_ICON_FILENAMES do
table.insert(ItemRackOpt.Icons,GetSpellorMacroIconInfo(i))
end
end




Hope this works for you as it did me.

Many thanks for the fix. love this addon
Ballistics is offline Report comment to moderator  
Reply With Quote
Unread 12-01-11, 08:34 AM  
Goldenspike
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Ok guys I'm not a programer so what program do I use to edit this file to make this work. As Veyska said I hate to this addon die. I don't care for the one Bliz added way back. Any help?

Thanks
Spike.
Goldenspike is offline Report comment to moderator  
Reply With Quote
Unread 12-01-11, 06:10 AM  
sk68
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Change the function below (PopulateInitialIcons) like this:

============== START CODE =============

function ItemRackOpt.PopulateInitialIcons()
if ( IsAddOnLoaded("Blizzard_MacroUI") ) then
self:ADDON_LOADED(nil, "Blizzard_MacroUI");
else
UIParentLoadAddOn("Blizzard_MacroUI");
end
local MACRO_ICON_FILENAMES = {}
ItemRackOpt.Icons = {}
for i=0,19 do
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Misc_QuestionMark")
end
ItemRackOpt.PopulateInvIcons()
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_02")
table.insert(ItemRackOpt.Icons,"Interface\\Icons\\INV_Banner_03")
RefreshPlayerSpellIconInfo() --or GetMacroIcons( MACRO_ICON_FILENAMES );
for i=1,#MACRO_ICON_FILENAMES do
table.insert(ItemRackOpt.Icons,GetSpellorMacroIconInfo(i))
end
end

============== END CODE =============

The errors you are getting at line 616 should disappear if you fix the problem above too.

The GetNumMacroIcons API functions has been removed in 4.3.0, and RefreshPlayerSpellIconInfo will automatically fill MACRO_ICON_FILENAMES array with the appropriate number of items. Furthermore, the GetMacroIconInfo API has also been removed(?) and should be changed to GetSpellorMacroIconInfo. I hope this helps.
Last edited by sk68 : 12-01-11 at 07:45 AM.
sk68 is offline Report comment to moderator  
Reply With Quote
Unread 11-29-11, 08:03 PM  
Veyska
A Kobold Labourer
 
Veyska's Avatar

Forum posts: 1
File comments: 47
Uploads: 0
Unhappy 4.3 errors

Hopefully someone will see this who can figure out how to fix the errors, would hate to see this add-on finally die (haven't seen a single equal replacement)...

***On opening config/options window:
1x ItemRackOptions\ItemRackOptions.lua:345: attempt to call global 'GetNumMacroIcons' (a nil value)
ItemRackOptions\ItemRackOptions.lua:59: in function `OnLoad'
<string>:"*:OnLoad":1: in function <[string "*:OnLoad"]:1>
<in C code>: in function `LoadAddOn'
ItemRack-2.72\ItemRack.lua:1695: in function `ToggleOptions'
ItemRack-2.72\ItemRack.lua:1660: in function `MinimapOnClick'
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>

Locals:
self = ItemRackOptFrame {
0 = <userdata>
}

1x ItemRackOptions\ItemRackOptions.lua:616: attempt to get length of field 'OptInfo' (a nil value)
ItemRackOptions\ItemRackOptions.lua:177: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
ItemRack-2.72\ItemRack.lua:1700: in function `ToggleOptions'
ItemRack-2.72\ItemRack.lua:1660: in function `MinimapOnClick'
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>

Locals:
setname = nil


***On opening Queue tab (was first one in order, not sure it's specific to this tab):
1x ItemRack-2.72\ItemRack.lua:761: attempt to index field '?' (a nil value)
ItemRackOptions\ItemRackOptions.lua:1014: in function `StartMarquee'
ItemRackOptions\ItemRackOptions.lua:1039: in function `QueuesFrameOnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
ItemRackOptions\ItemRackOptions.lua:824: in function `TabOnClick'
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>


Couple variations on those errors from other clicks, but all of them that I can get it to throw all start with the same origin lines. Probably tied to one or two fixes, Blizz seems to have done *something* to macros as one of my other macro-related mods is whining as well.


Here's hoping...
Veyska is offline Report comment to moderator  
Reply With Quote
Unread 09-06-11, 06:19 AM  
Yewbacca
A Murloc Raider

Forum posts: 6
File comments: 34
Uploads: 0
As Khartus said, he and I aren't playing anymore. I launched a company in March and haven't had time to play since, and in fact went ahead and deleted my character yesterday. I've also gone ahead and deleted the accounts or randomized the password at all WoW-related sites I had memberships at today. So, if anyone wants to maintain ItemRack from the current source code, you are *very* welcome to do so. Talk to Khartus, if he's still around, since I won't be returning to WoW or WoWInterface again; or, if he's gone as well, talk to WoWInterface staff to take over the project, since it's public domain. It was a fun run but real life calls.
__________________
Goodbye WoWInterface, and thanks for all the fish!
Yewbacca is offline Report comment to moderator  
Reply With Quote
Unread 07-09-11, 07:41 PM  
blankStare
A Kobold Labourer

Forum posts: 1
File comments: 85
Uploads: 0
taint error

I got this taint error for each slot, not sure what I was doing.
7/9 19:53:05.936 An action was blocked in combat because of taint from ItemRack - ItemRackButton0:SetAttribute()
7/9 19:53:05.936 Interface\AddOns\ItemRack\ItemRackButtons.lua:35 InitButtons()
7/9 19:53:05.936 Interface\AddOns\ItemRack\ItemRack.lua:184 func()
7/9 19:53:05.936 Interface\AddOns\ItemRack\ItemRack.lua:784 OnUpdate()
7/9 19:53:05.936 ItemRackFrame:OnUpdate()
blankStare is offline Report comment to moderator  
Reply With Quote
Unread 04-30-11, 12:35 PM  
Kharthus
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 227
Uploads: 6
Yewbacca and I aren't really playing WoW these days so if anyone else is interested in fixing bugs or adding new features just let me know. I'll try to at least keep it working thru major patch changes like 4.1.
Kharthus is offline Report comment to moderator  
Reply With Quote
Unread 02-13-11, 06:59 AM  
Dusk
A Kobold Labourer

Forum posts: 1
File comments: 6
Uploads: 0
If you log out near a mob and are in combat when you log in again, ItemRack will cause a C stack overflow error and the bug count will keep climbing until the UI advises you to disable addons. You canont cast spells while this is happening so getting rid of the mob on you is hard.
Dusk is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: