(136Kb)

Updated: 12-18-14 04:48 PM

Add Favorite

Install Help

Pictures

File Info

Compatibility:	Warlords of Draenor (6.0.3)
Updated:	12-18-14 04:48 PM
Created:	03-11-10 12:01 PM
Downloads:	9,809
Favorites:	103
MD5:
Categories:	Bags, Bank, Inventory, Character Advancement

TopFit

Version: 6.0v4

by: Mirroar, ckaotik

What is TopFit?

TopFit is a gear management addon designed to select the best gear for you when you just can't be bothered to compare items yourself.
To make intelligent gear choices for you, you will first have to create item scales, telling the Addon which stats are the most important to you. After that, just put all interesting items into you inventory and start the calculation. Voilà, you have a fine new equipment set, which you can update with a single click from now on.
TopFit will check an item's stats, gems, enchantments, whether you can dualwield or have Titan's Grip, and more.
Any caps you're trying to reach can also be set (hit rating cap for damage dealers, defense rating cap for (non-bear-)tanks, etc).

Features

Create equipment sets based on stat weights, or use a predefined set for your class
Force certain items that you want in your set regardless of score (trinkets, totems, ...)
Item choices are made automagically and intelligently based on these weights
Save sets using Blizzard's equipment manager
Import and export Pawn Strings
Sets will take your character's ability to dual-wield into account
Support for multiple caps (hard caps like hit, soft caps like defense)
Have a leveling set that gets updated whenever you get a new piece of equipment
Support for set bonusses (if you want to keep you 2-piece t9 bonus, or at least have its value added to the calculation)
Item-Comparison tooltip: How much of an improvement is a new item?
"Binds on Equip" items will not be used in calculations
Add "virtual" items to the calculation, to see how your stats would change if you bought a certain item
Works with any client language, currently localized in English
Aware of unique items and gems

Planned Features

Suggest gems and enchantments for your sets
Add stats to items to account for procs and on-use effects

6.0v2 - 2014/12/18

fixed dual-wield detection
fixed problems with TopFit trying to equip two Solium Rings
fixed auto-update not triggering when a new item was put in the player's backpack instead of any of the other bags
fixed multistrike not being recognized correctly on gems and enchantments
fixed shadow resistance not being recognized correctly on gems
fixed detection and handling of unique or unique-equipped items
fixed addon options only showing correctly after using slash command or options button twice
import now supports importing weights from askmrrobot
the option to add sets from a preset will now also be shown on left-clicking the "+"-button, instead of only when right-clicking
added new options plugin for sets to config frame containing options formerly available from within the weights plugin
sets can now be assigned a specialization - this affects auto-update and auto-equip and will later be used to limit calculation to gear appropriate for the selected spec
auto-update and auto-equip are now configured in a set's options instead of TopFit's global options
updated trinket logic to better detect and parse trinket proc effects
TopFit will no longer create a "Default Set" with no weights for new characters
instead, the new setup plugin will be shown, assisting the player in creating initial sets
added a tutorial overlay, triggered by clicking the "i"-button in the top-left corner of the options frame
updated presets with new values from askmrrobot
sets created from a preset will have an appropriate icon and associated spec assigned

6.0v2 - 2014/11/22

fixed an error that was preventing the fix to dungeon loot in 6.0v2 from working
moved import / export plugin into set dropdown and weights plugin to free some space
updated import / export compatibility with Pawn
show comparison tooltip be default for new users
added simple LibDataBroker launcher, which will also show up as a minimap button

6.0v2 - 2014/11/22

updated gem and enchant data from wowhead
added some enchant data manually
updated presets from askmrrobot
internally scaling dungeon loot should now be correctly considered by TopFit (and the Paperdoll item flyout)
added Bonus Armor as a stat in the defense category
fixed errors when the user had no sets defined or deleted their last set

6.0v1 - 2014/10/24

updated for patch 6.0.2
wipe saved sets to account for numerous stat changes
removed reforging
added new stats
updated enchant and gem data to account for item squish
updated presets to current wowhead.com scales
missing enchants and gems no longer generate a chat message and are instead shown in the config frame
no longer show set comparison values for bags
no longer use LibItemUpgradeInfo since API now provides correct stats

5.3v1 - 2013/07/03

fixed +80 Stats enchant
removed Ace and other Libraries we were hardly using
rewrote set handling and calculation to use classes for a cleaner API
new configuration UI accessed through a button in the character panel
updated gem data
added handling for upgraded items
forced items are now managed in the character frame by holding down the Alt-key while hovering an equipment slot and using the checkboxes in the resulting flyout-box
when switching talent specializations, the respective auto-update set is no longer calculated, just equipped (which is usually what you want and much faster)
added Lib-Unfit-1.0 to limit showing tooltips and auto-updating to items you can actually wear

5.1v1 - 2012/11/28

updated toc for 5.1
added MoP Enchants (including Inscription, Leatherworking and Tailoring)

5.0v2 - 2012/11/04

fixed an error with the set dropdown on classes that have no weight presets
added rudimentary weight presets for monk class (based on druid weights)
fixed trying to dual wield ranged weapons
fixed monk dual wielding
when auto-update is enabled and a new equipment item is put into the player's bags, TopFit will only do a full calculation if that item is actually relevant for the auto-update-set
added MoP Cogwheel gems
TopFit is now finally aware of unique-equipped items and unique gems (like jeweler's and cogwheels) and will not try to equip more than possible

5.0v1 - 2012/09/04

If an auto-update-set is set for your current spec, it will now automatically be selected in the ui on login
added new epic gems
fixed an error that occured when creating a new set
fixed an error when trying to delete a set
Compatible with WoW Patch 5.0.4
Updated gems for WoW 5.0.4
moved Set Dropdown and Calculate button in Character Frame to not collide with default UI elements
When calculating a set, slots that have forced items in them are shown with a red outline on their virtual item buttons

4.3v1 - 2011/12/04

you can now calculate all your sets at once by shift-clicking the calculate button
added an option to calculate auto-update sets on switching talent specs

4.2v2 - 2011/09/24

removed old files
fixed small bug caused by calling an old function
fixed forced items that are no longer in your inventory not showing in force item flyout
fixed 2h-weapons still being equipped when an offhand is forced
fixed dual-wielding for hunters only from level 20
updated presets to match cataclysm specs (see wowhead.com/items, 2011/09/24)
added stats for melee/ranged weapon speeds as well as melee/ranged dps
added level 85 PvP enchants and some missing armor kits as well as "Flintlocke's Woodchucker" (whee!) to enchant data

4.2v1 - 2011/07/10

added API function to check if an item is interesting to the player
fixed a bug in the hit-for-spirit calculation where hit rating would not be granted to the raw item value
items and score cache is now cleared on talent change
this should also fix items sometimes not being granted hit-for-spirit values directly after login
you can now specify a second automatic update set which will be equipped when your second talent specialization is active
reworked set management interface to integrate nicely with the character frame
added option to force you classes specialization armor type
added some scanning of Trinket on-use and on-proc effects (thanks ckaotik!)
updated gem list with theoretically all missing Cata gems for 4.1 (thanks ckaotik!)
added a small number of enchants (notably leg armor), might still be missing some
fixed warnings about missing enchant data being printed even though the data was there
You can now force multiple items per inventory slot - TopFit will consider any forced items for a slot if set

4.0v2 - 2010/12/09

updated toc version
dual wield and titan's grip should be detected correctly again - if for some class it isn't, tell me, please
spririt-to-hit talents for priests, shamans, druids and paladins will internally add hit rating to an item's score as a hotfix for calculating correct hit rating caps - again, if it doesn't work for a class, I will need a notice from you

4.0v1 - 2010/12/04

compatible with WoW 4.0.3
reforged stats should be recognized correctly
mastery rating added to stats
armor penetration, attack power, defense rating and block value removed from stats
localization support, though only english locale exists for now (thanks to ckaotik)
module tabs have been made prettier (thanks to ckaotik)
a module for importing and exporting pawn strings has been added (thanks to ckaotik) it also shows gearscore of the selected set
gem stats have been updated (thanks to ckaotik, once again!)
enchant stats have been updated
some cataclysm enchants and gems have been included (those that were on WoWHead already)
updated presets to use the current values from wowhead (though they are not very good, especially concerning the changes to spirit for all casters - they just added mastery rating at 10 value, and kept all other stats the same from WoW 3.3)
presets currently have no caps assigned, since I don't know the current values
added arms warrior preset
removed blood DPS and frost tank presets for death knights
when creating or renaming sets, TopFit will now make sure set names are always unique

3.3v6 - 2010/08/21

fixed items with the same itemID showing up multiple times in the force item menu
fixed forced slots not being correctly updated when adding or deleting a set in the options frame
fixed bug when trying to calculate blood tank preset. Again, if you get an error with it from before this version, click the defense cap value, and overwrite it with <Enter>
Deathknights can now Dualwield. D'oh
Added first parts of plugin API. Documentation can be found at http://github.com/Mirroar/TopFit/wiki/API
Stats / Caps editor and virtual items UI use the new plugin functions.
Virtual items can now be included in set calculation, to see what would happen if you had a certain item. Items are not sanitized (you can calculate with a level 80 item or a plate item as a level 70 priest) and any calculation including virtual items will result in the set not being equipped.
Shamans and Warriors can now choose to simulate dual wielding or Titan's Grip for a set, indifferent of their current spec.

3.3v5 - 2010/07/17

fixed a bug with the preset protection paladin set - if you stil get an error calculating that set, update the defense cap value and it should work
fixed a bug where you could not select item sets as values to add
added a tooltip to TopFit's button in the character frame
automatic set update will now also happen on level up (to equip items you previosly could not because of level)
plate heirlooms should now correctly be chosen to equip for warriors, paladins and deathknights below level 40, same for mail heirlooms and hunters / shamans
items will no longer be tried to be equipped while you are dead
fixed scrollbars in options frame... again
the options frame will now move to the top level of the UI when you click it
you can now exclude individual sets from item tooltips (useful if you have multiple sets for different hitcaps, for example)

3.3v5 beta - 2010/06/24

items will no longer be equipped while you are in combat
item information is now properly cached, resulting in a performance increase
looking at the tooltip for an item that is not yet in the client's itemCache should no longer cause an error
comparing with items from your sets that are not in the client's itemCache should no longer cause an error
comparison tooltips for weapons expanded - comparison of two-handed weapons with one-hand + off-hand combinations should be greatly improved

3.3v4b - 2010/05/26

fixed a bug that caused unusable items to be included in set calculation

3.3v4 - 2010/05/24

added set values to ItemRefTooltip and ShoppingTooltips
added comparison value to toolip that shows how much of an improvement over currently equipped items another item is
when selecting an existing set in the calculations frame, the shown score will now correctly take enchantments and gems into account
fixed a couple of small bugs
fixed incompatibility with Skinner and similar addons

3.3v3b - 2010/04/16

fixed errors on login when an automatic update set had been set

3.3v3 - 2010/04/15

fixed bug where a new item would not be equipped if you already had an item with the same item-ID equipped e.g. [xxx of the Whale] and [xxx of the Bandit]
fixed bug with detecting BoE-items and accidentally trying to equip them if you had no other options for that slot
fixed a bug where fishing poles were considered One-Handed for Titan's Grip
rewrote calculation function for easier maintenance. This should also fix the swap-bug and any problems with invalid main- / offhand combinations
major options overhaul - set weights, forced items, etc. are now set in the calculations frame (expand the options by clicking the button labeled ">>")
added a button to the character frame which lets you open the calculations frame
added a button to the calculations frame which opens the addon's options
the calculations frame will now show wether caps have been reached or not
support for set pieces
added slash commands (/tf show, /tf options)
removed profiles from options (there should be no real need for those)
switched to tekKonfig for options (the few that remain)

3.3v2 - 2010/03/13

calculations frame can now be closed by pressing the ESC key
Binds-on-Equip-Items will no longer be included in set calculations - bind the item first if you intend to use it
added predefined sets from WoWHead (with very slight scores for armor and dps, so you can even use it starting at level 1)
added option to choose a set that will be updated whenever you get new equipment (will not show calculation frame or any output, designed for carefree questing)
fixed bug where statlist in progress frame would not show correctly if you had no item with a chosen stat
fixed bug when determining wether a weapon can be used for Titan's Grip

3.3v1 - 2010/03/11

initial release version

Comment Options

Page 3 of 6

Last »

07-18-10, 03:28 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

v3.3v5. Deleted old saved variables. Logged on with a 72 Prot Warrior. Went into options, checkmarked the two "Show..." options. Did not change Automatic update set from the default None. Opened the TopFit frame from the character frame, clicked Start without changing anything and:

Code:

["message"] = {
                "TopFit-3.3v5 alpha\\frame.lua:803: attempt to compare string with number\nTopFit-3.3v5 alpha\\frame.lua:654: in function `SetSelectedSet'\nTopFit-3.3v5 alpha\\options.lua:132: in function `AddSet'\nTopFit-3.3v5 alpha\\frame.lua:158: in function `func'\nInterface\\FrameXML\\UIDropDownMenu.lua:583: in function `UIDropDownMenuButton_OnClick':\n<string>:\"*:OnClick\":1: in function <[string \"*:OnClick\"]:1>\n\nLocals:|r\nself = TopFit_ProgressFrame {\n renameSetButton = TopFit_ProgressFrame_renameSetButton {\n }\n progress = 1\n rightFrame = TopFit_ProgressFrame_rightFrame {\n }\n UpdateSetStats = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1047\n expandButton = TopFit_ProgressFrame_expandButton {\n }\n selectSetLabel = <unnamed> {\n }\n editStatScrollFrame = TopFit_EditStatScrollFrame {\n }\n selectedSet = \"set_2\"\n SetSelectedSet = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:569\n isExpanded = false\n optionsButton = TopFit_ProgressFrame_optionsButton {\n }\n closeButton = TopFit_Pr", -- [1]
                "ogressFrame_closeButton {\n }\n addStatButton = TopFit_ProgressFrame_expandButton {\n }\n abortButton = TopFit_ProgressFrame_abortButton {\n }\n SetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:456\n progressText = <unnamed> {\n }\n deleteSetButton = TopFit_ProgressFrame_deleteSetButton {\n }\n setScoreFontString = <unnamed> {\n }\n HideStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1352\n ShowStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1282\n setDropDown = TopFit_ProgressFrame_setDropDown {\n }\n CreateHeaderButton = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1004\n setNameFontString = <unnamed> {\n }\n SetSetName = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:658\n equipButtons = <table> {\n }\n includeInTooltipCheckButton = <unnamed> {\n }\n addSetButton = TopFit_ProgressFrame_addSetButton {\n }\n statScrollFrame = TopFit_StatScrollFrame {\n }\n statDropDown = TopFit_ProgressFrame_statDropDown {\n }\n s", -- [2]
                "tartButton = TopFit_ProgressFrame_startButton {\n }\n StoppedCalculation = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:448\n 0 = <userdata>\n SetCurrentCombination = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:663\n progressBar = TopFit_ProgressFrame_StatusBar {\n }\n ResetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:439\n}\nsetCode = \"set_2\"\ncombination = <table> {\n items = <table> {\n }\n totalScore = 0\n totalStats = <table> {\n }\n}\nitemPositions = <table> {\n 1 = 1048577\n 2 = 1048578\n 3 = 1048579\n 4 = 1\n 5 = 1048581\n 6 = 1048582\n 7 = 1048583\n 8 = 1048584\n 9 = 1048585\n 10 = 1048586\n 11 = 1048587\n 12 = 1048588\n 13 = 1048589\n 14 = 1048590\n 15 = 1048591\n 16 = 1048592\n 17 = 1048593\n 18 = 1048594\n 19 = 1\n}\n\n  ---", -- [3]
            },
            ["type"] = "error",
            ["session"] = 279,
            ["counter"] = 1,
        }, -- [30]

Similar error in frame.lua (same line number) when selecting Protection & pressing Start. The frame also failed to show any gear in it. The defense cap could not be adjusted as gear & values failed to show up in the frame.

Was about to give up this mod up once again, but decided (after a few drinks) to give it one more shot for the Gipper. Logged out, logged back on. This time, selecting Protection in the dropdown and pressing Start actually worked without errors for some reason. The frame was filled with my gear and the tooltip data appeared as expected.

So this needs more work, but is not unusable.

06-24-10, 12:57 PM
Mirroar A Defias Bandit Forum posts: 3 File comments: 32 Uploads: 2	v5 beta Edit: 3.3v5 is out. Zidomo, if you still have the Problem with your Protection set, click the cap value for defense rating, and just press enter without chaning the number. It should work again. --------- old post below Alright, I finally fixed the calculation problems. I want to give it a couple more days for testing before I release 3.3v5, but if you really need an updated version right now, you can get it from gitHub (http://github.com/Mirroar/TopFit, download source) or Curse (it's a beta release). It should work just fine, I just want to make some mostly cosmetic changes and check Zidomo's bug before I do the actual release. Last edited by Mirroar : 07-17-10 at 07:02 AM.

06-18-10, 05:15 AM
Mirroar A Defias Bandit Forum posts: 3 File comments: 32 Uploads: 2	Okay, Zidomo has arrived and brought one of his dreaded bug reports with him. Just kidding, thank you for the info, I'll have a look into it. As for a new release, it'll unfortunately take a little while longer. Since my current implementation for the update broke so many things, I'm redoing it again, this time properly. I can't give you an ETA yet, but as soon as I have something that looks alright I'll at least put it up on github and post a message here. Last edited by Mirroar : 06-18-10 at 07:50 AM.

06-17-10, 02:58 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

And more errors in 3.3v4b (USEnglish server/client, WoW 3.3.3a live), different from what has been posted below.

Creating a new Retribution set from bag equipment on a mid level Paladin:

Code:

["message"] = "TopFit-3.3v4b\\frame.lua:783: attempt to compare string with number\nTopFit-3.3v4b\\calculation.lua:364: in function <Interface\\AddOns\\TopFit\\calculation.lua:247>\n\nLocals:|r\nself = <unnamed> {\n 0 = <userdata>\n}\noperation = nil\ndone = true\n\n  ---",
            ["type"] = "error",
            ["session"] = 15,
            ["counter"] = 4,
        }, -- [4]

Switching to a Protection set (already made previously) by pressing the "Start" button after changing the dropdown in top left to "Protection":

Code:

 ["message"] = {
                "TopFit-3.3v4b\\frame.lua:783: attempt to compare string with number\nTopFit-3.3v4b\\frame.lua:635: in function `SetSelectedSet'\nTopFit-3.3v4b\\frame.lua:116: in function `func'\nInterface\\FrameXML\\UIDropDownMenu.lua:575: in function `UIDropDownMenuButton_OnClick':\n<string>:\"*:OnClick\":1: in function <[string \"*:OnClick\"]:1>\n\nLocals:|r\nself = TopFit_ProgressFrame {\n renameSetButton = TopFit_ProgressFrame_renameSetButton {\n }\n progress = 1\n rightFrame = TopFit_ProgressFrame_rightFrame {\n }\n UpdateSetStats = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1011\n expandButton = TopFit_ProgressFrame_expandButton {\n }\n selectSetLabel = <unnamed> {\n }\n editStatScrollFrame = TopFit_StatScrollFrame {\n }\n selectedSet = \"set_3\"\n SetSelectedSet = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:556\n isExpanded = true\n optionsButton = TopFit_ProgressFrame_optionsButton {\n }\n closeButton = TopFit_ProgressFrame_closeButton {\n }\n addStatButton = TopFit_ProgressFrame_expandButt", -- [1]
                "on {\n }\n abortButton = TopFit_ProgressFrame_abortButton {\n }\n SetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:444\n progressText = <unnamed> {\n }\n deleteSetButton = TopFit_ProgressFrame_deleteSetButton {\n }\n setScoreFontString = <unnamed> {\n }\n forceItemsFrame = TopFit_ProgressFrame_forceItemsFrame {\n }\n HideStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1314\n setDropDown = TopFit_ProgressFrame_setDropDown {\n }\n progressBar = TopFit_ProgressFrame_StatusBar {\n }\n setNameFontString = <unnamed> {\n }\n SetSetName = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:639\n equipButtons = <table> {\n }\n ShowStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1245\n addSetButton = TopFit_ProgressFrame_addSetButton {\n }\n statScrollFrame = TopFit_StatScrollFrame {\n }\n CreateHeaderButton = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:968\n startButton = TopFit_ProgressFrame_startButton {\n }\n StoppedCalculat", -- [2]
                "ion = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:436\n 0 = <userdata>\n SetCurrentCombination = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:644\n statDropDown = TopFit_ProgressFrame_statDropDown {\n }\n ResetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:427\n}\nsetCode = \"set_3\"\ncombination = <table> {\n items = <table> {\n }\n totalScore = 2690.253\n totalStats = <table> {\n }\n}\nitemPositions = <table> {\n 1 = 3146256\n 2 = 3146258\n 3 = 3146251\n 4 = 1\n 5 = 1048581\n 6 = 3146252\n 7 = 3146254\n 8 = 3146248\n 9 = 3146255\n 10 = 3146253\n 11 = 3146250\n 12 = 3146249\n 13 = 3146246\n 14 = 1\n 15 = 3146257\n 16 = 3146260\n 17 = 3145737\n 18 = 1\n 19 = 1\n}\n\n  ---", -- [3]
            },
            ["type"] = "error",
            ["session"] = 15,
            ["counter"] = 1,
        }, -- [5]
        {
            ["message"] = {
                "TopFit-3.3v4b\\frame.lua:783: attempt to compare string with number\nTopFit-3.3v4b\\frame.lua:635: in function `SetSelectedSet'\nTopFit-3.3v4b\\calculation.lua:145: in function `InitSemiRecursiveCalculations'\nTopFit-3.3v4b\\calculation.lua:87: in function `CalculateRecommendations'\nTopFit-3.3v4b\\calculation.lua:60: in function `CalculateSets'\nTopFit-3.3v4b\\frame.lua:81: in function <Interface\\AddOns\\TopFit\\frame.lua:77>\n\nLocals:|r\nself = TopFit_ProgressFrame {\n renameSetButton = TopFit_ProgressFrame_renameSetButton {\n }\n progress = 1\n rightFrame = TopFit_ProgressFrame_rightFrame {\n }\n UpdateSetStats = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1011\n expandButton = TopFit_ProgressFrame_expandButton {\n }\n selectSetLabel = <unnamed> {\n }\n editStatScrollFrame = TopFit_StatScrollFrame {\n }\n selectedSet = \"set_3\"\n SetSelectedSet = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:556\n isExpanded = true\n optionsButton = TopFit_ProgressFrame_optionsButton {\n }\n clo", -- [1]
                "seButton = TopFit_ProgressFrame_closeButton {\n }\n addStatButton = TopFit_ProgressFrame_expandButton {\n }\n abortButton = TopFit_ProgressFrame_abortButton {\n }\n SetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:444\n progressText = <unnamed> {\n }\n deleteSetButton = TopFit_ProgressFrame_deleteSetButton {\n }\n setScoreFontString = <unnamed> {\n }\n forceItemsFrame = TopFit_ProgressFrame_forceItemsFrame {\n }\n HideStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1314\n setDropDown = TopFit_ProgressFrame_setDropDown {\n }\n progressBar = TopFit_ProgressFrame_StatusBar {\n }\n setNameFontString = <unnamed> {\n }\n SetSetName = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:639\n equipButtons = <table> {\n }\n ShowStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1245\n addSetButton = TopFit_ProgressFrame_addSetButton {\n }\n statScrollFrame = TopFit_StatScrollFrame {\n }\n CreateHeaderButton = <function> defined @Interface\\", -- [2]
                "AddOns\\TopFit\\frame.lua:968\n startButton = TopFit_ProgressFrame_startButton {\n }\n StoppedCalculation = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:436\n 0 = <userdata>\n SetCurrentCombination = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:644\n statDropDown = TopFit_ProgressFrame_statDropDown {\n }\n ResetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:427\n}\nsetCode = \"set_3\"\ncombination = <table> {\n items = <table> {\n }\n totalScore = 2690.253\n totalStats = <table> {\n }\n}\nitemPositions = <table> {\n 1 = 3146256\n 2 = 3146258\n 3 = 3146251\n 4 = 1\n 5 = 1048581\n 6 = 3146252\n 7 = 3146254\n 8 = 3146248\n 9 = 3146255\n 10 = 3146253\n 11 = 3146250\n 12 = 3146249\n 13 = 3146246\n 14 = 1\n 15 = 3146257\n 16 = 3146260\n 17 = 3145737\n 18 = 1\n 19 = 1\n}\n\n  ---", -- [3]
            },
            ["type"] = "error",
            ["session"] = 15,
            ["counter"] = 3,
        }, -- [6]
        {
            ["message"] = {
                "TopFit-3.3v4b\\frame.lua:783: attempt to compare string with number\nTopFit-3.3v4b\\frame.lua:635: in function `SetSelectedSet'\nTopFit-3.3v4b\\calculation.lua:145: in function `InitSemiRecursiveCalculations'\nTopFit-3.3v4b\\calculation.lua:87: in function `CalculateRecommendations'\nTopFit-3.3v4b\\calculation.lua:303: in function <Interface\\AddOns\\TopFit\\calculation.lua:247>\n\nLocals:|r\nself = TopFit_ProgressFrame {\n renameSetButton = TopFit_ProgressFrame_renameSetButton {\n }\n progress = 1\n rightFrame = TopFit_ProgressFrame_rightFrame {\n }\n UpdateSetStats = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1011\n expandButton = TopFit_ProgressFrame_expandButton {\n }\n selectSetLabel = <unnamed> {\n }\n editStatScrollFrame = TopFit_StatScrollFrame {\n }\n selectedSet = \"set_3\"\n SetSelectedSet = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:556\n isExpanded = true\n optionsButton = TopFit_ProgressFrame_optionsButton {\n }\n closeButton = TopFit_ProgressFrame_closeButton {\n }", -- [1]
                "\n addStatButton = TopFit_ProgressFrame_expandButton {\n }\n abortButton = TopFit_ProgressFrame_abortButton {\n }\n SetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:444\n progressText = <unnamed> {\n }\n deleteSetButton = TopFit_ProgressFrame_deleteSetButton {\n }\n setScoreFontString = <unnamed> {\n }\n forceItemsFrame = TopFit_ProgressFrame_forceItemsFrame {\n }\n HideStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1314\n setDropDown = TopFit_ProgressFrame_setDropDown {\n }\n progressBar = TopFit_ProgressFrame_StatusBar {\n }\n setNameFontString = <unnamed> {\n }\n SetSetName = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:639\n equipButtons = <table> {\n }\n ShowStatEditTextBox = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:1245\n addSetButton = TopFit_ProgressFrame_addSetButton {\n }\n statScrollFrame = TopFit_StatScrollFrame {\n }\n CreateHeaderButton = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:968\n startButton = TopFi", -- [2]
                "t_ProgressFrame_startButton {\n }\n StoppedCalculation = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:436\n 0 = <userdata>\n SetCurrentCombination = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:644\n statDropDown = TopFit_ProgressFrame_statDropDown {\n }\n ResetProgress = <function> defined @Interface\\AddOns\\TopFit\\frame.lua:427\n}\nsetCode = \"set_3\"\ncombination = <table> {\n items = <table> {\n }\n totalScore = 2690.253\n totalStats = <table> {\n }\n}\nitemPositions = <table> {\n 1 = 3146256\n 2 = 3146258\n 3 = 3146251\n 4 = 1\n 5 = 1048581\n 6 = 3146252\n 7 = 3146254\n 8 = 3146248\n 9 = 3146255\n 10 = 3146253\n 11 = 3146250\n 12 = 3146249\n 13 = 3146246\n 14 = 1\n 15 = 3146257\n 16 = 3146260\n 17 = 3145737\n 18 = 1\n 19 = 1\n}\n\n  ---", -- [3]
            },
            ["type"] = "error",
            ["session"] = 15,
            ["counter"] = 3,
        }, -- [7]

This is a fine mod idea, look forward to trying it again when the bugs are out.

06-16-10, 02:24 PM
Boofoo_cracker A Defias Bandit Forum posts: 2 File comments: 11 Uploads: 0	Can't wait till this is updated. Good stuff.

06-13-10, 03:29 PM
Mirroar A Defias Bandit Forum posts: 3 File comments: 32 Uploads: 2	Next version is under way. Unfortunately a few things broke unexpectedly, so I will need a couple more days for testing the new code. The good news is, however, that toóltips are now working nicely, including comparisons between two-handed weapons and two-weapon-combos, without the major lag that my first tests had without proper caching And the bugs caused by items that are not in your items Cache should also be fixed. So once the set calculation works as intended again, I'll have the new release up.

06-11-10, 05:25 PM
Boofoo_cracker A Defias Bandit Forum posts: 2 File comments: 11 Uploads: 0	Thank you

06-11-10, 02:16 AM

Mirroar

A Defias Bandit

Forum posts: 3

File comments: 32

Uploads: 2

Originally posted by Boofoo_cracker
Hey, first off. I love your addon. I have to reloadui to use it though after each gear change. Would it also be possible to make this altasloot compatible?

The error is being fixed, expect an update this weekend.
I'm guessing for atlasloot compatibility you mean not throwing errors when you look at tooltips for those items. That should work with the next release, though I'm not sure if I get time to test it.

06-10-10, 01:01 PM
Boofoo_cracker A Defias Bandit Forum posts: 2 File comments: 11 Uploads: 0	Hey, first off. I love your addon. I have to reloadui to use it though after each gear change. Would it also be possible to make this altasloot compatible? I am getting this error 70x TopFit-3.3v4b\core.lua:120: Usage: GetItemInfo(itemID\|"name"\|"itemlink") TopFit-3.3v4b\core.lua:120: in function `GetItemInfoTable' TopFit-3.3v4b\core.lua:927: in function <TopFit\core.lua:830> TopFit-3.3v4b\core.lua:1091: in function <TopFit\core.lua:1081> <in C code>: ? <in C code>: ? <in C code>: ? <in C code>: ? <in C code>: ? <in C code>: ? <in C code>: in function `SetAuctionItem' Blizzard_AuctionUI\Blizzard_AuctionUI.lua:1581: in function `AuctionFrameItem_OnEnter' <string>:":OnUpdate":2: in function <[string ":OnUpdate"]:1>

06-07-10, 03:40 AM

Mirroar

A Defias Bandit

Forum posts: 3

File comments: 32

Uploads: 2

Originally posted by Nari
I believe it has something to do when I delete my cache folder (for NPCScan to work properly) and then when I loot some item, errors start to show

In that case I should have it fixed with the next version (hopefully this week), along with some performance improvements and a few other things

06-06-10, 10:23 AM
Nari A Kobold Labourer Forum posts: 1 File comments: 16 Uploads: 0	I believe it has something to do when I delete my cache folder (for NPCScan to work properly) and then when I loot some item, errors start to show

06-06-10, 09:48 AM

Mirroar

A Defias Bandit

Forum posts: 3

File comments: 32

Uploads: 2

Originally posted by Nari
I love this addon, but it is giving me alot of errors.
"TopFit-3.3v4b\core.lua:414: attempt to compare number with nil" usually come few hundred times.
Is there anything I can do about it?

I'm trying to find out what causes this error but currently can't reproduce it. Some more info would be greatly appreciated.

06-06-10, 05:45 AM
Nari A Kobold Labourer Forum posts: 1 File comments: 16 Uploads: 0	I love this addon, but it is giving me alot of errors. "TopFit-3.3v4b\core.lua:414: attempt to compare number with nil" usually come few hundred times. Is there anything I can do about it?

06-04-10, 01:35 PM
Falarin A Cyclonian Forum posts: 49 File comments: 38 Uploads: 0	That is really neat! Thanks ^_^

06-03-10, 02:45 AM

Mirroar

A Defias Bandit

Forum posts: 3

File comments: 32

Uploads: 2

Originally posted by Falarin
I was wondering why sometimes it shows two percentages for a piece of armor

Thanks

Right, I should document that somewhere, my bad.
When it shows two values, that is because the raw item values differ from the enchanted ones.
The first value is a comparison of both items in raw state (no enchants, no gems). This is usually the value you want to take into account when you decide wether to roll for a new piece of gear or not. It's the unenchanted, ungemmed stats of the new item vs. the unenchanted, ungemmed stats of your set's item.
The second value takes both items as they currently are, meaning that if they have gems and enchants, those values will count towards their score. This is of course the value that interests you if you compare two already enchanted pieces of gear.
If both percentages are the same, only one is displayed for your convenience

In the future, once I find the time to implement gem and enchantment suggestions, I'll also have a score for that.

Page 3 of 6

Last »

Thank you for wanting to support development of TopFit.

A donation button should pop up when you download the addon from WoWInterface, unless you deactivated it.
Of course, you could just use this one:

Report this File

Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.

[Disable these notices]